diff mbox series

[v3,14/24] xen/console: simplify console owner switch hint

Message ID 20250103-vuart-ns8250-v3-v1-14-c5d36b31d66c@ford.com (mailing list archive)
State New
Headers show
Series x86: introduce NS16550-compatible UART emulator | expand

Commit Message

Denis Mukhin via B4 Relay Jan. 4, 2025, 1:58 a.m. UTC 
From: Denis Mukhin <dmukhin@ford.com>

Update the hint with the combination of keys to press for the physical console
focus switch between the domains.

Signed-off-by: Denis Mukhin <dmukhin@ford.com>
---
 xen/drivers/char/console.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jan Beulich Jan. 28, 2025, 3:58 p.m. UTC | #1 
On 04.01.2025 02:58, Denis Mukhin via B4 Relay wrote:
> --- a/xen/drivers/char/console.c
> +++ b/xen/drivers/char/console.c
> @@ -518,8 +518,8 @@ int console_set_owner(domid_t domid)
>      console_owner = domid;
>  
>      if ( switch_code )
> -        printk(" (type 'CTRL-%c' three times to switch input)",
> -               opt_conswitch[0]);
> +        printk(" (type 'CTRL-%c%c%c' to switch input)",
> +               opt_conswitch[0], opt_conswitch[0], opt_conswitch[0]);

I view this as ambiguous: It could mean Ctrl-<?> Ctrl-<?> Ctrl-<?> or
Ctrl-<?> <?> <?>. Plus again - how's this related to the goal of the
series?

Jan
diff mbox series

Patch

diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
index f5ff3ebd830d631fa5d8fb5db1cf68adafcd02b4..1308236403df8a0f87aeb7e2c00a036c2d8433a7 100644
--- a/xen/drivers/char/console.c
+++ b/xen/drivers/char/console.c
@@ -518,8 +518,8 @@  int console_set_owner(domid_t domid)
     console_owner = domid;
 
     if ( switch_code )
-        printk(" (type 'CTRL-%c' three times to switch input)",
-               opt_conswitch[0]);
+        printk(" (type 'CTRL-%c%c%c' to switch input)",
+               opt_conswitch[0], opt_conswitch[0], opt_conswitch[0]);
     printk("\n");
 
     return 0;