[v3,08/24] xen/console: rename switch_serial_input() to console_switch_input()

Commit Message

Denis Mukhin via B4 Relay Jan. 4, 2025, 1:58 a.m. UTC

From: Denis Mukhin <[e-mail]>

Updated the name to highlight the physical console input selection logic:
existing code does not switch only serial console, it also switches debugging
console (debug I/O port and console hypercall).

Signed-off-by: Denis Mukhin <[e-mail]>
---
 xen/drivers/char/console.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Jason Andryuk Jan. 28, 2025, 12:26 a.m. UTC | #1

On 2025-01-03 20:58, Denis Mukhin via B4 Relay wrote:
> From: Denis Mukhin <[e-mail]>
> 
> Updated the name to highlight the physical console input selection logic:
> existing code does not switch only serial console, it also switches debugging
> console (debug I/O port and console hypercall).
> 
> Signed-off-by: Denis Mukhin <[e-mail]>

Reviewed-by: Jason Andryuk <[e-mail]>

Jan Beulich Jan. 28, 2025, 2:43 p.m. UTC | #2

On 04.01.2025 02:58, Denis Mukhin via B4 Relay wrote:
> From: Denis Mukhin <[e-mail]>
> 
> Updated the name to highlight the physical console input selection logic:
> existing code does not switch only serial console, it also switches debugging
> console (debug I/O port and console hypercall).

Would you mind clarify what you refer to by "debug I/O port" here? I can't
spot console_rx (which what the function alters) having any interaction with
that. I'm also having similar trouble with the console hypercall. (The
renaming is likely still okay to do, but I'd like to understand what I'm
presently missing.)

Jan

Patch

diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
index 0927c0564a67098c70dab576ebeda3825fadfb61..48866cf47beda39e48a7774277238273566382b1 100644
--- a/xen/drivers/char/console.c
+++ b/xen/drivers/char/console.c
@@ -486,7 +486,7 @@  void console_put_domain(struct domain *d)
         rcu_unlock_domain(d);
 }
 
-static void switch_serial_input(void)
+static void console_switch_input(void)
 {
     unsigned int next_rx = console_rx;
 
@@ -577,7 +577,7 @@  static void cf_check serial_rx(char c)
         /* We eat CTRL-<switch_char> in groups of 3 to switch console input. */
         if ( ++switch_code_count == 3 )
         {
-            switch_serial_input();
+            console_switch_input();
             switch_code_count = 0;
         }
         return;
@@ -1117,7 +1117,7 @@  void __init console_endboot(void)
                             "toggle host/guest log level adjustment", 0);
 
     /* Serial input is directed to DOM0 by default. */
-    switch_serial_input();
+    console_switch_input();
 }
 
 int __init console_has(const char *device)