From patchwork Mon Feb 17 02:49:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Volodymyr Babchuk X-Patchwork-Id: 13977023 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 419EEC021A9 for ; Mon, 17 Feb 2025 02:49:42 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.889652.1298710 (Exim 4.92) (envelope-from ) id 1tjrCF-0001rY-W1; Mon, 17 Feb 2025 02:49:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 889652.1298710; Mon, 17 Feb 2025 02:49:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tjrCF-0001qV-R6; Mon, 17 Feb 2025 02:49:23 +0000 Received: by outflank-mailman (input) for mailman id 889652; Mon, 17 Feb 2025 02:49:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tjrCE-0001oi-9J for xen-devel@lists.xenproject.org; Mon, 17 Feb 2025 02:49:22 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2061c.outbound.protection.outlook.com [2a01:111:f403:260e::61c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c9a9800f-ecd9-11ef-9aa6-95dc52dad729; Mon, 17 Feb 2025 03:49:20 +0100 (CET) Received: from GV1PR03MB10456.eurprd03.prod.outlook.com (2603:10a6:150:16a::21) by AS8PR03MB9534.eurprd03.prod.outlook.com (2603:10a6:20b:5a6::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.15; Mon, 17 Feb 2025 02:49:17 +0000 Received: from GV1PR03MB10456.eurprd03.prod.outlook.com ([fe80::a41e:5aa8:e298:757e]) by GV1PR03MB10456.eurprd03.prod.outlook.com ([fe80::a41e:5aa8:e298:757e%4]) with mapi id 15.20.8445.017; Mon, 17 Feb 2025 02:49:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c9a9800f-ecd9-11ef-9aa6-95dc52dad729 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NG+wiwxQ6pMdFp41D9W/vFk2TJxqpXF/CY/kBoLswCZjPmI61o2EXJv6HRG/n/oqmbi0tuLW7Q6X7ocMoiepAqxSzne5qo8t5K/P5zawqjAGlTu+L4Zpra8HKtsia70qx7O5y5cODZWnv8sr5yPYihEKkbbzAPSsqRjR0uLusZCrPBJ9GklM/+WsK4wgd7VFDFYToU1WDcwLWk+HRLeiqQQT68RAmnpgq+4orjYpAA9hZIgHAK0L0Y4lFTtN6pg4VCChmqztGruwLFe5L6GG1MhzMTUJ9lUhya1/8VYxNK7qKRi2CVAzBwE9BMMLJLDGMERHTqn1ubWb4Q6+ZEH5pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n7p/GHrjsr8F4ZE7rkQrmBs/1k/mYhuWeTWyLqZKz7g=; b=NijasZtXI8VIEBU7NmS9njbvyubIDqPL7huBQ9X9Nsso4+KI1QFN/d2eKBI5qYM9qZpvI6Qp0/TJQK2hE2uxkDp7wEP4T3LjCQKTKbi6T6vL/Lut7e7DpDH19TWkPfPcnLIgOZxfma+hB4z/ihlTyBPrICJEq4BW0wr5vLLgP4ha7ryR47ySXyBWlaRYV5hQerbIG7yGlZBj5xJzrXobmcacQGnPB1ZlDDJlGOhM8ajh1iFndEHTsHDjiN4ThLe0po1jaDffmyFl6RZkXvkDufZ57Q5+4XdJEOOwHA3thj1dY5x1OBwaxhYpwaQ4CmsV1ysXH2ws7SCAu5ik6ZofVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n7p/GHrjsr8F4ZE7rkQrmBs/1k/mYhuWeTWyLqZKz7g=; b=UawtOMqxOsTGYhjX0XY/PTf+A6mRnoF3kpyEkJ7mrj++AdNOVYDZjDexkAaOVy5yr7vSid7eTpK3AsR4Stbv/crHJEDIEewBdkSN2xdXdguUy19PIgC/3hCkCjC+qGLrJKvfyiewIMwL/y0ag6Ff92YVxAAy6LyYbOZ1l5TopIfwrLt2NM3GOsJlSSb7Hm2xDpThSFQEntodMKOTRd9VG+OwfjGr0lmxVp/aKkZNDGIGo7cVqx+KLtmVFM1ESy4RUVStEcsSshCFLO7/vYwY6lsRAG0TYGuYtrR3yhMMEq/oSPkRErucnzBnAWeaPn3pXDjlapdxPglsvLs8/UOUEA== From: Volodymyr Babchuk To: "xen-devel@lists.xenproject.org" CC: Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk , Julien Grall Subject: [PATCH v6 3/4] xen: arm: enable stack protector feature Thread-Topic: [PATCH v6 3/4] xen: arm: enable stack protector feature Thread-Index: AQHbgOaJE6kDVTbKPE2BH7sXiNdS9g== Date: Mon, 17 Feb 2025 02:49:17 +0000 Message-ID: <20250217024848.3059635-4-volodymyr_babchuk@epam.com> References: <20250217024848.3059635-1-volodymyr_babchuk@epam.com> In-Reply-To: <20250217024848.3059635-1-volodymyr_babchuk@epam.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.47.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: GV1PR03MB10456:EE_|AS8PR03MB9534:EE_ x-ms-office365-filtering-correlation-id: 365fe086-dc14-4bb5-7e56-08dd4efdac11 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|1800799024|376014|366016|38070700018; x-microsoft-antispam-message-info: =?iso-8859-1?q?rfSHn/zDoldMNOSymd4O29bfNa?= =?iso-8859-1?q?4JT1K6W8D8lL/9FVZhI2nl1rvXX/poSkcCl8NpNV/8wqj2OYwoy1abq7cEED?= =?iso-8859-1?q?1oqg+yltoKAg/rQFiXjmC0gXQAjrLp9FqJ0Bm17by/dnRO1bB9I1GUWGu1q/?= =?iso-8859-1?q?bW0T/wpXcHA3RKfBBy7QJh4jDc1NGMc/7jXd12fIBBwbbDnI4E66HvQiDnSE?= =?iso-8859-1?q?4H/8j73UhAfzJMe0Qva1VKtr8/RPOd8sCdnmciDd1OuH/0XK83sbpwAo28Ts?= =?iso-8859-1?q?0U1u5/pBtgsXsYzRkUbKEUbE624mxJOH0Gdy7YHmf7K3vG/afr44M5jVaAAc?= =?iso-8859-1?q?GAW2EGhXIbdbMc1QOWa7dDWqXRRTKAG5Qq8Ih4Tj3tzyV0+R7s/hum5UKv+v?= =?iso-8859-1?q?nRJshjFWlpsn61TfeJoZ/p1Bt7DlybF0l04M2YNxmdsTRkziegR5qJVFtklp?= =?iso-8859-1?q?b9XwMg5m7NrrmUdglru+zQ3uYoj3v3XaqoJGi2d3stbEqVaAF518kGt25EbX?= =?iso-8859-1?q?3p6ccqmC/Be+LGuJ3yjlx62WctcEHAlha3ASH3Y1iALS+YbUvwL2XezIrnIS?= =?iso-8859-1?q?VM5o7wafS3uN8Oa3/Hlh2pEsIJYaMz8VX5yUyGZfJHqcZn+DWbE4wfedL8/c?= =?iso-8859-1?q?wb2pnLzuXsIHwYprf3/9PNWYh9y44KmnPyrt1bdNji1sSyruxPRfawWijZ86?= =?iso-8859-1?q?1TJ0iW326f//44y1x5HDEOVWYezdX90QVO6AP+48RhhKBAmqO40jqM+7RD4k?= =?iso-8859-1?q?FoamTqrmuVPJZYL6Qee8DTFt25+0MMtuUuwGirzQDtMR295kp+/xI0pqmyZ7?= =?iso-8859-1?q?WqFZV96s59EMRSVHufImJg6WKDxUGuhwOPWk4bNzXLGlfFHF5QiuPZrzc/h+?= =?iso-8859-1?q?xAek5BZKgZXjKmadg1H//7nKvsxmZHuWrqr/VdvZPgmV35RpY5ktNacWkTId?= =?iso-8859-1?q?7bwnlSgciPkWQRQrslK7iS+hNii6I7vkxj0zvKemTq8O+Tp7OrYaD2KEUNHo?= =?iso-8859-1?q?E5Ypw6F8tyYjlS4YlukZdd7NI+e3p+CTpFMFY9QhUQb10Vb1U7Nj8qENYI94?= =?iso-8859-1?q?2BJQZJWswoxKGob904hYMvRsQzGaDUKBpHrjVp3YorsFy2ncZw9BYGXc6/ju?= =?iso-8859-1?q?PgQaCkfSF2AcOUO2uKDZSXrQbT7NaP1ceOUJ1ZB1Y2iwH9NK27DY0bXBqwUb?= =?iso-8859-1?q?/f2zyiqd8KncRAfXtXXxWA3TkNwkF6doAqa5HWGNRWeWkoQ9jeEY8GVCDh+H?= =?iso-8859-1?q?wk6qoFLRO2cvLcwEnQZZzAMwHRXmHsAMbkndGpKX9qqbyJ8mnfRXaYfh4bxU?= =?iso-8859-1?q?EqaJvlPyNABmxPE9SO2J8+jAuti+WGLhbxtLmoMKZONzBV+e1ZtCbgVx2yFY?= =?iso-8859-1?q?vtw04fvntDnw6Rj7QlIDQuGCcWJJAOJ+bXXrpwlwGfg3ub3XA3KgMR4HR5tj?= =?iso-8859-1?q?19mIO2qi0Wjfag/xONLXQyUKQuEEs8JLyjzntp1eehqq7nUrk52KqniwL+oo?= =?iso-8859-1?q?KUmolo?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV1PR03MB10456.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(38070700018);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?q?7GehUKpaBNBVSSjToNNGDAm?= =?iso-8859-1?q?i3nWSLTRO8ZzyOl1TwcJL8GG3rEXe72Lj2CnxPnQU3w2JcKtPqxeDJNXrDn2?= =?iso-8859-1?q?Excl2LQAVX1q4b8SqQEr+LH6l+jL/45t8ikLoMJoTt1U9XKC2ThT0RzQdUh1?= =?iso-8859-1?q?owWZGlktisj9u3Gtgba29+UqF0yASV7gN1BIRX9G3vBrGtfNWteJNVZEWSyo?= =?iso-8859-1?q?+1HXCr+bzO7WmAvLsQulx+rzj6UKdAcfVfXFyBckZrEg6Y/2iFiVHowN2TOm?= =?iso-8859-1?q?sK9JdNlhERoH0HKZ+KwFO++fqzJvIKiFmxW/IWvMYTi+UHuYOmme46zxnePF?= =?iso-8859-1?q?Jf2h3UqQjtb6mBZ/PlKQIa/IygSGOvSAyPkAF9DboSQMfE1x6GyIJkOSWtVr?= =?iso-8859-1?q?eVRmi5LeCifNhh/fZURmkizuA1L6zacL4PGCieTNaOoi1OrHVLWLcUzbRp8R?= =?iso-8859-1?q?Ju/VxT1recIQGr7wjvDWOn/T4K54ou8lpO+8t2Yj8sdCdTsDxjPZBCSEqYPC?= =?iso-8859-1?q?ltSDGGN0v+9ZFb/M+i+/nJ/VrecE86MiwjGTwbuLxRTW4yJbjW7p5fC82D7C?= =?iso-8859-1?q?2WrmIUYBOthe4XPcgM8KjVMUA/QMVY7QZHjLQO0AI4Ips4c19mbwnZndcuyL?= =?iso-8859-1?q?/LBBTcnxkl7MDQDIFjIvw2h19ow8niHQIh9GsbeoWeQTB4ijrorT3FUNqGyc?= =?iso-8859-1?q?XQKgic+29lpidq0BqNBQvBUW5sKRQiSVGLOYvKwKYKKqongINx70c8UcFkRq?= =?iso-8859-1?q?SXDYMpTqMav52rOWxzpTq9OCCcIl8v96HslWoJWDYpinssGjIyCy9HyzueP2?= =?iso-8859-1?q?IcCkjGIfSS31jqOoBlqLDtJfrvKee1YaQASjNBKkXXGU0DYc/9Zvtq3owTj9?= =?iso-8859-1?q?7FbXODWgEWm6txoak6eRZjbI4fv6nZXVHzc0wqu8t/lWJH2KRyd6z0K3txVj?= =?iso-8859-1?q?8KrSGUpkGaRtlKrQhkAbjcMZaRV6eFbVlhMUlW7MzjKyPBHoUD3R29RX65KX?= =?iso-8859-1?q?yuHrDDVQNqID2DPIjmFqBH/zBvrTQXqX0diIdcKd5ILbKmeT8M0HV2gK/krQ?= =?iso-8859-1?q?0Jaxv9bEpT9IhM4kGoS9xK4Dh6bshT9OyUgER3Mk3oHWr+X9sy4epksO2cDG?= =?iso-8859-1?q?TKVnQT76QtqHSxnshPZgmaV2y6zhgx/ZDtYHAA+uP85r0eI9u0A2wda0WXcM?= =?iso-8859-1?q?q2vK32CFUs13s3vNJKwTUTqO+FXHbOHBAUfT+rn2z+T5rZ284vi0cEiwcS4E?= =?iso-8859-1?q?zrhpEYo8HHk+eHT25H4H8NNGaBxD7wT63KhEF53A+GzqDFKcV+d54UMYN2ki?= =?iso-8859-1?q?h0VKfJD2ujCtIny3R97lBqpoFeTAWWAOGrv6E5yKWtS+l0DuVGDlBJsFknKV?= =?iso-8859-1?q?ASd1zOBQbXP6EK2RP65ZNn27pywwMfec2IkYLN9c79117Jlfo8LFqy8e4XYu?= =?iso-8859-1?q?qx+9IIFFwbTziFokhEdOWPaALdMP9JVdnbEz8drI/rVUt9YP9RGDSIkGmiQH?= =?iso-8859-1?q?0RWbe3tGdCprwbiJMZiJMtirpoCGjPkxUxiJv9/uqxEwxHtwu6d7sUOKBtsN?= =?iso-8859-1?q?QR3VI/IF4B2IThNdXoxGXa7/9afHx3h30wvQjaUl3GLMn1bLjSTO1hauMLMw?= =?iso-8859-1?q?8GBh+jCF7bL46hA1GRcibU7sEv7WGCcbeeHL2/w=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: GV1PR03MB10456.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 365fe086-dc14-4bb5-7e56-08dd4efdac11 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2025 02:49:17.4106 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Yl8YKWxG8WzK5FXwldUWMGP7QZbjC2OURPkBp2DwI2lUIZDWLqyOnQU/km54ce1XUDMZ1fcwxwqhPcs5kPh7C/NS7+m4h9UU8cTELilpkYs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB9534 Enable previously added CONFIG_STACK_PROTECTOR feature for ARM platform. Initialize stack protector magic value very early, at the very beginning of start_xen() function. We want to do this early because prior to that boot_stack_chk_guard_setup() call, default stack protector guard value is used. While it is fine for general development and testing, it does not provide highest security level, because potential attacker will know the default value and can alter a payload, so correct stack guard value will be placed in the correct position. Apart from that argument, boot_stack_chk_guard_setup() should be called prior to enabling secondary CPUs to avoid race with them. Signed-off-by: Volodymyr Babchuk Acked-by: Julien Grall --- Changes in v6: - Expanded the commit message - Added Julien's A-b tag Changes in v5: - Call boot_stack_chk_guard_setup() from start_xen() instead of early ASM --- xen/arch/arm/Kconfig | 1 + xen/arch/arm/setup.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index a26d3e1182..8f1a3c7d74 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -16,6 +16,7 @@ config ARM select GENERIC_UART_INIT select HAS_ALTERNATIVE if HAS_VMAP select HAS_DEVICE_TREE + select HAS_STACK_PROTECTOR select HAS_UBSAN config ARCH_DEFCONFIG diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index c1f2d1b89d..0dca691207 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -30,6 +30,7 @@ #include #include #include +#include #include #include #include @@ -305,6 +306,8 @@ void asmlinkage __init start_xen(unsigned long fdt_paddr) struct domain *d; int rc, i; + boot_stack_chk_guard_setup(); + dcache_line_bytes = read_dcache_line_bytes(); percpu_init_areas();