From patchwork Tue Mar 18 02:34:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Volodymyr Babchuk X-Patchwork-Id: 14020201 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9CA0C35FF9 for ; Tue, 18 Mar 2025 02:34:51 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.918403.1323118 (Exim 4.92) (envelope-from ) id 1tuMmm-0005OJ-Ve; Tue, 18 Mar 2025 02:34:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 918403.1323118; Tue, 18 Mar 2025 02:34:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tuMmm-0005OC-SC; Tue, 18 Mar 2025 02:34:32 +0000 Received: by outflank-mailman (input) for mailman id 918403; Tue, 18 Mar 2025 02:34:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tuMml-0004hg-CP for xen-devel@lists.xenproject.org; Tue, 18 Mar 2025 02:34:31 +0000 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazlp170110001.outbound.protection.outlook.com [2a01:111:f403:c200::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 84a2aa4f-03a1-11f0-9899-31a8f345e629; Tue, 18 Mar 2025 03:34:29 +0100 (CET) Received: from GV1PR03MB10456.eurprd03.prod.outlook.com (2603:10a6:150:16a::21) by VI0PR03MB10565.eurprd03.prod.outlook.com (2603:10a6:800:20c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.33; Tue, 18 Mar 2025 02:34:21 +0000 Received: from GV1PR03MB10456.eurprd03.prod.outlook.com ([fe80::a41e:5aa8:e298:757e]) by GV1PR03MB10456.eurprd03.prod.outlook.com ([fe80::a41e:5aa8:e298:757e%4]) with mapi id 15.20.8534.031; Tue, 18 Mar 2025 02:34:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 84a2aa4f-03a1-11f0-9899-31a8f345e629 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JAtKsDizaGLABh2as4WKMSbP2b3HQozYNMQzdiOBWf4MAcYYl8OoWKXPZyDP6nVgtKI0CAMqmFiNOtg4G18X612awUx+/96CWCCoJQw4SyIqB/Y1Z0IWHo9KJRdxb5qcfY/RNhy0IfpieNdJEBmdsRM4J93MHRKj2sG1HYd5ntDBEIMbKtd7qxBgJZRZT7VF7hHDqxduMypsn/JiFAsyU293yhWw9+4KIDZGVh8C3mOFG9zlWzGaMSTXWbx5qZbYJe5Tpji2usOVysz4PaAonVxDxsiBTMlcvm+5xg9Ii39nwkxgtl+m1fUPycDxpRjRfW9vH3kGF72YCkD89LTQPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PfIgfIDoaXKyQ0Ye0/pA+kr9b+4erfmqyiKrr/jzcao=; b=wSD3oc7EglKNXOq0dUM9C37hY1BTlFbiVOuXQPpST7BBYQdkMavSCsLToqCkiaMUupGBGqwbHJd+VAUM7eExC3Zu74jxDcTzRu7dDoq6Dl/Dmoys7q6EsGe9GD54VxHjb4Iw3zQj3hRWCPYfe8T+KmGI2s//O4WmfwO2F6T6L0YmSPl0LwVyoDJU7nroFqXQsHHueUIEPtcLMEd+hnfwRdX9hu7nEODpNLacwUgPEs98ClVGyHZJo4oc05Z4NxuzUPApM66JyqT45UoZLYCov9NgBZSrra6RgRcgACwBOTJ7PYf0ztMGAO2ohQF6UFpepbJpbwI1Zx8I8MXQ+j5BMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PfIgfIDoaXKyQ0Ye0/pA+kr9b+4erfmqyiKrr/jzcao=; b=UPIkM1X9UAevy9gnO2A1IINmF9nhBz6DdhaZ3LuMXClpYSqg/c1lgDBJAoqNaOSzfkp5ycCLXtxJAAu7bB0F/nCTEApUnR+S9ufy1Prr4PRg6dkTbbZIwYhfXbGCiIt9wcBMaX2bmr5kLbjbAbzDTgMUmP16XYy6rNpH2K/LFhGf27z2p3pTxPq5I7xwlGG6Gr/f6kqpVSSzk/++yBy781+1FSCkWGAAuktXtLRuI1WG5/3Ug5d/wvV8+NoNl01yiNvH0xnBmZlv29zraQvVVAKks4AfPfEfjEzT/aA2C3A+3Se0xJQh2hkiU0sYr7TOMEOAl+BB1hIfTbq6ryf8+g== From: Volodymyr Babchuk To: "xen-devel@lists.xenproject.org" CC: Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk , Julien Grall Subject: [PATCH v7 2/3] xen: arm: enable stack protector feature Thread-Topic: [PATCH v7 2/3] xen: arm: enable stack protector feature Thread-Index: AQHbl64+nK1qcyuMXkOHD2CNqoxb4Q== Date: Tue, 18 Mar 2025 02:34:16 +0000 Message-ID: <20250318023234.1210659-3-volodymyr_babchuk@epam.com> References: <20250318023234.1210659-1-volodymyr_babchuk@epam.com> In-Reply-To: <20250318023234.1210659-1-volodymyr_babchuk@epam.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.48.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: GV1PR03MB10456:EE_|VI0PR03MB10565:EE_ x-ms-office365-filtering-correlation-id: bed78708-a625-4b98-b50d-08dd65c563b4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|1800799024|366016|376014|38070700018; x-microsoft-antispam-message-info: =?iso-8859-1?q?9fqFbNb6QtfqKNMGq+WW4Iq+oC?= =?iso-8859-1?q?dabRK9sIw+XjUk0zqLJgAx6Al1/wADpOXupm3YavleGYIlXAjzLpelz9vcAL?= =?iso-8859-1?q?IbA7uRxUtMHiPJJkmruKzjBeaklvqbAGoWb2LumjlsUOAIY6x6IhlEHQVUP6?= =?iso-8859-1?q?1NQn28KKWA4lYgGCBIbxBEaGNL5MY87mSo1QAHcZh4+/DU4JNLdZRwj+b2uM?= =?iso-8859-1?q?3UTqBlFkoHOCEaT8kEBKH2d9xXUprnxUozCXYvqOpu6DX5ZAZJBuXZC3wvsF?= =?iso-8859-1?q?R5VIXZxqk7+uoUBmhXha+5s5artrn/4n2anlgGtuTHB9C1vxp6lUOJRCzvhr?= =?iso-8859-1?q?mol7y5bUgjkpt/LqjQq+mDuTHmpf7Bx8ePNxWlKvC/01KwnrlbqgX1i9SnyG?= =?iso-8859-1?q?iDv1fOap99a4neMHe9StTYX9IEw51XKHlER7A7uRK/8rclrI1QN/Z5U11SZ3?= =?iso-8859-1?q?1bnGjlF0D9lWPwREknj0vb2Ulmg25VwJYCP35ZezSPC1tuoHe7oSWhsMY2bD?= =?iso-8859-1?q?JsZfT0VVulNoTd8FFEiKsMifR9I6FTsWB2rCHtjeUInSRehH99tZExdfzn/J?= =?iso-8859-1?q?sTwQp0aoHz+3gaFueMdll6K9MqWhuTUprx5+cBjtpN4rxi/jRlMAk/YSSOBS?= =?iso-8859-1?q?9eL5xoBj8JsGRfqiiOHXrH+lxDwQItKauwOeaj95w/SoVdGAtvyxGBo3Re+A?= =?iso-8859-1?q?WJITzHaMM6JJhLnsS1+x3Tra1WZ1mUjsQM79+A5/6BavJ+GqJQosbhbX7Oen?= =?iso-8859-1?q?kaQns8t3N4TldsIXiTUbns8svhc4sgVIYvLPdfakx2YZ8aaNhTiVEt7b2ck9?= =?iso-8859-1?q?6pj3hNaWmrZpnbuZpEW4Ix3urvjJtoPHEK4Yg5swmZUlaFS/JJM1IcVv+Okv?= =?iso-8859-1?q?l2c6v7vtYqsvuqGhUtw+BBcik0So0bvyVltSlAAw95fgU9g02EzH+i7pScvQ?= =?iso-8859-1?q?eeHgBLIXY4tZaCuCGUbyZBKp8v8XxXSuj37Um0Xe4zXTQGBvW6Afd2WEIdYK?= =?iso-8859-1?q?QfyhjyGOCwIyBM7NEQzsp+7NdjJ5Lv5RPrCse2YTswaNnGS8yvgXnEkhVo/P?= =?iso-8859-1?q?WyyJ3g+JrfmHZ/xOuza+8+Jtvw57lJPhtmD8U6/32OTiXIXTBpOfrhIWssoZ?= =?iso-8859-1?q?WJH56ZIMbzE0SebEayA69C/DAALEOyx2zIRu8SESa6CRdxO1rSIMl2hL0Dii?= =?iso-8859-1?q?TKa5qDp+qpEqJBJjYXmpTz/WvaVDMLIjkY1AX5ZoZRGQ1bwI1rnKfAfJ/N5S?= =?iso-8859-1?q?jVOn20JpGs5kDcKwo1owLrVoIBwYxuIltRBY7j5Vy13ipUHLm70oGykq91zC?= =?iso-8859-1?q?7B4QISN/sSfr2YR6+NJhoLjN6RrpAI15eG7FbP5PHikEC8yWInnFIs/0BU5A?= =?iso-8859-1?q?2FRau7arYC5rHAnGZSkqWSg9q6c3XzbE7uD1dO4/S2fbdV4gqWmfX/0gc9VN?= =?iso-8859-1?q?DOpFi9QUGkoYnF4up5Kkg9/+HL5Iyxeh39nQrbHGth/gaR5SaUqQ+r7ZsJls?= =?iso-8859-1?q?Pwescc?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV1PR03MB10456.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(38070700018);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?q?GxaJvlYJlQpdsZrVmidVU/A?= =?iso-8859-1?q?OPCtB5BdPmL0r8KclJHeemLQ65jbMCkgIU8rMtEY6IgQ+7T8y4xqbIQIg0mP?= =?iso-8859-1?q?ajZS+ou5GNIx4/9t+yPKvF4aec2wlzMsibkbdy7IFCx7siBNOVu2xrZJzT/B?= =?iso-8859-1?q?KJoJw5ilq8fANobx9PPKxZqlAIxaTkNZFXRsL9r5VeDyZAhg8m457N8RwOye?= =?iso-8859-1?q?JQHNi5TpyAA0bxj5vginUIFcj19s34pll9VTSwTgVGTzkhUwrZoNE+1IHj7m?= =?iso-8859-1?q?N7MuOB4FDMNDjdySCOSKBsAJUNR80RsAH940lPq3OixUiwcpRL8b+mMoJNgP?= =?iso-8859-1?q?DmccUSkmTiB7BkHDb6B3zkk61NJzXoq/bK0fvwI7k8wA3kv9j36HrL09TaLO?= =?iso-8859-1?q?t8kj3/NqbnW+lgPvq2W7kBUxkFM/5ONTZJa9bhclCmPALVFePIKKUgXpLYuW?= =?iso-8859-1?q?Qp4pSkKmaVklaAQhINFMiTkcH75oy4vASPJsBVI4aBXM1b07KMkcMoNaeJ1x?= =?iso-8859-1?q?ckQrL8vYw1qE9aHA580Wv3PnQxVcRRpRUKiSXA93ztxJyxb/EIMFYeY8Dqav?= =?iso-8859-1?q?OMYdAkNQvH2aoFYsk3n4hC6tcDNV2Zlm+t7ur2/Ik8Rx1QV1G91HSHPSh7m/?= =?iso-8859-1?q?vvZ+0+7dZmP5U2Ii5PqMxD+DAsHB7P9fB3TNWeA+rVH0Or/rQ4lI1CYQ3wL2?= =?iso-8859-1?q?NwcZbnRkFAKVMSbVv2Uw5uY5zOnzi1RRTdLFZmmKM2t80XlwqlyyiH9YuXBU?= =?iso-8859-1?q?iY1YQ9UEOkZltEyiGgH+ahVVn7WUN0I0DDTrPDrB9Oq5rNAGNo0FNK0hseV6?= =?iso-8859-1?q?oLAjlMMf3wg0LOfBNBCRYQZTBUi79QIFPzH1qw4vV5uxMToPqQbMlnZRmdjZ?= =?iso-8859-1?q?H/Q1WF2cjdUsoGK8vT4p6cUamhyvUfWgFIQ2UwmwVQS9wQWMpEgvpt2N0c+4?= =?iso-8859-1?q?n/a8Ta45zx3jeZHTA1fpNSV5v56vmvzqquvwfW7Pk7Z2GrJtRiJyKO6E+J2Y?= =?iso-8859-1?q?oS4bsznwX01Z8V0GNusIm3GsIfSJKPq24apuohcJoXUPMVgUDOCBV0sFnbPE?= =?iso-8859-1?q?CB9nefBzcPAwypkF7tr9s9HYDpOK1xxdrI/ISVpQRetRT9TwT9dxSTJh6LLP?= =?iso-8859-1?q?ZlIIw6ac8nABRHtSMMjomeBxNP1P9zmZ5tngMPsxbySwNNx5VS1nNO/y/BAU?= =?iso-8859-1?q?Z4RZek5q7eOugNoknpV/kIrQvq3dYiT4dbYhqicQlHfPeWm/Xtj50IQROUXI?= =?iso-8859-1?q?d7R+RbFO/bwAAm68Dmz9AszdUPBejBTNRRoDvC5ZeVUKH+Vp4FNXb5gNHo/z?= =?iso-8859-1?q?DSJ5cq16JLBIkn0w6Qf/kNf141bb7Nq9VKkC5BByqCBAGusCXWKhaRZFo4sA?= =?iso-8859-1?q?RGR5/KJU56ispkS4QlCUfmiNFMFkKnPoH9/KfNnrOjtwxxfOpsXwtb0/3Toa?= =?iso-8859-1?q?E0gg1Tvi2RvwOSHFq4g3cKPnth1xJzeVV/ZKijByYG55EcbZ+OwSu6ty/9GV?= =?iso-8859-1?q?dU2xlsQ77Dp4LtZfEEgFfxtXyrNmwdtUBZt2FdwyqvW9ePbl+V1ZFBzoYR5G?= =?iso-8859-1?q?B5KdzvZZj6A0/Zr5XS3h+sXD/bPUK2x0dM0Lpkh/PESvCKbW17fxTywFR53c?= =?iso-8859-1?q?6H6HFqbtzfsGAXFtRIklv4ucxW9GmSpuWJprQhQ=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: GV1PR03MB10456.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bed78708-a625-4b98-b50d-08dd65c563b4 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Mar 2025 02:34:16.8716 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6z5+pxoWHc8mRdrlUmUVNi/UUEgIHgpBI+6bAncSZKfu782oAnv6kKY/opGJ6ghHmCeNDOTKBnC4N1/Gbb1U+CehdZ7wy4+PRXKBqkSOPkY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR03MB10565 Enable previously added CONFIG_STACK_PROTECTOR feature for ARM platform. Initialize stack protector magic value very early, at the very beginning of start_xen() function. We want to do this early because prior to that boot_stack_chk_guard_setup() call, default stack protector guard value is used. While it is fine for general development and testing, it does not provide highest security level, because potential attacker will know the default value and can alter a payload, so correct stack guard value will be placed in the correct position. Apart from that argument, boot_stack_chk_guard_setup() should be called prior to enabling secondary CPUs to avoid race with them. Signed-off-by: Volodymyr Babchuk Acked-by: Julien Grall --- Changes in v6: - Expanded the commit message - Added Julien's A-b tag Changes in v5: - Call boot_stack_chk_guard_setup() from start_xen() instead of early ASM --- xen/arch/arm/Kconfig | 1 + xen/arch/arm/setup.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index ffdff1f0a3..5d6870c817 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -15,6 +15,7 @@ config ARM select GENERIC_UART_INIT select HAS_ALTERNATIVE if HAS_VMAP select HAS_DEVICE_TREE + select HAS_STACK_PROTECTOR select HAS_UBSAN config ARCH_DEFCONFIG diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index ffcae900d7..fa11e6be9f 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -30,6 +30,7 @@ #include #include #include +#include #include #include #include @@ -306,6 +307,8 @@ void asmlinkage __init start_xen(unsigned long fdt_paddr) struct domain *d; int rc, i; + boot_stack_chk_guard_setup(); + dcache_line_bytes = read_dcache_line_bytes(); percpu_init_areas();