| Message ID | 20250318173547.59475-2-roger.pau@citrix.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | x86: generate xen.efi image with no write-execute sections | expand |
On 18/03/2025 5:35 pm, Roger Pau Monne wrote: > Clarify that trampoline_setup is only used for EFI when booted using the > multiboot2 entry point. > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> > --- > xen/arch/x86/boot/head.S | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S > index 1b3bd16fe575..59a2b5005cf6 100644 > --- a/xen/arch/x86/boot/head.S > +++ b/xen/arch/x86/boot/head.S > @@ -505,7 +505,8 @@ trampoline_bios_setup: > > trampoline_setup: > /* > - * Called on legacy BIOS and EFI platforms. > + * Called on legacy BIOS and EFI platforms when using multiboot (either > + * 1 or 2). > */ /* Called for Mutiboot entry, including MB2+EFI. */ is a little more concise? ~Andrew
On Tue, Mar 18, 2025 at 05:45:09PM +0000, Andrew Cooper wrote: > On 18/03/2025 5:35 pm, Roger Pau Monne wrote: > > Clarify that trampoline_setup is only used for EFI when booted using the > > multiboot2 entry point. > > > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> > > --- > > xen/arch/x86/boot/head.S | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S > > index 1b3bd16fe575..59a2b5005cf6 100644 > > --- a/xen/arch/x86/boot/head.S > > +++ b/xen/arch/x86/boot/head.S > > @@ -505,7 +505,8 @@ trampoline_bios_setup: > > > > trampoline_setup: > > /* > > - * Called on legacy BIOS and EFI platforms. > > + * Called on legacy BIOS and EFI platforms when using multiboot (either > > + * 1 or 2). > > */ > > /* Called for Mutiboot entry, including MB2+EFI. */ > > is a little more concise? That's fine. Would you like me to resend the adjusted version? Thanks, Roger.
On 19/03/2025 8:46 am, Roger Pau Monné wrote: > On Tue, Mar 18, 2025 at 05:45:09PM +0000, Andrew Cooper wrote: >> On 18/03/2025 5:35 pm, Roger Pau Monne wrote: >>> Clarify that trampoline_setup is only used for EFI when booted using the >>> multiboot2 entry point. >>> >>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> >>> --- >>> xen/arch/x86/boot/head.S | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S >>> index 1b3bd16fe575..59a2b5005cf6 100644 >>> --- a/xen/arch/x86/boot/head.S >>> +++ b/xen/arch/x86/boot/head.S >>> @@ -505,7 +505,8 @@ trampoline_bios_setup: >>> >>> trampoline_setup: >>> /* >>> - * Called on legacy BIOS and EFI platforms. >>> + * Called on legacy BIOS and EFI platforms when using multiboot (either >>> + * 1 or 2). >>> */ >> /* Called for Mutiboot entry, including MB2+EFI. */ >> >> is a little more concise? > That's fine. Would you like me to resend the adjusted version? Fix on commit. No point sending this one around for another revision. Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S index 1b3bd16fe575..59a2b5005cf6 100644 --- a/xen/arch/x86/boot/head.S +++ b/xen/arch/x86/boot/head.S @@ -505,7 +505,8 @@ trampoline_bios_setup: trampoline_setup: /* - * Called on legacy BIOS and EFI platforms. + * Called on legacy BIOS and EFI platforms when using multiboot (either + * 1 or 2). */ /* Save Xen image load base address for later use. */
Clarify that trampoline_setup is only used for EFI when booted using the multiboot2 entry point. Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> --- xen/arch/x86/boot/head.S | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)