From patchwork Thu Mar 27 00:40:51 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Volodymyr Babchuk X-Patchwork-Id: 14030657 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 326B7C3600E for ; Thu, 27 Mar 2025 00:41:23 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.928333.1331055 (Exim 4.92) (envelope-from ) id 1txbIz-0002JH-QR; Thu, 27 Mar 2025 00:41:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 928333.1331055; Thu, 27 Mar 2025 00:41:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1txbIz-0002Ih-LH; Thu, 27 Mar 2025 00:41:09 +0000 Received: by outflank-mailman (input) for mailman id 928333; Thu, 27 Mar 2025 00:41:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1txbIz-0002GY-2a for xen-devel@lists.xenproject.org; Thu, 27 Mar 2025 00:41:09 +0000 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazlp170120003.outbound.protection.outlook.com [2a01:111:f403:c200::3]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2c20bf79-0aa4-11f0-9ea3-5ba50f476ded; Thu, 27 Mar 2025 01:41:08 +0100 (CET) Received: from DU5PR03MB10441.eurprd03.prod.outlook.com (2603:10a6:10:516::14) by PAXPR03MB7698.eurprd03.prod.outlook.com (2603:10a6:102:204::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.44; Thu, 27 Mar 2025 00:40:53 +0000 Received: from DU5PR03MB10441.eurprd03.prod.outlook.com ([fe80::eeb8:470:6260:e5f4]) by DU5PR03MB10441.eurprd03.prod.outlook.com ([fe80::eeb8:470:6260:e5f4%5]) with mapi id 15.20.8534.043; Thu, 27 Mar 2025 00:40:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c20bf79-0aa4-11f0-9ea3-5ba50f476ded ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AKzzv1OeRjXHVIHaozXP04ACeXZ8+QE8RNOTn3UtpuOCcPmCtFfrgYWSOEDt9xXjXGOuus3zYBYMr2dbx9SWO/FvWLt3o8Gq/zTGlg1Iw2Ci9gkfEwzZ5IHe2y1a06eX4U7xclJjkXWLLKm0lOlyi4NU0hd/jNHJ1Xt0ys5wuJxABrwTmzrWwkHqMXLDv2OX1PeRMwqSs848LlDvXhc5myZnvi35HmJ1I9zrD3bC3GbsHChZy0Y0QAvbgAUasoru/9U7mKe30hISI/UWQ7quQMy0b2p7MToMsVefLiHl3n6fkgwq5A3oVDEdRE1j/N+0E4UmVEf7hBXVJ2KEwiG2AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SEZnUOLnZm9F/fmyW7D8ug/laXFR6uaOFnmYo9TVn0E=; b=GYkVVRwjOs2OJ0Wgo+sKM9kOEXCRQEnXMVGFVWPwTqqwSc0B9BYnLJk5gVw+mNZ3IpgymerqtcKdwpc3gZ+V32H9SMK1vXhsdEzMqpvl8WL1Ls2aX7Vf9Xc9i34HjjdxAA/jHMmYrpI/rh+RIAkmUbb3bL/2RwKyKrhSvxFrCjpXa7/CQUV0fHauxDWYzPeMNVLhcPHloz5jIPQUMrzz7lR9OU8xvlX7V91xJmdeOmGOAe2yf5qnUqZzN+KvjJe3Bf5yKWXt/Sc9snYc+2lS41WUMK1wg3OGit2S1Bcn8bTglpdbHOlZ1fffO5JFS85khA9Lny4xXwNtFYBWX4bBjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SEZnUOLnZm9F/fmyW7D8ug/laXFR6uaOFnmYo9TVn0E=; b=ITlLKW/CHDV10tOBzb3KEImNsz/PSXJz+6/R0BhbNWH9dHKnFS64/2n9mYcUl53p9bH0IHSMPqXC6iy5xsP9YRGecoo8hT4mc8gNqzoKDL8X6kbrRHrhLFMDk1ytgdFMdvqb79OlvilmQf9ajNA+EKIZt3b1SQoQZRV+pqiygZyyPDiLhGGCAdYWUWeBor08HQLj7hAL8mW2eiYOi7/FliSUt3AKipljZ1QS1ASRKEZ4Gkv6kBx+5z/qO+m+CHpoDThdNqK0VkIpGr+RjEfZte4Zem14rp/BKKCVbZ5UnlJNR4mPhZVXitIOW+J6nZMShyGePJpt3s8mDkPcIE7QQA== From: Volodymyr Babchuk To: "xen-devel@lists.xenproject.org" CC: Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?utf-8?q?Roger_Pau_Monn=C3=A9?= Subject: [PATCH v1 2/3] xen: x86: irq: initialize irq desc in create_irq() Thread-Topic: [PATCH v1 2/3] xen: x86: irq: initialize irq desc in create_irq() Thread-Index: AQHbnrDjW+8Ym1NjVUmmlSXcOEREog== Date: Thu, 27 Mar 2025 00:40:51 +0000 Message-ID: <20250327004044.2014048-3-volodymyr_babchuk@epam.com> References: <20250327004044.2014048-1-volodymyr_babchuk@epam.com> In-Reply-To: <20250327004044.2014048-1-volodymyr_babchuk@epam.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.48.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DU5PR03MB10441:EE_|PAXPR03MB7698:EE_ x-ms-office365-filtering-correlation-id: de088462-be6e-47c3-2908-08dd6cc80782 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|376014|1800799024|366016|38070700018; x-microsoft-antispam-message-info: =?utf-8?q?Z7N9uVYImyc0x2RA6JCSux69PzUj3gE?= =?utf-8?q?dWfCtHdfkD9RxLlnEDAmJYUtvjG5q6ioNpf1L9QImHDLhbkAeI+zzCL26pDe6BdEW?= =?utf-8?q?Ei320HC5Jwcqon5ciSvUS2Zpmh5QWvWQ3Js91oEekIgXCom5ufD4QPLQfWfHi1beU?= =?utf-8?q?J3NeG6MZvog5gmCBCFwmdVfZzlsz+vT/jxirnhd/KD/qELi0s/9zRohEjGa9+cWY2?= =?utf-8?q?Db6K1t571G2hFRFYqkfL/cEG2etXYgdcQcMqxQfOH8zzZiomh0YME2dF9gsSgDe2J?= =?utf-8?q?cNoV7XjPuHSK3ZEuyBVaYEdNOkLMkIYNVgWdW6Qxfpt5V86Ayp/VoNXsvGkUchllV?= =?utf-8?q?NpUzXT101nQd2ABm5B702XBuxUuvqAcVFVaCryWeh+lDTd+EiRO61fiMberG74GkG?= =?utf-8?q?4+0UgqMlYKT8Wrbe5/aum5niK5mewQZ3KKzhF6ti+2KIetiK3fuCau2wxke7eUMnE?= =?utf-8?q?Q/xLWWzy+MmKUC5b6MSg6RVUAPBOh9GQ+DzRrmtjsFij1JJ4FucM9i7rNgtJOwRjM?= =?utf-8?q?s9VO5cj4ylUBFKXaEU6Q1glhp6ow8C8Tcs79QLo25ELiN5EVPFoJk3JFV5MqC6epA?= =?utf-8?q?tBHL6mLJS/dTgtDLyqjhqnZjqVKjcqiJY46MiiJG7U6ICIh+EbAQi6HVZAUcWvplD?= =?utf-8?q?wMEDiJGHZ/JFXiL5GTL9EIzz391WTXPkZTcPYrOWfd3GlfuSDQrDmrAtxfnE7z0sU?= =?utf-8?q?JszTK6R7mCfUahOfBJnj96eCFAQnlEGwrWp+vlchE/fCOyTPRM5L5DR4EnqE/YPA1?= =?utf-8?q?6sXjFa9u+hx63AIj3tOAShLeV3bB5zxSe67lVVgGuBUgCZ+w3vUo9KxhDGnKpUuA6?= =?utf-8?q?gaZv5ISPsY0uI2ffA3Y7ui4mYAYPn76UrymYolSwWXOEMEN64upPEZTwhzsmVIOmh?= =?utf-8?q?SBrwTDemDHya6GbgWjqnCVLb3kuwTBqT0BBdkO2yVHcLFDMV41vdhMouTDxTtQwBm?= =?utf-8?q?kuY17nx0pUnh/uOp8K4CEB/e2ZlUXOXfDiM+ZrFK8q65w9er/zET6HJ2/Oxae3nJ2?= =?utf-8?q?DmXldGUMmnX5srdc07Ti7V1PeDkVQBF79zu7wyo5TfNp5InwjzEM0kjgQAui0qdU7?= =?utf-8?q?RRoy7FcByWETY2oC2wNHpCo4FFPL0NuXkK6RVDfeOHwrAmSuQLhYGU/zjGiolnum/?= =?utf-8?q?B/LwZv9uFd0E6DJSHtvmJO2dfUolRXf6YGycdI20wS4ghbE+RdJl31RvpJSMS14eS?= =?utf-8?q?w/oUKiCfeqHM8G0c93yV/j6Zsc3af68xTthNYl3th4uckcUqEP5T7nSHh1m2+MVFt?= =?utf-8?q?NpVLkQD5ep9wc3ZTyRAU7joFqxPNQdhnt4AV/alcbvJKYRbNnpk59LHjsJYGDQxy8?= =?utf-8?q?n3oUezFgu4nrw/vOeiujzlkPOs9PCxqpuYuFeH7bDsBGi9nyP811mM0FhOLLLxQGt?= =?utf-8?q?EEVxRheRA5w?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU5PR03MB10441.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016)(38070700018);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?p5S9ULPekGPGEb4POLiNQ6tm4X/g?= =?utf-8?q?hr1J2THslkUcNr+6LwW7AhEd28OGqwH3dekiYXbcp+7Q1E103nEx717hAQ0JIPOio?= =?utf-8?q?8UUlluulAQopGjqYJ/dRwDb2NX5JSnkhnW3iSgAg0qJO9JroEwlZdoI35YOFojyby?= =?utf-8?q?3vhuwIrnpY0h8IwXy7otquywV7UiYOxxGsLM0RwPQLc5ZIgiZAFARNdL2oZ4dkXS9?= =?utf-8?q?wjgbhN3oglxnXZTJu3zeUXYDY/IBjtvENVzUfW6QA/1B/qF5w/PsWGQ0PmoiNCWbH?= =?utf-8?q?eSzpCrYV/KaGFZJvJ4FGp0XX8bBZz7VzcfBDYx3taaSK3yQkDUXGC6Nk6SXofhMe4?= =?utf-8?q?xfoB60sXy1wOgZrov9BTsYGaOO/HNwp6Eaapmv4dznn1D44fcVUdZrhCUJa7etm6o?= =?utf-8?q?GDFA7tLkPYdnT1bpvhqsDhaYSSUoCnBAUcjbk4OEXo5LxsjSD0YPTHN5eNpV9dlx9?= =?utf-8?q?yzRJgTb4PTk1fF0hvNuss1AslWScdpuplIehoryVe1VGmXCXuSnqLM1CEZF/78w7+?= =?utf-8?q?xaLzwb2HjKaoXmcmuugRTqYeZkg3dAc1nHHw/xpsTrqAgoO3EiIroYKNkCAHVVnX/?= =?utf-8?q?KmZZEM2vOr+RPKycmxldjEf/kbqwD/Ys5/NOwpZTRX0Ih+q9Sw5WR9WXuo4v921pK?= =?utf-8?q?i0LPo0LcD2fxxmwBveXXK20vKZgtwSbnoL+V7XMXwVUOQ/VO0rIxIwmOwaH83It86?= =?utf-8?q?eMX8Ou21U0JNyVPA5jS+FSg3H+ImCSeYQ0DDHxweeWF7XxI1dt+AEsYdnJUseIoYf?= =?utf-8?q?JdntJd6ehxdwGnykf42IdYhdCZHFmlKaDpY2YFXCs7H0dJQh9hm2Zn4h+uMspFJWi?= =?utf-8?q?QsHn+onqhPoykzVitWr+Ae1O07FXvYrRbQNkrUqxai9UXMEIdS5kZJt7zaNhEeyqC?= =?utf-8?q?ADdETHsuyzDfPoghsiAPhM/bEM2GZeXKUkn8DFDCMHcfUPQBZENn75NdTKZAhg7sw?= =?utf-8?q?+W5kJ20G7VAzy1pMIraVUONd+tl3VRMBrWDPAE77PjNqSTjqynAhFvCHVeyb9VO3K?= =?utf-8?q?2Whm8jTdXz9ip5kehfbEd6YoBCOcV3mQ4pGLWNdx07KgjN17h8mUho43QkA/1bGn5?= =?utf-8?q?GxJu8byHPIwcLAS4z8GZym7b/xq+wtmhpk507/JGiT4lNmP7/ip17En37n6tokn5e?= =?utf-8?q?aoF8GXeHaK+PBFuhmBllLkK22NtzPQtHglT7gCJxJky1LPTC16gEtlM+mOeoP+Bqj?= =?utf-8?q?oqvZjYW2gaXsZb0bjKHHIk7mOzla5RRvDSbxYMJt2wV88rKdsXu4HXSlCD+iMN8Q4?= =?utf-8?q?k7wBUkKScaRII03r7QSzPcWphvADOdrhIW7if8pVEPyJXO85XuZE+TC6zEAPA3qgL?= =?utf-8?q?iiyyFBDPsLTklsB/H4eWRWlcSXTYA9UpjSXnqEnS0mfbyWZdt492Jy23c0iU7mWMT?= =?utf-8?q?RlVFR+rHqaEajvap+98PJjylCZJqsZRglkPqoS2W7oF2nUY25jtJix9NktMkZIqg5?= =?utf-8?q?JARc2Y7KLwVtmFvvzNzerXELrB6ccaWSuDCtwtk9Q2BXIJTtnVyr50R5d6X6iO8HT?= =?utf-8?q?CLEn6IwgbONOSgBsh4MuiqRgkHBm9+p25Q=3D=3D?= Content-ID: <53E02801B0E44A45951B7441C16259EA@eurprd03.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DU5PR03MB10441.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: de088462-be6e-47c3-2908-08dd6cc80782 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Mar 2025 00:40:51.0820 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: B2VxKxvEpq+7TuXqrw4S+wW1jVH5hZWxCHoTJNcLtP4pUI+zaaCOBVMkFb30/rwRmvx/Gx6+s6jRIjM7Z5TcxJub71JC9wjyqJA9KREqE64= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR03MB7698 While building xen with GCC 14.2.1 with "-fcondition-coverage" option, the compiler produces a false positive warning: arch/x86/irq.c: In function ‘create_irq’: arch/x86/irq.c:281:11: error: ‘desc’ may be used uninitialized [-Werror=maybe-uninitialized] 281 | ret = init_one_irq_desc(desc); | ^~~~~~~~~~~~~~~~~~~~~~~ arch/x86/irq.c:269:22: note: ‘desc’ was declared here 269 | struct irq_desc *desc; | ^~~~ cc1: all warnings being treated as errors make[2]: *** [Rules.mk:252: arch/x86/irq.o] Error 1 While we have signed/unsigned comparison both in "for" loop and in "if" statement, this still can't lead to use of uninitialized "desc", as either loop will be executed at least once, or the function will return early. So this is a clearly false positive warning. Anyways, initialize "desc" with NULL to make GCC happy. Signed-off-by: Volodymyr Babchuk --- Attempt to declare "irq" as "unsigned int" didn't changed anything, so looks like compiler infers unitialized via some other reasoning... And it is interesting that this issue can be observed only with MC/DC enabled. --- xen/arch/x86/irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c index dd8d921f18..ae7224a145 100644 --- a/xen/arch/x86/irq.c +++ b/xen/arch/x86/irq.c @@ -265,7 +265,7 @@ void __init clear_irq_vector(int irq) int create_irq(nodeid_t node, bool grant_access) { int irq, ret; - struct irq_desc *desc; + struct irq_desc *desc = NULL; for (irq = nr_irqs_gsi; irq < nr_irqs; irq++) {