From patchwork Fri Mar 28 12:19:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Volodymyr Babchuk X-Patchwork-Id: 14031881 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BCB58C36013 for ; Fri, 28 Mar 2025 12:20:09 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.930546.1333173 (Exim 4.92) (envelope-from ) id 1ty8gL-0006e7-1d; Fri, 28 Mar 2025 12:19:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 930546.1333173; Fri, 28 Mar 2025 12:19:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ty8gK-0006dy-TQ; Fri, 28 Mar 2025 12:19:28 +0000 Received: by outflank-mailman (input) for mailman id 930546; Fri, 28 Mar 2025 12:19:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ty8gJ-0006CK-Sy for xen-devel@lists.xenproject.org; Fri, 28 Mar 2025 12:19:27 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2062d.outbound.protection.outlook.com [2a01:111:f403:2614::62d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e3eaf481-0bce-11f0-9ffa-bf95429c2676; Fri, 28 Mar 2025 13:19:26 +0100 (CET) Received: from GV1PR03MB10456.eurprd03.prod.outlook.com (2603:10a6:150:16a::21) by AM9PR03MB7313.eurprd03.prod.outlook.com (2603:10a6:20b:273::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.46; Fri, 28 Mar 2025 12:19:18 +0000 Received: from GV1PR03MB10456.eurprd03.prod.outlook.com ([fe80::a41e:5aa8:e298:757e]) by GV1PR03MB10456.eurprd03.prod.outlook.com ([fe80::a41e:5aa8:e298:757e%4]) with mapi id 15.20.8534.043; Fri, 28 Mar 2025 12:19:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e3eaf481-0bce-11f0-9ffa-bf95429c2676 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Xz5suee5B+AZFHHD7ZkF+l4tDLBfXhGol/+G1psMkPWkulWWfUyitCu+vpCJIHmFaGH6/dDd0yLLK1TuhrR8JiibvoaI4rkLJMUDCLyB76KFqGmJQdY3vlmRZaY+en3Y8chKIrBAKs14vg3oGwD/+Mm7t5l6DkIDLy6iQW+X9z0wneeZ08ghNFBX2iJJ7voo/KA2JbP/tYpiSy0iMj/LBmBJpTpuexcRjdnoHbfzd/Nsbh+L/jGue9oarWn381OQ5oktjnvfcvdoHXHvV8Xu3uW8po9Becn/C823WWbeLqzNSeLQ7Ni/oC3kjheqtelrw2K+5rajupTLgY+4dqxqhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wUMGxm33AzvPgMSbFPnRpY/1DSFzSMIFU0d0bQ1ISWA=; b=P54w5QpWCivUhNRbHA45GIuPy/EyOndoZZL4LfCqvfn6iV9XFvUVsiIbgJFkLLCVM1mMO2lB4fdFXpvEBhK7cxFNDCWHdl3sX/D/akCWyXnvML6gKQclDyl/QGzwXbADjng+r6UIt3n3v/bsUS7j2n/KV9OcVxS382igDtQStabk23aFwdTZI8dDNOTP6qnkj0wr+nW0iRzEe+FV2Imojls5sFzckZBEO3D0ZQM7Kyfc8758nwiG9JtNAM5uW3yxde0mqO1N6/xhMn/JSaLVjB4KoAIgOtEynrhVzl0LJ36pBjfGm0uWBl3SABKU/4moeTRq2HC+cIKzJ9XXyPoYEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wUMGxm33AzvPgMSbFPnRpY/1DSFzSMIFU0d0bQ1ISWA=; b=Z266YCmDvqY9MyMPAJobw/CrdM61/edoOlTOhA+0YlydCzlZ3UQJ10VkWTQvMO2WX1Lja4PDgN3s8TYcV+ZrqibjC0oYlacAFtAYit+kYdj9SoNn3taVOJ/1oFoT+aNi/kc19CsptJwCdvSM6OqqlGZZL1OrrUVH8RqNbDBNDu0bj3I/uKTCgbtTmOK/+BtBKv3f9mnT8zG4H0GdGnIvVFrTksO/LEoTcI5IWAZ9JJAV+sNtlpq2sXzydwxVwkyvMRyCWLrcnNdZ/SrpqWd0lQpJV2QATZxQuq585c5iiGtEf7DRMVsyq4En12NIkGmu/KFtWch/Xi4000sanLanrw== From: Volodymyr Babchuk To: "xen-devel@lists.xenproject.org" CC: Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?utf-8?q?Roger_Pau_Monn=C3=A9?= Subject: [PATCH v2 2/3] xen: x86: irq: use do-while loop in create_irq() Thread-Topic: [PATCH v2 2/3] xen: x86: irq: use do-while loop in create_irq() Thread-Index: AQHbn9uhrkS1XYNimkOfzt6xc/nvUA== Date: Fri, 28 Mar 2025 12:19:18 +0000 Message-ID: <20250328121902.2134020-3-volodymyr_babchuk@epam.com> References: <20250328121902.2134020-1-volodymyr_babchuk@epam.com> In-Reply-To: <20250328121902.2134020-1-volodymyr_babchuk@epam.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.48.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: GV1PR03MB10456:EE_|AM9PR03MB7313:EE_ x-ms-office365-filtering-correlation-id: d47cdbba-3d14-41a9-4efb-08dd6df2c3a0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|1800799024|376014|366016|38070700018; x-microsoft-antispam-message-info: =?utf-8?q?e1ea8vcGInXrJKxcJokBcROgsK6/TvB?= =?utf-8?q?H7ADzgLxY6VZ8a+Jmkfv2lhYtLCrAUasb/ytcVn7WHwQR0AvYO0httA1NxW4b5kcn?= =?utf-8?q?lwaWbGYhrnjJsCJliCZ3W1XmNmRwEkPqr9lCLObmgN5JsNU0rzVN/5L0uM8C/XExs?= =?utf-8?q?RJrAl6sU4n9Go5ZsN9YwgORnTQ9lM4wBkIrb3s0ty/3yznfoI9BJrZXBCMfnbujAj?= =?utf-8?q?UjwEAnEpIzVBeFNVCJFAAvlnRVBGgu6WZ5Ym+jzV3YCDH9kK9od2jNV9LhOaFBXBC?= =?utf-8?q?LnO/wXlZPficwCxyvV0Bqt9j6Nm2xd3A89HzpMfFbMABcBacE7LO7fmUwKrT0OB5E?= =?utf-8?q?s/eOhgyJJ6hmKFpcWtFE7R/scaHTmSgehFXHz/cON//Ad0hZvVkMHFuY7duwyxpRB?= =?utf-8?q?1bCgJbPXCiJkZBSoLV16ZzQDFeFg2gZZi7VzYsd2Bh+z9j/wbWWtjObIe/yLFVBbW?= =?utf-8?q?x2DMvseZh6BV1mkSjwyzkFvUOGuM/XZ/NzLV2So9Qngvq3XFAFXsD1Vz1kKXZmRmK?= =?utf-8?q?+vCuau8++c00szCJO6NlJ+CCOchIFpuAtwb8SJtlkCEIlb060B1b1iRKMNQYrdNz2?= =?utf-8?q?zU6tAQcyzWY0m8YUwuTEo3JXozvykHo9hDMGFY6NoAiV8Oz0c33LKeGUM4t5qInKn?= =?utf-8?q?yliyPL2zgVkxoWXMCPtfHQLUbJIRvN0auE94aCFYlzeTyYL5G9LwxH9pztAylHM4N?= =?utf-8?q?AN5sR6hm7yDPymeDx2eCk3VxPvXwG13mwUWOzkQuMdZq2PwjMAWILo+uuki5FENQS?= =?utf-8?q?ZQWGb4mK2QSZRoknSxRHCdJfl+R+q3yxbvECftIIOcMqFOnINnf4RK0dkbcRDP883?= =?utf-8?q?NLDdgjoRPVNg8ueFxp5RlE7vK3vNPsbBYVkNM6U4c2d+iAcM4bXGSiySTcSiGH0U+?= =?utf-8?q?CoXRlb11/qPTW1RYmUvRvx8BYxoax9XAOefgZgAqjPMzXTBhy7z2votg6EQ7mDIxU?= =?utf-8?q?hMQJQUKdVl6MC8f5BkMQxYxRaJoHcl/lztEeMKMh9ebai7n5aKKxfw7NnkzHDzWNb?= =?utf-8?q?SB1moibzHWxFGpDOne2edyWCorzr3/inNetMJYOm5I2PK4PzhcMlKp90Hf8YSSJEZ?= =?utf-8?q?H+n5HOs25lq2RWdE3s9FNPBPwqu/7lBzYEOcBMSOnmGiyyYIbq6vmvWuTkSHNYwl3?= =?utf-8?q?0rQqVIlMJHO67jEbFvL4g3JQTZMooT6HTzKUBgH9iLoGgy3wG0gU3IJLEJixaa/6Q?= =?utf-8?q?sp3PaoNnY+D/mFIk8SwjIA6YtzCdutPkVcfNAtZgQmgtSkGBSoIPwqo5950T5YKUv?= =?utf-8?q?TtwYH28ltUsr/thTCOzAsrGvthgRVRh75CJy0VeY0hV4Bj/blllqd+zqxA3MqUiEZ?= =?utf-8?q?RXFZTO1WNdQ+tBYqVfFoT++fBrM53DPeMZBVE5WbDH2Q3wuYoZOYz2T6wPY+Avt7J?= =?utf-8?q?EgbTeHIX72n?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV1PR03MB10456.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(38070700018);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?3XUc4HpgI02pI5Mjqh8P+NjQ1Y7t?= =?utf-8?q?6QIJIg6EKiPgfwJjYaZ84RCiJuJMPAYU5BKOuPk0FLAsA/rQFP11jIxReQDsunh2J?= =?utf-8?q?KV3VPkaBv5/ZIPbHaJqHidjTsdm+7drXHRWalilc/lW4ZnA+lJ0uNbe8PMr2gNgdR?= =?utf-8?q?jmU6R026XwsB18mDROPzQcMqQM9yUGXX+p90QnJ4qQ9eiG9InVu5OfWu/bYfEnwhN?= =?utf-8?q?JVe/Jd+VdUR//GzCPJCG7Rx8Zb4UMcHdlutGN9gTQdirWZCMzdbK8SEtC8lLXUuK9?= =?utf-8?q?9my8OWIMGEjtiNkPA0rZDJu4URXfE+oAaoO3gUlygfYlyvGI0b9ZTDxFlbSs7JYkd?= =?utf-8?q?xTqgOvXiop3vFpg8bx8A6gTJzLZAD0uK8yBupW0GqHIE0af61DxnBeCGpiiapog4z?= =?utf-8?q?CcL/O7Qz1/Ct6mGY3fd8chIzLv5/UfrM9/ntTQOKdaAUC3gJuIemBBRLQByBJMOtx?= =?utf-8?q?KvlzZLYGJUVOYuehX+x8PAHmHpqIgEDHEj4kYolA40PkqbU5vQEpAqbrQMdOZcWJ3?= =?utf-8?q?ZHd3Xo0uHLWNpreir6lOXwqQg6d2KgKyGxgECOm8VTaK9hmPMppynGdFK5ydBGEfM?= =?utf-8?q?04kei2jXk0tYbz1w7+dXiRGMmzZpxrTX52iU7xDlxHFklcxox/bQNrTSId4j2YbwZ?= =?utf-8?q?OR2xdckb/EurVURVTkawdx0eJWVY+LbDQtx1qU11A1PZWy0EPoms4qgR9EeKXAQEm?= =?utf-8?q?JLfWBl6Y0jRCH4uJlKevO1YJ2RAzrITKi+jkd4ADmGVPgjNoc+wB2MV9vc02P6OkO?= =?utf-8?q?F7emASH3L1FnJSl4rOcmeltsV0TN7tr66ubxYiboEak/LLPVTfOhGAw75kkccWbCg?= =?utf-8?q?lk3DiyVaQAuIDwK+h7EqrfeZbiDdhORl79zbjLMwMN7o5OAWfxfK6NTV5B7ac2y4M?= =?utf-8?q?HrBTteJJucEyfkzKewQQWL1tO0EsOurMHwV2uTun27I83GnGOfjBeXSWvcr58hfa5?= =?utf-8?q?Pu4Wno737mdANknxIPRRpkKBt9GKqmDYCA48uZEgruwhzT9zC2WL7iixFKqwQpENH?= =?utf-8?q?6jPOkuWRoewrkWcyA9wtw2nf8cnaCb/2sOhEGETXbefgKKZ/hilnIEJnZCA9NRXK2?= =?utf-8?q?Pd0wDGNFCMJ0TN0OKjzFI3jcVUhTGrrhYE8eFMhLmjUlD5xi/sJ8GZhiucGTDbWuZ?= =?utf-8?q?g/Qtyna3DgOReXHfNnSIvV77iWCUVwvveAWvs16vf/sbI9UO0JIY8NcbxZuFL5mWa?= =?utf-8?q?YsdxAZ8R6WnV8wFyoclRg1ZSQBO6sPji7n9bW+E0YW6rTMQQ7GG/l7a3Kx0TMkVYF?= =?utf-8?q?hL6I1sZV4dX+UdZoKjVQo3NfryP0ypdw60KTUsZU2cYs3KXadYiYD2NCDRuC/rhE2?= =?utf-8?q?CHyVJW1xCyVPEskP1B5dQfIqQGwhGDS3Ofm2L4IIly7VlPs6mvRejxA3GgoSJeyi2?= =?utf-8?q?HH6pLNxtIHzJHiJtZ9FnIn3MX6UwW/G9CpZ7dbR4v+l0jCdFQWkQLfz44gqD/EDsv?= =?utf-8?q?YZUO2BCvQOt2yUAJGTPWD2HxjN/yGzh7a7+LKGyhiSxXLlNkP9qNeXzyo4jjJk047?= =?utf-8?q?qtqSX8drI9R4/gEWRjFFMf7fhUnOSg3NyQ=3D=3D?= Content-ID: <34A6328830B2D94DB9416E95A389FAC6@eurprd03.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: GV1PR03MB10456.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d47cdbba-3d14-41a9-4efb-08dd6df2c3a0 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2025 12:19:18.6980 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kjs5udCk1Wb6jQL3NcHXgU8jMQd6pnZ3WI8vdqXfg6PvJR28dffYZsGcYunbxzt3BRmREt4z09/gBuzsojkmHc7tn0h0FC3VtqkAgcRyjmU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB7313 While building xen with GCC 14.2.1 with "-fcondition-coverage" option, the compiler produces a false positive warning: arch/x86/irq.c: In function ‘create_irq’: arch/x86/irq.c:281:11: error: ‘desc’ may be used uninitialized [-Werror=maybe-uninitialized] 281 | ret = init_one_irq_desc(desc); | ^~~~~~~~~~~~~~~~~~~~~~~ arch/x86/irq.c:269:22: note: ‘desc’ was declared here 269 | struct irq_desc *desc; | ^~~~ cc1: all warnings being treated as errors make[2]: *** [Rules.mk:252: arch/x86/irq.o] Error 1 The same behavior can be observed when building Xen with "-Og" optimization level. Fix this by using "do { } while" loop instead of "for" loop. Signed-off-by: Volodymyr Babchuk --- Changes in v2: - Use do { } while loop instead of initializing desc with NULL --- xen/arch/x86/irq.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c index dd8d921f18..3224ada846 100644 --- a/xen/arch/x86/irq.c +++ b/xen/arch/x86/irq.c @@ -264,15 +264,19 @@ void __init clear_irq_vector(int irq) int create_irq(nodeid_t node, bool grant_access) { - int irq, ret; + int ret; + int irq = nr_irqs_gsi; struct irq_desc *desc; - for (irq = nr_irqs_gsi; irq < nr_irqs; irq++) + if ( irq >= nr_irqs ) + return -ENOSPC; + + do { desc = irq_to_desc(irq); if (cmpxchg(&desc->arch.used, IRQ_UNUSED, IRQ_RESERVED) == IRQ_UNUSED) break; - } + } while ( ++irq < nr_irqs ); if (irq >= nr_irqs) return -ENOSPC;