| Message ID | 20250328134427.874848-2-andrew.cooper3@citrix.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | xen: Centralise byteswap infrastructure | expand |
On 28.03.2025 14:44, Andrew Cooper wrote: > This logic was inserted by commit 447f613c5404 ("lzo: update LZO compression > to current upstream version") but was only relevant for the TMEM logic, so > should have been deleted in commit c492e19fdd05 ("xen: remove tmem from > hypervisor") > > Fixes: c492e19fdd05 ("xen: remove tmem from hypervisor") > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> Acked-by: Jan Beulich <jbeulich@suse.com>
diff --git a/xen/common/lzo.c b/xen/common/lzo.c index 3454ce4a7e24..07b4017812dc 100644 --- a/xen/common/lzo.c +++ b/xen/common/lzo.c @@ -28,27 +28,6 @@ #define COPY4(dst, src) memcpy(dst, src, 4) #define COPY8(dst, src) memcpy(dst, src, 8) -#ifdef __MINIOS__ -# include <lib.h> -# if __BYTE_ORDER == __LITTLE_ENDIAN -# undef __BIG_ENDIAN -# endif -# if __BYTE_ORDER == __BIG_ENDIAN -# undef __LITTLE_ENDIAN -# endif -#endif - -#if defined(__BIG_ENDIAN) && defined(__LITTLE_ENDIAN) -#error "conflicting endian definitions" -#elif defined(__x86_64__) -#define LZO_USE_CTZ64 1 -#define LZO_USE_CTZ32 1 -#elif defined(__i386__) || defined(__powerpc__) -#define LZO_USE_CTZ32 1 -#elif defined(__arm__) && (__LINUX_ARM_ARCH__ >= 5) -#define LZO_USE_CTZ32 1 -#endif - #define M1_MAX_OFFSET 0x0400 #define M2_MAX_OFFSET 0x0800 #define M3_MAX_OFFSET 0x4000
This logic was inserted by commit 447f613c5404 ("lzo: update LZO compression to current upstream version") but was only relevant for the TMEM logic, so should have been deleted in commit c492e19fdd05 ("xen: remove tmem from hypervisor") Fixes: c492e19fdd05 ("xen: remove tmem from hypervisor") Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> --- CC: Anthony PERARD <anthony.perard@vates.tech> CC: Michal Orzel <michal.orzel@amd.com> CC: Jan Beulich <jbeulich@suse.com> CC: Julien Grall <julien@xen.org> CC: Roger Pau Monné <roger.pau@citrix.com> CC: Stefano Stabellini <sstabellini@kernel.org> CC: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com> CC: Bertrand Marquis <bertrand.marquis@arm.com> CC: Shawn Anastasio <sanastasio@raptorengineering.com> CC: Oleksii Kurochko <oleksii.kurochko@gmail.com> CC: Daniel P. Smith <dpsmith@apertussolutions.com> CC: Lin Liu <lin.liu@citrix.com> Notably, this also removes the singular case where anything in Xen cares about the value in __BYTE_ORDER, __LITTLE_ENDIAN and __BIG_ENDIAN, and even then it was only an adaptation to the MiniOS environment. v5: * New. --- xen/common/lzo.c | 21 --------------------- 1 file changed, 21 deletions(-) base-commit: eecb9f437b2c3e2d22d0af93dc6b1f4d978313a7