diff mbox series

[v9,1/5] xen/riscv: use printk() instead of early_printk()

Message ID 22c78705e4559a049e72950dc311513f1c15e489.1719918148.git.oleksii.kurochko@gmail.com (mailing list archive)
State Superseded
Headers show
Series RISCV basic exception handling implementation | expand

Commit Message

Oleksii Kurochko July 2, 2024, 11:23 a.m. UTC 
As common code is available it is better to use printk() instead
of early_printk().

Also the printing of "Hello from RISC-V world" is dropped as
it is useless and "All set up is enough".

Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
---
 xen/arch/riscv/setup.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Jan Beulich July 10, 2024, 9:46 a.m. UTC | #1 
On 02.07.2024 13:23, Oleksii Kurochko wrote:
> As common code is available it is better to use printk() instead
> of early_printk().

IOW the function is not just available (allowing linking to succeed),
but is also fully functional (i.e. the line is making it out, and hence
CI, which iirc is looking for that string, is going to be "happy")? If
so:
Acked-by: Jan Beulich <jbeulich@suse.com>

Jan
Oleksii Kurochko July 11, 2024, 8:17 a.m. UTC | #2 
On Wed, 2024-07-10 at 11:46 +0200, Jan Beulich wrote:
> On 02.07.2024 13:23, Oleksii Kurochko wrote:
> > As common code is available it is better to use printk() instead
> > of early_printk().
> 
> IOW the function is not just available (allowing linking to succeed),
> but is also fully functional (i.e. the line is making it out, and
> hence
> CI, which iirc is looking for that string, is going to be "happy")?
> If
> so:
> Acked-by: Jan Beulich <jbeulich@suse.com>

I ran our gitlab CI and it works well on my side:
https://gitlab.com/xen-project/people/olkur/xen/-/pipelines/1355999714

~ Oleksii
diff mbox series

Patch

diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c
index 8bb5bdb2ae..e3cb0866d5 100644
--- a/xen/arch/riscv/setup.c
+++ b/xen/arch/riscv/setup.c
@@ -23,9 +23,7 @@  void __init noreturn start_xen(unsigned long bootcpu_id,
 {
     remove_identity_mapping();
 
-    early_printk("Hello from C env\n");
-
-    early_printk("All set up\n");
+    printk("All set up\n");
 
     for ( ;; )
         asm volatile ("wfi");