| Message ID | 26c5803fdb59bd0bd06f2509097d5929dd4f67f2.1640590794.git.ehem+xen@m5p.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Some misc from my tree | expand |
> On 18 Dec 2020, at 21:32, Elliott Mitchell <ehem+xen@m5p.com> wrote: > > With libxl having gotten a lot more constant, now printf_info_sexp() and > printf_info_one_json() can add consts. May not be particularly > important, but it is best to mark things constant when they are known to > be so. Looks ok to me Reviewed-by: Luca Fancellu <luca.fancellu@arm.com> > > Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com> > --- > tools/xl/xl.h | 2 +- > tools/xl/xl_info.c | 2 +- > tools/xl/xl_sxp.c | 6 +++--- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tools/xl/xl.h b/tools/xl/xl.h > index c5c4bedbdd..720adb0048 100644 > --- a/tools/xl/xl.h > +++ b/tools/xl/xl.h > @@ -300,7 +300,7 @@ typedef enum { > DOMAIN_RESTART_SOFT_RESET, /* Soft reset should be performed */ > } domain_restart_type; > > -extern void printf_info_sexp(int domid, libxl_domain_config *d_config, FILE *fh); > +extern void printf_info_sexp(int domid, const libxl_domain_config *d_config, FILE *fh); > extern void apply_global_affinity_masks(libxl_domain_type type, > libxl_bitmap *vcpu_affinity_array, > unsigned int size); > diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c > index 712b7638b0..23d82ce2a2 100644 > --- a/tools/xl/xl_info.c > +++ b/tools/xl/xl_info.c > @@ -59,7 +59,7 @@ static int maybe_printf(const char *fmt, ...) > } > > static yajl_gen_status printf_info_one_json(yajl_gen hand, int domid, > - libxl_domain_config *d_config) > + const libxl_domain_config *d_config) > { > yajl_gen_status s; > > diff --git a/tools/xl/xl_sxp.c b/tools/xl/xl_sxp.c > index 359a001570..d5b9051dfc 100644 > --- a/tools/xl/xl_sxp.c > +++ b/tools/xl/xl_sxp.c > @@ -26,13 +26,13 @@ > /* In general you should not add new output to this function since it > * is intended only for legacy use. > */ > -void printf_info_sexp(int domid, libxl_domain_config *d_config, FILE *fh) > +void printf_info_sexp(int domid, const libxl_domain_config *d_config, FILE *fh) > { > int i; > libxl_dominfo info; > > - libxl_domain_create_info *c_info = &d_config->c_info; > - libxl_domain_build_info *b_info = &d_config->b_info; > + const libxl_domain_create_info *c_info = &d_config->c_info; > + const libxl_domain_build_info *b_info = &d_config->b_info; > > fprintf(fh, "(domain\n\t(domid %d)\n", domid); > fprintf(fh, "\t(create_info)\n"); > -- > 2.30.2 > >
diff --git a/tools/xl/xl.h b/tools/xl/xl.h index c5c4bedbdd..720adb0048 100644 --- a/tools/xl/xl.h +++ b/tools/xl/xl.h @@ -300,7 +300,7 @@ typedef enum { DOMAIN_RESTART_SOFT_RESET, /* Soft reset should be performed */ } domain_restart_type; -extern void printf_info_sexp(int domid, libxl_domain_config *d_config, FILE *fh); +extern void printf_info_sexp(int domid, const libxl_domain_config *d_config, FILE *fh); extern void apply_global_affinity_masks(libxl_domain_type type, libxl_bitmap *vcpu_affinity_array, unsigned int size); diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c index 712b7638b0..23d82ce2a2 100644 --- a/tools/xl/xl_info.c +++ b/tools/xl/xl_info.c @@ -59,7 +59,7 @@ static int maybe_printf(const char *fmt, ...) } static yajl_gen_status printf_info_one_json(yajl_gen hand, int domid, - libxl_domain_config *d_config) + const libxl_domain_config *d_config) { yajl_gen_status s; diff --git a/tools/xl/xl_sxp.c b/tools/xl/xl_sxp.c index 359a001570..d5b9051dfc 100644 --- a/tools/xl/xl_sxp.c +++ b/tools/xl/xl_sxp.c @@ -26,13 +26,13 @@ /* In general you should not add new output to this function since it * is intended only for legacy use. */ -void printf_info_sexp(int domid, libxl_domain_config *d_config, FILE *fh) +void printf_info_sexp(int domid, const libxl_domain_config *d_config, FILE *fh) { int i; libxl_dominfo info; - libxl_domain_create_info *c_info = &d_config->c_info; - libxl_domain_build_info *b_info = &d_config->b_info; + const libxl_domain_create_info *c_info = &d_config->c_info; + const libxl_domain_build_info *b_info = &d_config->b_info; fprintf(fh, "(domain\n\t(domid %d)\n", domid); fprintf(fh, "\t(create_info)\n");
With libxl having gotten a lot more constant, now printf_info_sexp() and printf_info_one_json() can add consts. May not be particularly important, but it is best to mark things constant when they are known to be so. Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com> --- tools/xl/xl.h | 2 +- tools/xl/xl_info.c | 2 +- tools/xl/xl_sxp.c | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-)