From patchwork Mon Jul 10 08:55:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 13306493 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C53DEB64DC for ; Mon, 10 Jul 2023 08:55:51 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.561112.877441 (Exim 4.92) (envelope-from ) id 1qImg3-0008C2-EI; Mon, 10 Jul 2023 08:55:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 561112.877441; Mon, 10 Jul 2023 08:55:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qImg3-0008Bv-BZ; Mon, 10 Jul 2023 08:55:27 +0000 Received: by outflank-mailman (input) for mailman id 561112; Mon, 10 Jul 2023 08:55:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qImg2-000866-Js for xen-devel@lists.xenproject.org; Mon, 10 Jul 2023 08:55:26 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on062e.outbound.protection.outlook.com [2a01:111:f400:fe1f::62e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8215b0f2-1eff-11ee-8611-37d641c3527e; Mon, 10 Jul 2023 10:55:24 +0200 (CEST) Received: from AS8PR04MB8788.eurprd04.prod.outlook.com (2603:10a6:20b:42f::21) by DU2PR04MB9051.eurprd04.prod.outlook.com (2603:10a6:10:2e6::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.30; Mon, 10 Jul 2023 08:55:23 +0000 Received: from AS8PR04MB8788.eurprd04.prod.outlook.com ([fe80::cbc0:69aa:c9a2:198e]) by AS8PR04MB8788.eurprd04.prod.outlook.com ([fe80::cbc0:69aa:c9a2:198e%7]) with mapi id 15.20.6565.016; Mon, 10 Jul 2023 08:55:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8215b0f2-1eff-11ee-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cddsQu99PE3DyMrHn0ulLf8nGqW6C09RoivrLbVe0a3Y1NDs/j62GYLBotRUInhy8I5ZMHEYIJfAqdElpiMOEvMV7sPZojUTshZooJavtkaDMvHulAzj43MmgDgPydfswynY56K96/bqzJ+tqFeDG7SZJE4hhRA/OQ98yWtscue4jEmyM0j70sBRiy5fVXLnyEaIXZCyx8vRKEJKR5vFh7Yd5MSIt8oJSJdsyG9BkGCHzeUpR6FxzaLdPMCYSx3icNuIiWGPCFf3uTPT3rsmjuOJpJuN8IBQEyVw+mFv36CCXMkss59bAHKE3aNhmSfonW2g2SYyJ2zAuQ/gMUR0BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bblEvpBVoD14a8jtWBS2FnTxPcXC/Rz9Fz+d/NPUWJs=; b=LTPsxPpR2Wh6a90cPeFLRoDTVuxYoOuT/Wym1HcURMoF7Qcj8eMNogKFbZvRELbAyi2So+5vgRTxEnjQzvttUSaXm/ErPNDcS0y6BU1gERzl8Mp0Rx8rdgrY9TDHTjZLmy378o7XFrmjOZKKJr0BvemgtdHy4bEn8evQjUISFaUA7bvEw6kVF/10k2EUx8f/JsG/0+LIJqqr2qQcqOu3AkKUFVVTf5GpGAkXQWJ7c3Zoc2/MLpHuzo2B3YWil3OW3QDf0Ml2XxobevDgP0uuWcrvG6Ur1TRIdkQnarhO/wCtc+G2G+jqL1nldC0DpLQB4fc/SUj/3VK9waCzDxhNEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bblEvpBVoD14a8jtWBS2FnTxPcXC/Rz9Fz+d/NPUWJs=; b=orM39li9zOSpCCIiK+vrjYXWgWtdt7bMkxewQ9LCbykRS0zauZYq2boFhhOyusSrP2vmdlWDBbfnp1HR5iatBESiDPp10EEvd0GkY9O2vQpGn/xAOw7ipDahglc7nDiX96CTBVfcPtuwVWr8JHmPZpHM9hjmZNtJzqWjEYuOHhAtxdkEczYncZu8JQQ0/RHxxf4nRF+1Y1IBH2raAmfVQiTstLGYzeVjlbrZwq6pD1Ny9RkWnpSVnUtvxFUnXlMvIzx3M8dDLg1tXWq9WT1smOZGeTJdQsjxFftQWW2iSxJ4YUG4BZa/jSVrqG5n2HXS7mSXqp5zldC61qXobvd0dQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <36977cd0-37ae-d164-1a69-cf2161d08c4c@suse.com> Date: Mon, 10 Jul 2023 10:55:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: [PATCH v3 5/8] Arm: annotate entry points with type and size Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis References: In-Reply-To: X-ClientProxiedBy: FR0P281CA0068.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::13) To AS8PR04MB8788.eurprd04.prod.outlook.com (2603:10a6:20b:42f::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8788:EE_|DU2PR04MB9051:EE_ X-MS-Office365-Filtering-Correlation-Id: 5f072aff-1c96-4237-c120-08db81236561 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rZyX7Wq8xgWGvDtI4nZ4wSMVMZVKYXPBnV3M9vcQHjHzQms+5FYeX6KmK7IJExbWUkNjtfqgkJdxleZ3rRg5ipQCbg+kXN8/H2/zboN1n5g6dFLkK4kHcOxYZWqXCFugSWgpT9vKnQOX57Q2H+wf73h2sWGQKVTfRDK6tjYqevhgQgadWcx0mg86YPLlUoufiSWQHgJYKhS7qQN67ECDJcIR2ny+tJZsQig4PxVlCNbAqKVGQH2T0zTwCMmFFM8Q2tuwFU/Y2IdD0ueQYGwTwuRDXL3ujzP+jEgatk1WrIu2+zaJX9eqDLUQaRQLQbm4Umj7YJQ1vDuvZfE9xV6mV++8yHdF1WLHqi1k/eH1fHdBIemNIctqiFuaL0QDFzU/hjBQqP9BcbFAjfbE6XKsEAoofEAwMmWgfUkg4VkWJ8XeWSl48Ng0vEPSnS9vK7wZ9KnkStlX/qh4Y1SyqFW5XmMc+0/affrsSP4CKbQh+iaVQvaesH4hKQc45C2h9RH+jnDyjbEuZRCsq5jXGw+OZplwg8t3wOM3WhIy1hWhQdLN8bQ9W9oo4gayT8DG8as2JjypdcJ9t+2Im8RMHLmciAlmTkbnsDPaFN9VoaDfm6jlitlPL/6nG82ls8RB2aLkhrSwY7+1cMD3mEgezSGU5g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR04MB8788.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39850400004)(376002)(136003)(346002)(396003)(366004)(451199021)(186003)(26005)(6506007)(2616005)(6512007)(41300700001)(4326008)(6916009)(2906002)(66556008)(316002)(5660300002)(66476007)(8676002)(8936002)(478600001)(66946007)(6486002)(54906003)(36756003)(38100700002)(31696002)(86362001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?ID3pcck/pHduin+y+TtSoE8j8/2+?= =?utf-8?q?IyWmOF3zoZN1Cvm6fK6EyiMUUeUmlp/8QMkq3AdyZai8Ule5NFXIKticnU0Pce/od?= =?utf-8?q?nX4/Tp8eWZbLsDkcy92okZQP/tajIOCuADRREi+XXhvv8MeJ7t9FIQN46B/LyqzF/?= =?utf-8?q?xx1YJVwG4kbtSZFhKxGhMQOCbZp2FDhJQIFcniLWmCxy63RZ8xgH0TVZhPZg2Dpb7?= =?utf-8?q?v/uGZsqECFyhWGBLJFUQbSyDxnlWIx9DTYxp71KJ+E0HOV7pk07RJ276++vEzq7N5?= =?utf-8?q?2RgahS8OUsSkExnhBZUE7SfLZJQR97NB+y7p/s4vZSUJb0J3mxtLNVEGu1Cf/dye0?= =?utf-8?q?BXTIlImlltLtX+SMd+kAkTnyBzdY8XYX9+ZR3iRRLG9oFBe56nF+nUl9T/phk164z?= =?utf-8?q?I9qdenTgWKho+vI832Qf3P9xKb+D+FpX1cs09pfdnJJh2m5fKbZVG+ojgtB6DfvoC?= =?utf-8?q?hT8ANH7A1Sm2gBavA3s3BmtY8UL9FGhNEpEY8Z/QtqbcLCt1fb2B5RgnW82MNy+iR?= =?utf-8?q?y886LhO4tlRro9z59BkuqYdYmGOXJCqYD/hXZYe0fAeCuNMwEtETuX8/qiGjGZBKu?= =?utf-8?q?1qsvsGYjIw1vKPDr6Stk02G/4wBb57HOr47pDmRCXYwpmK54emfzBv09KzYDOkdxm?= =?utf-8?q?7IKPJgl8+4gi7TxFDqGwt1fJPLzS3z1nxY/mQZ0wnLB0BTBPngwfjhs6dlbPriO/U?= =?utf-8?q?HaEkVJoQvShkjSfTVi/+u4w8uikPlj/yI+nWlOXl1FOdUdG92hss2ofn8n3Cu5aSJ?= =?utf-8?q?Hxvcp6/pRAPgJLFc2CL0vt/MSmWMNmsT1svQj9Z8VXLqAB4crxOODZu5KOHNGYP3V?= =?utf-8?q?fDbLweWA2hHaP++l40m8DbkjGK8aFLrC1cJMW5+B8uID5BIdapgw7mlFwALcjEy3h?= =?utf-8?q?IKCLFxv+ZQ8HJP2K+zC3dOZ+4VpKgwNfPIYWTbLQstCoGl1iZs94+4XMw98QBpnaj?= =?utf-8?q?C2X/4duGgN8VIo16ru61lMtJjEJ4tVzR9Sd5bRJxUV2YnxRN52jr5TF43mveMn2nZ?= =?utf-8?q?reYgHhv0nGbUcdWUMAVIY7zhAVlfaCAfaz07zkfQlzP5nY1yEs/qh5pIvywQ+meF1?= =?utf-8?q?fA6XQk89TMr7D7iL+2JN3ycdmvsTPvIQhIdiostpyz9fiit+8rB095g9DEeGH3vKG?= =?utf-8?q?AMsX3LmAblFIit/Sr4LBdin8cW7A8sForjmJE8ywxJWhHCdndftlEqrj0HmGo3gkR?= =?utf-8?q?+Mko7+pKXXCeeNQ68QL/ytYg+zEAdw3R3Bkb+sCCaWCaQqbMJzFviIDY0bSdHkvro?= =?utf-8?q?77JQP+4vz/fls9wrPYQ+33vbt9Sn0RNkyqQsmp57UT3Fh9oJa2p+8G0Z2DDDpZF0C?= =?utf-8?q?2/6GXYCEeyfxe0ljEHdu2zR9BfBuIxePGJiVBHnJnFQBeTl+t/X7oBnWBBpBWuFnZ?= =?utf-8?q?S0Tbb3KqzEZNVICR1IsUYDP3Wd/Lpn1Ofj0YnLaCkovXX0Xc5bgIBBJExmURrk40n?= =?utf-8?q?G8vo8oWglwNFIEZCK01FsEjy3eTyPRFOrx5sUxhFcCLfzMujmmqTQtTYq8ns2HT1d?= =?utf-8?q?0Ar1R9vHFcW8?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f072aff-1c96-4237-c120-08db81236561 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8788.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2023 08:55:22.8893 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TFRaJRulX5d3K8HnzyvOQEQhlUM1UBvBVIg6jZ/zlvJYGgpbevJ7leIPBiHukmAFw8oum5gNf2F/JqOG+HTQmw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9051 Use the generic framework in xen/linkage.h. No change in generated code except for the changed padding value (noticable when config.gz isn't a multiple of 4 in size). Plus of course the converted symbols change to be hidden ones. Note that ASM_INT() is switched to DATA(), not DATA_LOCAL(), as the only use site wants the symbol global anyway. Signed-off-by: Jan Beulich --- Only one each of the assembly files is being converted for now. More could be done right here or as follow-on in separate patches. The ASM_INT() redundancy of .global will be eliminated by a subsequent patch. --- v3: New. --- a/xen/arch/arm/arm32/lib/div64.S +++ b/xen/arch/arm/arm32/lib/div64.S @@ -42,7 +42,7 @@ * Clobbered regs: xl, ip */ -ENTRY(__do_div64) +FUNC(__do_div64) UNWIND(.fnstart) @ Test for easy paths first. @@ -206,4 +206,4 @@ Ldiv0_64: ldr pc, [sp], #8 UNWIND(.fnend) -ENDPROC(__do_div64) +END(__do_div64) --- a/xen/arch/arm/arm64/lib/clear_page.S +++ b/xen/arch/arm/arm64/lib/clear_page.S @@ -22,7 +22,7 @@ * Parameters: * x0 - dest */ -ENTRY(clear_page) +FUNC(clear_page) mrs x1, dczid_el0 and w1, w1, #0xf mov x2, #4 @@ -33,4 +33,4 @@ ENTRY(clear_page) tst x0, #(PAGE_SIZE - 1) b.ne 1b ret -ENDPROC(clear_page) +END(clear_page) --- a/xen/arch/arm/include/asm/asm_defns.h +++ b/xen/arch/arm/include/asm/asm_defns.h @@ -5,6 +5,7 @@ /* NB. Auto-generated from arch/.../asm-offsets.c */ #include #endif +#include #include /* Macros for generic assembly code */ @@ -28,10 +29,7 @@ label: .asciz msg; .popsection #define ASM_INT(label, val) \ - .p2align 2; \ -label: .long (val); \ - .size label, . - label; \ - .type label, %object + DATA(label, 4) .long (val); END(label) #endif /* __ARM_ASM_DEFNS_H__ */ /* --- a/xen/arch/arm/include/asm/config.h +++ b/xen/arch/arm/include/asm/config.h @@ -53,7 +53,8 @@ /* Linkage for ARM */ #ifdef __ASSEMBLY__ -#define ALIGN .align 2 +#define CODE_ALIGN 4 +#define ALIGN .balign CODE_ALIGN #define ENTRY(name) \ .globl name; \ ALIGN; \ @@ -61,8 +62,6 @@ #define GLOBAL(name) \ .globl name; \ name: -#define END(name) \ - .size name, .-name #define ENDPROC(name) \ .type name, %function; \ END(name)