| Message ID | 3845d2a318bdaab242a7fd67473b05198db1b111.1710762555.git.nicola.vetrini@bugseng.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | address some violations of MISRA C Rule 20.7 | expand |
On Mon, 18 Mar 2024, Nicola Vetrini wrote: > MISRA C Rule 20.7 states: "Expressions resulting from the expansion > of macro parameters shall be enclosed in parentheses". Therefore, some > macro definitions should gain additional parentheses to ensure that all > current and future users will be safe with respect to expansions that > can possibly alter the semantics of the passed-in macro parameter. > > No functional change. > > Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index 6fe2fa8b2123..e6287305a7b5 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -250,7 +250,7 @@ dt_find_interrupt_controller(const struct dt_device_match *matches); for ( pp = (dn)->properties; (pp) != NULL; pp = (pp)->next ) #define dt_for_each_device_node(dt, dn) \ - for ( dn = dt; (dn) != NULL; dn = (dn)->allnext ) + for ( dn = (dt); (dn) != NULL; dn = (dn)->allnext ) #define dt_for_each_child_node(dt, dn) \ for ( dn = (dt)->child; (dn) != NULL; dn = (dn)->sibling )
MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". Therefore, some macro definitions should gain additional parentheses to ensure that all current and future users will be safe with respect to expansions that can possibly alter the semantics of the passed-in macro parameter. No functional change. Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com> --- This patch uniforms the way these macros use parentheses, skipping the already deviated cases of the lhs of an assignment. In principle, all three could have the parentheses on the macro argument in the lhs added. --- xen/include/xen/device_tree.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)