| Message ID | 3b28dca993cac9391b997c1744218cf4062907df.1697207038.git.federico.serafini@bugseng.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm: address some violations of MISRA C:2012 Rule 8.2 | expand |
On Fri, 13 Oct 2023, Federico Serafini wrote: > Add missing parameter names, no functional change. > > Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> > --- > xen/arch/arm/include/asm/cpufeature.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/xen/arch/arm/include/asm/cpufeature.h b/xen/arch/arm/include/asm/cpufeature.h > index 8011076b8c..41e97c23dd 100644 > --- a/xen/arch/arm/include/asm/cpufeature.h > +++ b/xen/arch/arm/include/asm/cpufeature.h > @@ -127,8 +127,8 @@ static inline void cpus_set_cap(unsigned int num) > struct arm_cpu_capabilities { > const char *desc; > u16 capability; > - bool (*matches)(const struct arm_cpu_capabilities *); > - int (*enable)(void *); /* Called on every active CPUs */ > + bool (*matches)(const struct arm_cpu_capabilities *caps); all the implementations of matches I found in xen/arch/arm/cpuerrata.c actually call the parameter "entry" > + int (*enable)(void *ptr); /* Called on every active CPUs */ this one instead is "data" > union { > struct { /* To be used for eratum handling only */ > u32 midr_model; > @@ -448,10 +448,10 @@ struct cpuinfo_arm { > > extern struct cpuinfo_arm system_cpuinfo; > > -extern void identify_cpu(struct cpuinfo_arm *); > +extern void identify_cpu(struct cpuinfo_arm *c); > > #ifdef CONFIG_ARM_64 > -extern void update_system_features(const struct cpuinfo_arm *); > +extern void update_system_features(const struct cpuinfo_arm *new); > #else > static inline void update_system_features(const struct cpuinfo_arm *cpuinfo) > { > -- > 2.34.1 >
On Fri, 13 Oct 2023, Stefano Stabellini wrote: > On Fri, 13 Oct 2023, Federico Serafini wrote: > > Add missing parameter names, no functional change. > > > > Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> > > --- > > xen/arch/arm/include/asm/cpufeature.h | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/xen/arch/arm/include/asm/cpufeature.h b/xen/arch/arm/include/asm/cpufeature.h > > index 8011076b8c..41e97c23dd 100644 > > --- a/xen/arch/arm/include/asm/cpufeature.h > > +++ b/xen/arch/arm/include/asm/cpufeature.h > > @@ -127,8 +127,8 @@ static inline void cpus_set_cap(unsigned int num) > > struct arm_cpu_capabilities { > > const char *desc; > > u16 capability; > > - bool (*matches)(const struct arm_cpu_capabilities *); > > - int (*enable)(void *); /* Called on every active CPUs */ > > + bool (*matches)(const struct arm_cpu_capabilities *caps); > > all the implementations of matches I found in xen/arch/arm/cpuerrata.c > actually call the parameter "entry" > > > > + int (*enable)(void *ptr); /* Called on every active CPUs */ > > this one instead is "data" I committed all the other patches in this series to the my for-4.19 branch
Hi, On 13/10/2023 16:24, Federico Serafini wrote: > Add missing parameter names, no functional change. > > Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> > --- > xen/arch/arm/include/asm/cpufeature.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/xen/arch/arm/include/asm/cpufeature.h b/xen/arch/arm/include/asm/cpufeature.h > index 8011076b8c..41e97c23dd 100644 > --- a/xen/arch/arm/include/asm/cpufeature.h > +++ b/xen/arch/arm/include/asm/cpufeature.h > @@ -127,8 +127,8 @@ static inline void cpus_set_cap(unsigned int num) > struct arm_cpu_capabilities { > const char *desc; > u16 capability; > - bool (*matches)(const struct arm_cpu_capabilities *); > - int (*enable)(void *); /* Called on every active CPUs */ > + bool (*matches)(const struct arm_cpu_capabilities *caps); > + int (*enable)(void *ptr); /* Called on every active CPUs */ How did you come up with the name? The void * seems to be named 'data' by the declaration and I think we should be consistent, otherwise this is defeating the spirit of MISRA (assuming this is not a violation). Cheers,
On 14/10/2023 00:34, Stefano Stabellini wrote: > On Fri, 13 Oct 2023, Stefano Stabellini wrote: >> On Fri, 13 Oct 2023, Federico Serafini wrote: >>> Add missing parameter names, no functional change. >>> >>> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> >>> --- >>> xen/arch/arm/include/asm/cpufeature.h | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/xen/arch/arm/include/asm/cpufeature.h b/xen/arch/arm/include/asm/cpufeature.h >>> index 8011076b8c..41e97c23dd 100644 >>> --- a/xen/arch/arm/include/asm/cpufeature.h >>> +++ b/xen/arch/arm/include/asm/cpufeature.h >>> @@ -127,8 +127,8 @@ static inline void cpus_set_cap(unsigned int num) >>> struct arm_cpu_capabilities { >>> const char *desc; >>> u16 capability; >>> - bool (*matches)(const struct arm_cpu_capabilities *); >>> - int (*enable)(void *); /* Called on every active CPUs */ >>> + bool (*matches)(const struct arm_cpu_capabilities *caps); >> >> all the implementations of matches I found in xen/arch/arm/cpuerrata.c >> actually call the parameter "entry" >> >> >>> + int (*enable)(void *ptr); /* Called on every active CPUs */ >> >> this one instead is "data" > > I committed all the other patches in this series to the my for-4.19 branch I have left some comments in patch #1. Given this is not the latest master, I think we should consider to remove/replace the patch rather than introducing a follow-up. Cheers,
On Mon, 16 Oct 2023, Julien Grall wrote: > On 14/10/2023 00:34, Stefano Stabellini wrote: > > On Fri, 13 Oct 2023, Stefano Stabellini wrote: > > > On Fri, 13 Oct 2023, Federico Serafini wrote: > > > > Add missing parameter names, no functional change. > > > > > > > > Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> > > > > --- > > > > xen/arch/arm/include/asm/cpufeature.h | 8 ++++---- > > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/xen/arch/arm/include/asm/cpufeature.h > > > > b/xen/arch/arm/include/asm/cpufeature.h > > > > index 8011076b8c..41e97c23dd 100644 > > > > --- a/xen/arch/arm/include/asm/cpufeature.h > > > > +++ b/xen/arch/arm/include/asm/cpufeature.h > > > > @@ -127,8 +127,8 @@ static inline void cpus_set_cap(unsigned int num) > > > > struct arm_cpu_capabilities { > > > > const char *desc; > > > > u16 capability; > > > > - bool (*matches)(const struct arm_cpu_capabilities *); > > > > - int (*enable)(void *); /* Called on every active CPUs */ > > > > + bool (*matches)(const struct arm_cpu_capabilities *caps); > > > > > > all the implementations of matches I found in xen/arch/arm/cpuerrata.c > > > actually call the parameter "entry" > > > > > > > > > > + int (*enable)(void *ptr); /* Called on every active CPUs */ > > > > > > this one instead is "data" > > > > I committed all the other patches in this series to the my for-4.19 branch > > I have left some comments in patch #1. Given this is not the latest master, I > think we should consider to remove/replace the patch rather than introducing a > follow-up. Makes sense. I took out patch #1 of this series and also took the opportunity to rebase 4.19 on the latest staging
diff --git a/xen/arch/arm/include/asm/cpufeature.h b/xen/arch/arm/include/asm/cpufeature.h index 8011076b8c..41e97c23dd 100644 --- a/xen/arch/arm/include/asm/cpufeature.h +++ b/xen/arch/arm/include/asm/cpufeature.h @@ -127,8 +127,8 @@ static inline void cpus_set_cap(unsigned int num) struct arm_cpu_capabilities { const char *desc; u16 capability; - bool (*matches)(const struct arm_cpu_capabilities *); - int (*enable)(void *); /* Called on every active CPUs */ + bool (*matches)(const struct arm_cpu_capabilities *caps); + int (*enable)(void *ptr); /* Called on every active CPUs */ union { struct { /* To be used for eratum handling only */ u32 midr_model; @@ -448,10 +448,10 @@ struct cpuinfo_arm { extern struct cpuinfo_arm system_cpuinfo; -extern void identify_cpu(struct cpuinfo_arm *); +extern void identify_cpu(struct cpuinfo_arm *c); #ifdef CONFIG_ARM_64 -extern void update_system_features(const struct cpuinfo_arm *); +extern void update_system_features(const struct cpuinfo_arm *new); #else static inline void update_system_features(const struct cpuinfo_arm *cpuinfo) {
Add missing parameter names, no functional change. Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> --- xen/arch/arm/include/asm/cpufeature.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)