From patchwork Mon Dec 11 10:30:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicola Vetrini X-Patchwork-Id: 13486987 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C82D9C10F07 for ; Mon, 11 Dec 2023 10:30:55 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.651596.1017332 (Exim 4.92) (envelope-from ) id 1rCdYc-0005eq-K4; Mon, 11 Dec 2023 10:30:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 651596.1017332; Mon, 11 Dec 2023 10:30:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rCdYc-0005ej-GQ; Mon, 11 Dec 2023 10:30:38 +0000 Received: by outflank-mailman (input) for mailman id 651596; Mon, 11 Dec 2023 10:30:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rCdYb-00059V-5z for xen-devel@lists.xenproject.org; Mon, 11 Dec 2023 10:30:37 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 52789d88-9810-11ee-98e8-6d05b1d4d9a1; Mon, 11 Dec 2023 11:30:36 +0100 (CET) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 216EA4EE0744; Mon, 11 Dec 2023 11:30:36 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52789d88-9810-11ee-98e8-6d05b1d4d9a1 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Nicola Vetrini , George Dunlap , Dario Faggioli Subject: [XEN PATCH 4/7] xen/sched: address MISRA C:2012 Rule 2.1 Date: Mon, 11 Dec 2023 11:30:25 +0100 Message-Id: <4006f1eb1977a89a57c5c02f003a2fefc06dfc42.1702283415.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 The break statement after the return statement is definitely unreachable and can be removed with no functional change. Signed-off-by: Nicola Vetrini Acked-by: George Dunlap Reviewed-by: Stefano Stabellini --- xen/common/sched/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index f6ac1e5af8bd..d177c675c81b 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -2239,7 +2239,6 @@ static bool sched_tasklet_check_cpu(unsigned int cpu) /* fallthrough */ case TASKLET_enqueued|TASKLET_scheduled: return true; - break; case TASKLET_scheduled: clear_bit(_TASKLET_scheduled, tasklet_work); /* fallthrough */