| Message ID | 424e0523b9ec68eda5cf5b41a7bb6c980df2a52d.1691676251.git.nicola.vetrini@bugseng.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | xen: fix missing headers and static storage duration | expand |
On Fri, 11 Aug 2023, Nicola Vetrini wrote: > The missing header included by this patch provides a declaration for > 'set_px_pminfo' that is visible prior to the definition in this file. > This also resolves a violation of MISRA C:2012 Rule 8.4. > > Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com> > Fixes: 452119c09420 ("x86 and ia64: move cpufreq notify code to commone place") Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > --- > xen/drivers/cpufreq/cpufreq.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/xen/drivers/cpufreq/cpufreq.c b/xen/drivers/cpufreq/cpufreq.c > index 2321c7dd07b1..4482bbe53a1e 100644 > --- a/xen/drivers/cpufreq/cpufreq.c > +++ b/xen/drivers/cpufreq/cpufreq.c > @@ -39,6 +39,7 @@ > #include <xen/guest_access.h> > #include <xen/domain.h> > #include <xen/cpu.h> > +#include <xen/pmstat.h> > #include <asm/io.h> > #include <asm/processor.h> > > -- > 2.34.1 >
On 12.08.2023 01:03, Stefano Stabellini wrote: > On Fri, 11 Aug 2023, Nicola Vetrini wrote: >> The missing header included by this patch provides a declaration for >> 'set_px_pminfo' that is visible prior to the definition in this file. >> This also resolves a violation of MISRA C:2012 Rule 8.4. >> >> Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com> >> Fixes: 452119c09420 ("x86 and ia64: move cpufreq notify code to commone place") > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> Acked-by: Jan Beulich <jbeulich@suse.com>
diff --git a/xen/drivers/cpufreq/cpufreq.c b/xen/drivers/cpufreq/cpufreq.c index 2321c7dd07b1..4482bbe53a1e 100644 --- a/xen/drivers/cpufreq/cpufreq.c +++ b/xen/drivers/cpufreq/cpufreq.c @@ -39,6 +39,7 @@ #include <xen/guest_access.h> #include <xen/domain.h> #include <xen/cpu.h> +#include <xen/pmstat.h> #include <asm/io.h> #include <asm/processor.h>
The missing header included by this patch provides a declaration for 'set_px_pminfo' that is visible prior to the definition in this file. This also resolves a violation of MISRA C:2012 Rule 8.4. Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com> Fixes: 452119c09420 ("x86 and ia64: move cpufreq notify code to commone place") --- xen/drivers/cpufreq/cpufreq.c | 1 + 1 file changed, 1 insertion(+)