| Message ID | 461a97a14a530286a8b8d0d30a1a8ed63690bc26.1701764980.git.federico.serafini@bugseng.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | xen: address violations of MISRA C:2012 Rule 8.2 | expand |
On Tue, 5 Dec 2023, Federico Serafini wrote: > Add missing parameter names. No functional change. > > Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> > --- > xen/arch/x86/include/asm/mm.h | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/xen/arch/x86/include/asm/mm.h b/xen/arch/x86/include/asm/mm.h > index 05dfe35502..a270f8ddd6 100644 > --- a/xen/arch/x86/include/asm/mm.h > +++ b/xen/arch/x86/include/asm/mm.h > @@ -406,7 +406,7 @@ void put_page_type(struct page_info *page); > int get_page_type(struct page_info *page, unsigned long type); > int put_page_type_preemptible(struct page_info *page); > int get_page_type_preemptible(struct page_info *page, unsigned long type); > -int put_old_guest_table(struct vcpu *); > +int put_old_guest_table(struct vcpu *v); > int get_page_from_l1e( > l1_pgentry_t l1e, struct domain *l1e_owner, struct domain *pg_owner); > void put_page_from_l1e(l1_pgentry_t l1e, struct domain *l1e_owner); > @@ -557,7 +557,7 @@ void audit_domains(void); > > void make_cr3(struct vcpu *v, mfn_t mfn); > pagetable_t update_cr3(struct vcpu *v); > -int vcpu_destroy_pagetables(struct vcpu *); > +int vcpu_destroy_pagetables(struct vcpu *v); > void *do_page_walk(struct vcpu *v, unsigned long addr); > > /* Allocator functions for Xen pagetables. */ > @@ -572,20 +572,20 @@ int __sync_local_execstate(void); > /* Arch-specific portion of memory_op hypercall. */ > long arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg); > long subarch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg); > -int compat_arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void)); > -int compat_subarch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void)); > +int compat_arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg); > +int compat_subarch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg); Also for compat_subarch_memory_op I cannot find the definition everything else looks fine
On 06.12.2023 04:10, Stefano Stabellini wrote: > On Tue, 5 Dec 2023, Federico Serafini wrote: >> @@ -572,20 +572,20 @@ int __sync_local_execstate(void); >> /* Arch-specific portion of memory_op hypercall. */ >> long arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg); >> long subarch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg); >> -int compat_arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void)); >> -int compat_subarch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void)); >> +int compat_arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg); >> +int compat_subarch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg); > > Also for compat_subarch_memory_op I cannot find the definition Looks like in b8a7efe8528a ("Enable compatibility mode operation for HYPERVISOR_memory_op") I blindly added the declaration, without there actually being a definition. Jan
diff --git a/xen/arch/x86/include/asm/mm.h b/xen/arch/x86/include/asm/mm.h index 05dfe35502..a270f8ddd6 100644 --- a/xen/arch/x86/include/asm/mm.h +++ b/xen/arch/x86/include/asm/mm.h @@ -406,7 +406,7 @@ void put_page_type(struct page_info *page); int get_page_type(struct page_info *page, unsigned long type); int put_page_type_preemptible(struct page_info *page); int get_page_type_preemptible(struct page_info *page, unsigned long type); -int put_old_guest_table(struct vcpu *); +int put_old_guest_table(struct vcpu *v); int get_page_from_l1e( l1_pgentry_t l1e, struct domain *l1e_owner, struct domain *pg_owner); void put_page_from_l1e(l1_pgentry_t l1e, struct domain *l1e_owner); @@ -557,7 +557,7 @@ void audit_domains(void); void make_cr3(struct vcpu *v, mfn_t mfn); pagetable_t update_cr3(struct vcpu *v); -int vcpu_destroy_pagetables(struct vcpu *); +int vcpu_destroy_pagetables(struct vcpu *v); void *do_page_walk(struct vcpu *v, unsigned long addr); /* Allocator functions for Xen pagetables. */ @@ -572,20 +572,20 @@ int __sync_local_execstate(void); /* Arch-specific portion of memory_op hypercall. */ long arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg); long subarch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg); -int compat_arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void)); -int compat_subarch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void)); +int compat_arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg); +int compat_subarch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg); #define NIL(type) ((type *)-sizeof(type)) #define IS_NIL(ptr) (!((uintptr_t)(ptr) + sizeof(*(ptr)))) -int create_perdomain_mapping(struct domain *, unsigned long va, - unsigned int nr, l1_pgentry_t **, - struct page_info **); -void destroy_perdomain_mapping(struct domain *, unsigned long va, +int create_perdomain_mapping(struct domain *d, unsigned long va, + unsigned int nr, l1_pgentry_t **pl1tab, + struct page_info **ppg); +void destroy_perdomain_mapping(struct domain *d, unsigned long va, unsigned int nr); -void free_perdomain_mappings(struct domain *); +void free_perdomain_mappings(struct domain *d); -void __iomem *ioremap_wc(paddr_t, size_t); +void __iomem *ioremap_wc(paddr_t pa, size_t len); extern int memory_add(unsigned long spfn, unsigned long epfn, unsigned int pxm);
Add missing parameter names. No functional change. Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> --- xen/arch/x86/include/asm/mm.h | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)