| Message ID | 4b6949fb8d84a255898ca4b285526f6513513371.1560888454.git.tsirakisn@ainfosec.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | argo: suppress select logging messages | expand |
On Tue, Jun 18, 2019 at 1:10 PM Nicholas Tsirakis <niko.tsirakis@gmail.com> wrote: > > Some logging messages made more sense as argo debug > logs rather than standard Xen logs. Use argo_dprintk > to only print this info if argo DEBUG is enabled. > > Signed-off-by: Nicholas Tsirakis <tsirakisn@ainfosec.com> Reviewed-by: Christopher Clark <christopher.w.clark@gmail.com> > --- > xen/common/argo.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/xen/common/argo.c b/xen/common/argo.c > index c8f4302963..59b655f4c8 100644 > --- a/xen/common/argo.c > +++ b/xen/common/argo.c > @@ -1456,7 +1456,7 @@ find_ring_mfns(struct domain *d, struct argo_ring_info *ring_info, > if ( ring_info->mfns ) > { > /* Ring already existed: drop the previous mapping. */ > - gprintk(XENLOG_INFO, "argo: vm%u re-register existing ring " > + argo_dprintk("argo: vm%u re-register existing ring " > "(vm%u:%x vm%u) clears mapping\n", > d->domain_id, ring_info->id.domain_id, > ring_info->id.aport, ring_info->id.partner_id); > @@ -1516,7 +1516,7 @@ find_ring_mfns(struct domain *d, struct argo_ring_info *ring_info, > { > ASSERT(ring_info->nmfns == NPAGES_RING(len)); > > - gprintk(XENLOG_DEBUG, "argo: vm%u ring (vm%u:%x vm%u) %p " > + argo_dprintk("argo: vm%u ring (vm%u:%x vm%u) %p " > "mfn_mapping %p len %u nmfns %u\n", > d->domain_id, ring_info->id.domain_id, > ring_info->id.aport, ring_info->id.partner_id, ring_info, > @@ -1730,7 +1730,7 @@ register_ring(struct domain *currd, > list_add(&ring_info->node, > &currd->argo->ring_hash[hash_index(&ring_info->id)]); > > - gprintk(XENLOG_DEBUG, "argo: vm%u registering ring (vm%u:%x vm%u)\n", > + argo_dprintk("argo: vm%u registering ring (vm%u:%x vm%u)\n", > currd->domain_id, ring_id.domain_id, ring_id.aport, > ring_id.partner_id); > } > @@ -1770,8 +1770,7 @@ register_ring(struct domain *currd, > goto out_unlock2; > } > > - gprintk(XENLOG_DEBUG, > - "argo: vm%u re-registering existing ring (vm%u:%x vm%u)\n", > + argo_dprintk("argo: vm%u re-registering existing ring (vm%u:%x vm%u)\n", > currd->domain_id, ring_id.domain_id, ring_id.aport, > ring_id.partner_id); > } > -- > 2.17.1 >
diff --git a/xen/common/argo.c b/xen/common/argo.c index c8f4302963..59b655f4c8 100644 --- a/xen/common/argo.c +++ b/xen/common/argo.c @@ -1456,7 +1456,7 @@ find_ring_mfns(struct domain *d, struct argo_ring_info *ring_info, if ( ring_info->mfns ) { /* Ring already existed: drop the previous mapping. */ - gprintk(XENLOG_INFO, "argo: vm%u re-register existing ring " + argo_dprintk("argo: vm%u re-register existing ring " "(vm%u:%x vm%u) clears mapping\n", d->domain_id, ring_info->id.domain_id, ring_info->id.aport, ring_info->id.partner_id); @@ -1516,7 +1516,7 @@ find_ring_mfns(struct domain *d, struct argo_ring_info *ring_info, { ASSERT(ring_info->nmfns == NPAGES_RING(len)); - gprintk(XENLOG_DEBUG, "argo: vm%u ring (vm%u:%x vm%u) %p " + argo_dprintk("argo: vm%u ring (vm%u:%x vm%u) %p " "mfn_mapping %p len %u nmfns %u\n", d->domain_id, ring_info->id.domain_id, ring_info->id.aport, ring_info->id.partner_id, ring_info, @@ -1730,7 +1730,7 @@ register_ring(struct domain *currd, list_add(&ring_info->node, &currd->argo->ring_hash[hash_index(&ring_info->id)]); - gprintk(XENLOG_DEBUG, "argo: vm%u registering ring (vm%u:%x vm%u)\n", + argo_dprintk("argo: vm%u registering ring (vm%u:%x vm%u)\n", currd->domain_id, ring_id.domain_id, ring_id.aport, ring_id.partner_id); } @@ -1770,8 +1770,7 @@ register_ring(struct domain *currd, goto out_unlock2; } - gprintk(XENLOG_DEBUG, - "argo: vm%u re-registering existing ring (vm%u:%x vm%u)\n", + argo_dprintk("argo: vm%u re-registering existing ring (vm%u:%x vm%u)\n", currd->domain_id, ring_id.domain_id, ring_id.aport, ring_id.partner_id); }
Some logging messages made more sense as argo debug logs rather than standard Xen logs. Use argo_dprintk to only print this info if argo DEBUG is enabled. Signed-off-by: Nicholas Tsirakis <tsirakisn@ainfosec.com> --- xen/common/argo.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)