| Message ID | 54ae54f9-1ba9-900b-a56f-f48e2c9a82b0@suse.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | fbde4ae7e15f71b57d194c5730189ac883622891 |
| Headers | show |
| Series | drm/xen: adjust Kconfig | expand |
Hello, Jan! On 2/23/21 6:41 PM, Jan Beulich wrote: > By having selected DRM_XEN, I was assuming I would build the frontend > driver. As it turns out this is a dummy option, and I have really not > been building this (because I had DRM disabled). Make it a promptless > one, moving the "depends on" to the other, real option, and "select"ing > the dummy one. > > Signed-off-by: Jan Beulich <jbeulich@suse.com> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> > --- a/drivers/gpu/drm/xen/Kconfig > +++ b/drivers/gpu/drm/xen/Kconfig > @@ -1,15 +1,11 @@ > # SPDX-License-Identifier: GPL-2.0-only > config DRM_XEN > - bool "DRM Support for Xen guest OS" > - depends on XEN > - help > - Choose this option if you want to enable DRM support > - for Xen. > + bool > > config DRM_XEN_FRONTEND > tristate "Para-virtualized frontend driver for Xen guest OS" > - depends on DRM_XEN > - depends on DRM > + depends on XEN && DRM > + select DRM_XEN > select DRM_KMS_HELPER > select VIDEOMODE_HELPERS > select XEN_XENBUS_FRONTEND
On Wed, Feb 24, 2021 at 8:55 AM Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com> wrote: > > Hello, Jan! > > On 2/23/21 6:41 PM, Jan Beulich wrote: > > By having selected DRM_XEN, I was assuming I would build the frontend > > driver. As it turns out this is a dummy option, and I have really not > > been building this (because I had DRM disabled). Make it a promptless > > one, moving the "depends on" to the other, real option, and "select"ing > > the dummy one. > > > > Signed-off-by: Jan Beulich <jbeulich@suse.com> > Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> Since you're maintainer/committer, I'm assuming you'll also merge this? Always confusing when there's an r-b but nothing about whether the patch will get merged or not. -Daniel > > --- a/drivers/gpu/drm/xen/Kconfig > > +++ b/drivers/gpu/drm/xen/Kconfig > > @@ -1,15 +1,11 @@ > > # SPDX-License-Identifier: GPL-2.0-only > > config DRM_XEN > > - bool "DRM Support for Xen guest OS" > > - depends on XEN > > - help > > - Choose this option if you want to enable DRM support > > - for Xen. > > + bool > > > > config DRM_XEN_FRONTEND > > tristate "Para-virtualized frontend driver for Xen guest OS" > > - depends on DRM_XEN > > - depends on DRM > > + depends on XEN && DRM > > + select DRM_XEN > > select DRM_KMS_HELPER > > select VIDEOMODE_HELPERS > > select XEN_XENBUS_FRONTEND > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On 2/24/21 6:17 PM, Daniel Vetter wrote: > On Wed, Feb 24, 2021 at 8:55 AM Oleksandr Andrushchenko > <Oleksandr_Andrushchenko@epam.com> wrote: >> Hello, Jan! >> >> On 2/23/21 6:41 PM, Jan Beulich wrote: >>> By having selected DRM_XEN, I was assuming I would build the frontend >>> driver. As it turns out this is a dummy option, and I have really not >>> been building this (because I had DRM disabled). Make it a promptless >>> one, moving the "depends on" to the other, real option, and "select"ing >>> the dummy one. >>> >>> Signed-off-by: Jan Beulich <jbeulich@suse.com> >> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> > Since you're maintainer/committer, I'm assuming you'll also merge > this? Always confusing when there's an r-b but nothing about whether > the patch will get merged or not. Applied to drm-misc-next, thank you > -Daniel > >>> --- a/drivers/gpu/drm/xen/Kconfig >>> +++ b/drivers/gpu/drm/xen/Kconfig >>> @@ -1,15 +1,11 @@ >>> # SPDX-License-Identifier: GPL-2.0-only >>> config DRM_XEN >>> - bool "DRM Support for Xen guest OS" >>> - depends on XEN >>> - help >>> - Choose this option if you want to enable DRM support >>> - for Xen. >>> + bool >>> >>> config DRM_XEN_FRONTEND >>> tristate "Para-virtualized frontend driver for Xen guest OS" >>> - depends on DRM_XEN >>> - depends on DRM >>> + depends on XEN && DRM >>> + select DRM_XEN >>> select DRM_KMS_HELPER >>> select VIDEOMODE_HELPERS >>> select XEN_XENBUS_FRONTEND >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://urldefense.com/v3/__https://lists.freedesktop.org/mailman/listinfo/dri-devel__;!!GF_29dbcQIUBPA!l8ITnylvjn3TuANLahtryeLJhjH20i-9Oi_1tYkdA59vXUpBHtKnlQ-Kg-zURW_ruUkKKaUAZQ$ [lists[.]freedesktop[.]org] > >
--- a/drivers/gpu/drm/xen/Kconfig +++ b/drivers/gpu/drm/xen/Kconfig @@ -1,15 +1,11 @@ # SPDX-License-Identifier: GPL-2.0-only config DRM_XEN - bool "DRM Support for Xen guest OS" - depends on XEN - help - Choose this option if you want to enable DRM support - for Xen. + bool config DRM_XEN_FRONTEND tristate "Para-virtualized frontend driver for Xen guest OS" - depends on DRM_XEN - depends on DRM + depends on XEN && DRM + select DRM_XEN select DRM_KMS_HELPER select VIDEOMODE_HELPERS select XEN_XENBUS_FRONTEND
By having selected DRM_XEN, I was assuming I would build the frontend driver. As it turns out this is a dummy option, and I have really not been building this (because I had DRM disabled). Make it a promptless one, moving the "depends on" to the other, real option, and "select"ing the dummy one. Signed-off-by: Jan Beulich <jbeulich@suse.com>