From patchwork Tue Feb 23 16:22:36 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Malcolm Crossley X-Patchwork-Id: 8394221 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 8F44CC0553 for ; Tue, 23 Feb 2016 16:24:55 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BBE59202F0 for ; Tue, 23 Feb 2016 16:24:54 +0000 (UTC) Received: from lists.xen.org (lists.xenproject.org [50.57.142.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD262202EB for ; Tue, 23 Feb 2016 16:24:53 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aYFjX-0001fY-5b; Tue, 23 Feb 2016 16:22:43 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aYFjW-0001fT-1p for xen-devel@lists.xenproject.org; Tue, 23 Feb 2016 16:22:42 +0000 Received: from [85.158.139.211] by server-15.bemta-5.messagelabs.com id 34/D3-02989-1578CC65; Tue, 23 Feb 2016 16:22:41 +0000 X-Env-Sender: prvs=854a193dc=malcolm.crossley@citrix.com X-Msg-Ref: server-2.tower-206.messagelabs.com!1456244559!8343949!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 20144 invoked from network); 23 Feb 2016 16:22:40 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-2.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 23 Feb 2016 16:22:40 -0000 X-IronPort-AV: E=Sophos;i="5.22,490,1449532800"; d="scan'208";a="333701901" To: Jan Beulich References: <557B0C35.4080907@citrix.com> <558D280B.3050806@citrix.com> <56BB0C5A.7030306@citrix.com> <56CC944602000078000D54D2@prv-mh.provo.novell.com> From: Malcolm Crossley Message-ID: <56CC874C.9050009@citrix.com> Date: Tue, 23 Feb 2016 16:22:36 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56CC944602000078000D54D2@prv-mh.provo.novell.com> X-DLP: MIA2 Cc: Kevin Tian , Ian Campbell , Yu C Zhang , AndrewCooper , Paul Durrant , David Vrabel , xen-devel , Zhiyuan Lv Subject: Re: [Xen-devel] Xen PV IOMMU interface draft D X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 23/02/16 16:17, Jan Beulich wrote: >>>> On 10.02.16 at 11:09, wrote: >> % Xen PV IOMMU interface >> % Malcolm Crossley <> >> Paul Durrant <> >> % Draft D >> >> Introduction >> ============ >> >> Revision History >> ---------------- >> >> -------------------------------------------------------------------- >> Version Date Changes >> ------- ----------- ---------------------------------------------- >> Draft A 10 Apr 2014 Initial draft. >> >> Draft B 12 Jun 2015 Second draft. >> >> Draft C 26 Jun 2015 Third draft. >> >> Draft D 09 Feb 2016 Fourth draft. > > Unless this is a complete re-write, I'd really like to avoid needing to > read through all of it again. Do you perhaps have a PDF version > somewhere with change marks? > It was really a minor update to ensure the design matched the RFC implementation. The diff for the draft D is below. For the next revision I will details what has changed. Sorry about the hassle. I posted the RFC because I was would like to get some comments on the M2B implementation and the iommu_lookup_page code. Malcolm > Jan > diff -r a35c08555541 -r e829e3d0fcec designs/pv-iommu-control/design.txt --- a/designs/pv-iommu-control/design.txt +++ b/designs/pv-iommu-control/design.txt @@ -1,7 +1,7 @@ % Xen PV IOMMU interface % Malcolm Crossley <> Paul Durrant <> -% Draft C +% Draft D Introduction ============ @@ -17,6 +17,8 @@ Draft A 10 Apr 2014 Initial draft. Draft B 12 Jun 2015 Second draft. Draft C 26 Jun 2015 Third draft. + +Draft D 09 Feb 2016 Fourth draft. -------------------------------------------------------------------- Background @@ -481,7 +483,9 @@ IOMMU_OP_readable 0 Cr IOMMU_OP_writeable 1 Create writeable IOMMU mapping IOMMU_MAP_OP_no_ref_cnt 2 IOMMU mapping does not take a reference to MFN backing BFN mapping -Reserved for future use 3-9 n/a +IOMMU_MAP_OP_add_m2b 3 Wildcard M2B mapping added for + lookup_foreign_page to use +Reserved for future use 4-9 n/a IOMMU_page_order 10-15 Page order to be used for both gfn and bfn Defined values for map_page subop status field: @@ -519,7 +523,9 @@ Defined bits for flags field: Name Bit Definition ---- ----- ---------------------------------- -Reserved for future use 0-9 n/a +IOMMU_UNMAP_OP_remove_m2b 0 Wildcard M2B mapping removed for + lookup_foreign_page use +Reserved for future use 1-9 n/a IOMMU_page_order 10-15 Page order to be used for bfn