From patchwork Thu Apr 21 14:19:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 8901141 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id C6840BF29F for ; Thu, 21 Apr 2016 14:21:32 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id F2211202E5 for ; Thu, 21 Apr 2016 14:21:31 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA87C201B9 for ; Thu, 21 Apr 2016 14:21:30 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1atFRq-0006od-RH; Thu, 21 Apr 2016 14:19:14 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1atFRp-0006oX-EF for xen-devel@lists.xenproject.org; Thu, 21 Apr 2016 14:19:13 +0000 Received: from [193.109.254.147] by server-2.bemta-14.messagelabs.com id 80/60-03279-061E8175; Thu, 21 Apr 2016 14:19:12 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrEIsWRWlGSWpSXmKPExsXS6fjDSzf+oUS 4Qe9cc4vvWyYzOTB6HP5whSWAMYo1My8pvyKBNePh71mMBd/ZK24c62ZuYOxh62Lk5BASyJM4 dmcDO4jNK2AncefTVbC4hIChxL75q8BsFgFViemfzoPZbALqEm3PtrOC2CICKhJf7v1h6mLk4 mAWWMEoMffiC2aQhLCAn8Siu1vYQBJCAi2MEot+7gfr4BQIlJh64RBLFyMH0DZBib87hEHCzA JaEg9/3WKBsLUlli18zQxSwiwgLbH8H8cERr5ZCA2zkDTMQtIwC6FhASPLKkb14tSistQiXQu 9pKLM9IyS3MTMHF1DQxO93NTi4sT01JzEpGK95PzcTYzA8GMAgh2MGyc5H2KU5GBSEuWN3CMR LsSXlJ9SmZFYnBFfVJqTWnyIUYODQ2DbrtUXGKVY8vLzUpUkeJkeANUJFqWmp1akZeYAIwSmV IKDR0mENxskzVtckJhbnJkOkTrFqCglzvvrPlBCACSRUZoH1waLykuMslLCvIxARwnxFKQW5W aWoMq/YhTnYFQS5o0EGc+TmVcCN/0V0GImoMX8d0VBFpckIqSkGhibZ8zkcLQXN45uU/LbMGk Xx4zNTjsTe54dv75fU979ee7HmVten1r84n2hSaiqDuull7vSpVoXWK6YncFYaN0wMfWBm8EP bf3zLx1+pqw/t1en68rDJ9wPl06e+OgNoxbnt+OVzCs1NQIPOZ9U23F189uyX99/f9/vGOeY8 eSHyQdluTkmxszcSizFGYmGWsxFxYkAPG9mk8UCAAA= X-Env-Sender: JBeulich@suse.com X-Msg-Ref: server-16.tower-27.messagelabs.com!1461248349!36947072!1 X-Originating-IP: [137.65.248.74] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.28; banners=-,-,- X-VirusChecked: Checked Received: (qmail 45905 invoked from network); 21 Apr 2016 14:19:11 -0000 Received: from prv-mh.provo.novell.com (HELO prv-mh.provo.novell.com) (137.65.248.74) by server-16.tower-27.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 21 Apr 2016 14:19:11 -0000 Received: from INET-PRV-MTA by prv-mh.provo.novell.com with Novell_GroupWise; Thu, 21 Apr 2016 08:19:08 -0600 Message-Id: <5718FD7802000078000E4613@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.0 Date: Thu, 21 Apr 2016 08:19:04 -0600 From: "Jan Beulich" To: "jzh Chang" References: <56FA779702000078000E0D0B@prv-mh.provo.novell.com> In-Reply-To: Mime-Version: 1.0 Content-Disposition: inline Cc: Andrew Cooper , Paul Durrant , Keir Fraser , xen-devel Subject: Re: [Xen-devel] [PATCH v2] x86/HVM: fix forwarding of internally cached requests X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP >>> On 30.03.16 at 09:28, wrote: > 2016-03-29 18:39 GMT+08:00 Jan Beulich : >> --- >> I assume this also addresses the issue which >> http://lists.xenproject.org/archives/html/xen-devel/2016-01/msg03189.html >> attempted to deal with in a not really acceptable way. > > I hope this issue is resolved, but it still exists. Mind giving the small below patch a try? Jan --- unstable.orig/xen/arch/x86/msi.c +++ unstable/xen/arch/x86/msi.c @@ -430,8 +430,13 @@ static bool_t msi_set_mask_bit(struct ir { writel(flag, entry->mask_base + PCI_MSIX_ENTRY_VECTOR_CTRL_OFFSET); readl(entry->mask_base + PCI_MSIX_ENTRY_VECTOR_CTRL_OFFSET); + if ( likely(control & PCI_MSIX_FLAGS_ENABLE) ) break; + + entry->msi_attrib.host_masked = host; + entry->msi_attrib.guest_masked = guest; + flag = 1; } else if ( flag && !(control & PCI_MSIX_FLAGS_MASKALL) )