| Message ID | 574C299902000078000EF996@prv-mh.provo.novell.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, May 30, 2016 at 03:52:57AM -0600, Jan Beulich wrote: > Commit 7fb252bd41 ("build/xen: fix assembler instruction tests") added > $(AFLAGS) here, which results in all of those tests now failing. > Certain items need to be removed for things to work again. > > Signed-off-by: Jan Beulich <jbeulich@suse.com> Acked-by: Roger Pau Monné <roger.pau@citrix.com>
On Mon, May 30, 2016 at 03:52:57AM -0600, Jan Beulich wrote: > Commit 7fb252bd41 ("build/xen: fix assembler instruction tests") added > $(AFLAGS) here, which results in all of those tests now failing. > Certain items need to be removed for things to work again. > > Signed-off-by: Jan Beulich <jbeulich@suse.com> > Release-acked-by: Wei Liu <wei.liu2@citrix.com>
>>> On 31.05.16 at 14:25, <wei.liu2@citrix.com> wrote: > On Mon, May 30, 2016 at 03:52:57AM -0600, Jan Beulich wrote: >> Commit 7fb252bd41 ("build/xen: fix assembler instruction tests") added >> $(AFLAGS) here, which results in all of those tests now failing. >> Certain items need to be removed for things to work again. >> >> Signed-off-by: Jan Beulich <jbeulich@suse.com> >> > > Release-acked-by: Wei Liu <wei.liu2@citrix.com> Thanks, but - does this also imply an ordinary (REST maintainer) ack by you? Jan
On Tue, May 31, 2016 at 06:48:48AM -0600, Jan Beulich wrote: > >>> On 31.05.16 at 14:25, <wei.liu2@citrix.com> wrote: > > On Mon, May 30, 2016 at 03:52:57AM -0600, Jan Beulich wrote: > >> Commit 7fb252bd41 ("build/xen: fix assembler instruction tests") added > >> $(AFLAGS) here, which results in all of those tests now failing. > >> Certain items need to be removed for things to work again. > >> > >> Signed-off-by: Jan Beulich <jbeulich@suse.com> > >> > > > > Release-acked-by: Wei Liu <wei.liu2@citrix.com> > > Thanks, but - does this also imply an ordinary (REST maintainer) ack > by you? > Oops, I should have been explicit. Sorry. Acked-by: Wei Liu <wei.liu2@citrix.com> > Jan >
--- a/Config.mk +++ b/Config.mk @@ -150,7 +150,8 @@ endif # as-insn: Check whether assembler supports an instruction. # Usage: cflags-y += $(call as-insn "insn",option-yes,option-no) as-insn = $(if $(shell echo 'void _(void) { asm volatile ( $(2) ); }' \ - | $(1) $(AFLAGS) -c -x c -o /dev/null - 2>&1),$(4),$(3)) + | $(1) $(filter-out -M% %.d -include %/include/xen/config.h,$(AFLAGS)) \ + -c -x c -o /dev/null - 2>&1),$(4),$(3)) # as-insn-check: Add an option to compilation flags, but only if insn is # supported by assembler.
Commit 7fb252bd41 ("build/xen: fix assembler instruction tests") added $(AFLAGS) here, which results in all of those tests now failing. Certain items need to be removed for things to work again. Signed-off-by: Jan Beulich <jbeulich@suse.com> build: fix assembler instruction tests again Commit 7fb252bd41 ("build/xen: fix assembler instruction tests") added $(AFLAGS) here, which results in all of those tests now failing. Certain items need to be removed for things to work again. Signed-off-by: Jan Beulich <jbeulich@suse.com> --- a/Config.mk +++ b/Config.mk @@ -150,7 +150,8 @@ endif # as-insn: Check whether assembler supports an instruction. # Usage: cflags-y += $(call as-insn "insn",option-yes,option-no) as-insn = $(if $(shell echo 'void _(void) { asm volatile ( $(2) ); }' \ - | $(1) $(AFLAGS) -c -x c -o /dev/null - 2>&1),$(4),$(3)) + | $(1) $(filter-out -M% %.d -include %/include/xen/config.h,$(AFLAGS)) \ + -c -x c -o /dev/null - 2>&1),$(4),$(3)) # as-insn-check: Add an option to compilation flags, but only if insn is # supported by assembler.