diff mbox

tools: fix libxengnttab dependencies

Message ID 5758070102000078000F2F25@prv-mh.provo.novell.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jan Beulich June 8, 2016, 9:52 a.m. UTC
Without this some ld versions warn about not being able to find
libxentoollog.so.1 when linking libxenvchan.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
tools: fix libxengnttab dependencies

Without this some ld versions warn about not being able to find
libxentoollog.so.1 when linking libxenvchan.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/tools/Rules.mk
+++ b/tools/Rules.mk
@@ -92,8 +92,9 @@ LDLIBS_libxenevtchn = $(XEN_LIBXENEVTCHN
 SHLIB_libxenevtchn  = -Wl,-rpath-link=$(XEN_LIBXENEVTCHN)
 
 CFLAGS_libxengnttab = -I$(XEN_LIBXENGNTTAB)/include $(CFLAGS_xeninclude)
-LDLIBS_libxengnttab = $(XEN_LIBXENGNTTAB)/libxengnttab$(libextension)
-SHLIB_libxengnttab  = -Wl,-rpath-link=$(XEN_LIBXENGNTTAB)
+SHDEPS_libxengnttab = $(SHLIB_libxentoollog)
+LDLIBS_libxengnttab = $(SHDEPS_libxengnttab) $(XEN_LIBXENGNTTAB)/libxengnttab$(libextension)
+SHLIB_libxengnttab  = $(SHDEPS_libxengnttab) -Wl,-rpath-link=$(XEN_LIBXENGNTTAB)
 
 # xengntshr_* interfaces are actually part of libxengnttab.so
 CFLAGS_libxengntshr = -I$(XEN_LIBXENGNTTAB)/include $(CFLAGS_xeninclude)

Comments

Ian Jackson June 9, 2016, 11 a.m. UTC | #1
Jan Beulich writes ("[PATCH] tools: fix libxengnttab dependencies"):
> Without this some ld versions warn about not being able to find
> libxentoollog.so.1 when linking libxenvchan.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

I think this is a 4.7 candidate.  Wei ?

Ian.
Wei Liu June 9, 2016, 11:07 a.m. UTC | #2
On Thu, Jun 09, 2016 at 12:00:13PM +0100, Ian Jackson wrote:
> Jan Beulich writes ("[PATCH] tools: fix libxengnttab dependencies"):
> > Without this some ld versions warn about not being able to find
> > libxentoollog.so.1 when linking libxenvchan.
> > 
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> 
> I think this is a 4.7 candidate.  Wei ?
> 

Yes. Queued for both unstable and 4.7.

Wei.

> Ian.
diff mbox

Patch

--- a/tools/Rules.mk
+++ b/tools/Rules.mk
@@ -92,8 +92,9 @@  LDLIBS_libxenevtchn = $(XEN_LIBXENEVTCHN
 SHLIB_libxenevtchn  = -Wl,-rpath-link=$(XEN_LIBXENEVTCHN)
 
 CFLAGS_libxengnttab = -I$(XEN_LIBXENGNTTAB)/include $(CFLAGS_xeninclude)
-LDLIBS_libxengnttab = $(XEN_LIBXENGNTTAB)/libxengnttab$(libextension)
-SHLIB_libxengnttab  = -Wl,-rpath-link=$(XEN_LIBXENGNTTAB)
+SHDEPS_libxengnttab = $(SHLIB_libxentoollog)
+LDLIBS_libxengnttab = $(SHDEPS_libxengnttab) $(XEN_LIBXENGNTTAB)/libxengnttab$(libextension)
+SHLIB_libxengnttab  = $(SHDEPS_libxengnttab) -Wl,-rpath-link=$(XEN_LIBXENGNTTAB)
 
 # xengntshr_* interfaces are actually part of libxengnttab.so
 CFLAGS_libxengntshr = -I$(XEN_LIBXENGNTTAB)/include $(CFLAGS_xeninclude)