From patchwork Mon Apr 29 11:23:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 10921685 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0D3B114D5 for ; Mon, 29 Apr 2019 11:25:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EF576285CC for ; Mon, 29 Apr 2019 11:25:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E34392871E; Mon, 29 Apr 2019 11:25:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 792BB285CC for ; Mon, 29 Apr 2019 11:25:33 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hL4O7-0007rz-OK; Mon, 29 Apr 2019 11:23:59 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hL4O6-0007rk-Jm for xen-devel@lists.xenproject.org; Mon, 29 Apr 2019 11:23:58 +0000 X-Inumbo-ID: 46048172-6a71-11e9-a0ff-5f3e81f5e566 Received: from prv1-mh.provo.novell.com (unknown [137.65.248.33]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 46048172-6a71-11e9-a0ff-5f3e81f5e566; Mon, 29 Apr 2019 11:23:55 +0000 (UTC) Received: from INET-PRV1-MTA by prv1-mh.provo.novell.com with Novell_GroupWise; Mon, 29 Apr 2019 05:23:54 -0600 Message-Id: <5CC6DEC50200007800229EA0@prv1-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 18.1.0 Date: Mon, 29 Apr 2019 05:23:49 -0600 From: "Jan Beulich" To: "xen-devel" References: <5CC6DD090200007800229E80@prv1-mh.provo.novell.com> In-Reply-To: <5CC6DD090200007800229E80@prv1-mh.provo.novell.com> Mime-Version: 1.0 Content-Disposition: inline Subject: [Xen-devel] [PATCH 3/9] x86/IRQ: improve dump_irqs() X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Wei Liu , Roger Pau Monne Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Don't log a stray trailing comma. Shorten a few fields. Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné --- a/xen/arch/x86/irq.c +++ b/xen/arch/x86/irq.c @@ -2318,7 +2318,7 @@ static void dump_irqs(unsigned char key) spin_lock_irqsave(&desc->lock, flags); - printk(" IRQ:%4d affinity:%*pb vec:%02x type=%-15s status=%08x ", + printk(" IRQ:%4d aff:%*pb vec:%02x %-15s status=%03x ", irq, nr_cpu_ids, cpumask_bits(desc->affinity), desc->arch.vector, desc->handler->typename, desc->status); @@ -2329,23 +2329,21 @@ static void dump_irqs(unsigned char key) { action = (irq_guest_action_t *)desc->action; - printk("in-flight=%d domain-list=", action->in_flight); + printk("in-flight=%d%c", + action->in_flight, action->nr_guests ? ' ' : '\n'); - for ( i = 0; i < action->nr_guests; i++ ) + for ( i = 0; i < action->nr_guests; ) { - d = action->guest[i]; + d = action->guest[i++]; pirq = domain_irq_to_pirq(d, irq); info = pirq_info(d, pirq); - printk("%u:%3d(%c%c%c)", + printk("d%d:%3d(%c%c%c)%c", d->domain_id, pirq, evtchn_port_is_pending(d, info->evtchn) ? 'P' : '-', evtchn_port_is_masked(d, info->evtchn) ? 'M' : '-', - (info->masked ? 'M' : '-')); - if ( i != action->nr_guests ) - printk(","); + info->masked ? 'M' : '-', + i < action->nr_guests ? ',' : '\n'); } - - printk("\n"); } else if ( desc->action ) printk("%ps()\n", desc->action->handler);