| Message ID | 5a304ffd4fbdd0d5809dc68b857410bbc02f32a0.1696252375.git.federico.serafini@bugseng.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [XEN] x86/paging: address a violation of MISRA C:2012 Rule 8.3 | expand |
On Mon, 2 Oct 2023, Federico Serafini wrote: > Make function declaration and definition consistent. > No functional change. > > Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Hi, > On Oct 3, 2023, at 06:46, Stefano Stabellini <sstabellini@kernel.org> wrote: > > On Mon, 2 Oct 2023, Federico Serafini wrote: >> Make function declaration and definition consistent. >> No functional change. >> >> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> Release-acked-by: Henry Wang <Henry.Wang@arm.com> Kind regards, Henry
On 03.10.2023 00:46, Stefano Stabellini wrote: > On Mon, 2 Oct 2023, Federico Serafini wrote: >> Make function declaration and definition consistent. >> No functional change. >> >> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> Acked-by: Jan Beulich <jbeulich@suse.com>
On 03.10.2023 02:19, Henry Wang wrote: >> On Oct 3, 2023, at 06:46, Stefano Stabellini <sstabellini@kernel.org> wrote: >> >> On Mon, 2 Oct 2023, Federico Serafini wrote: >>> Make function declaration and definition consistent. >>> No functional change. >>> >>> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> >> >> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > > Release-acked-by: Henry Wang <Henry.Wang@arm.com> We're past RC3, so I'd like to confirm whether this still holds. Jan
Hi Jan, > On Oct 16, 2023, at 23:12, Jan Beulich <jbeulich@suse.com> wrote: > > On 03.10.2023 02:19, Henry Wang wrote: >>> On Oct 3, 2023, at 06:46, Stefano Stabellini <sstabellini@kernel.org> wrote: >>> >>> On Mon, 2 Oct 2023, Federico Serafini wrote: >>>> Make function declaration and definition consistent. >>>> No functional change. >>>> >>>> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> >>> >>> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> >> >> Release-acked-by: Henry Wang <Henry.Wang@arm.com> > > We're past RC3, so I'd like to confirm whether this still holds. Thanks for reaching out. Although we reached an agreement that we need a case by case analysis for if merging MISRA patches or not to 4.18, and technically MISRA patches should be committed by RC2, to be honest for such a simple patch I am not going to block it because I really don’t think it will cause a behavioral change, so yes my release-ack tag still holds. Feel free to commit it. Kind regards, Henry > > Jan
diff --git a/xen/arch/x86/include/asm/paging.h b/xen/arch/x86/include/asm/paging.h index f291f2f9a2..62605d7697 100644 --- a/xen/arch/x86/include/asm/paging.h +++ b/xen/arch/x86/include/asm/paging.h @@ -245,7 +245,7 @@ paging_fault(unsigned long va, struct cpu_user_regs *regs) } /* Handle invlpg requests on vcpus. */ -void paging_invlpg(struct vcpu *v, unsigned long va); +void paging_invlpg(struct vcpu *v, unsigned long linear); /* * Translate a guest virtual address to the frame number that the
Make function declaration and definition consistent. No functional change. Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> --- xen/arch/x86/include/asm/paging.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)