| Message ID | 5de82c39ffae1d65c8ab7142b05d304f9d4ddae9.1632860589.git.bobby.eshleman@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Remove unconditional arch dependency on asm/debugger.h | expand |
On 28/09/2021 21:30, Bobby Eshleman wrote: > domain_pause_for_debugger() was previously in debugger.h. This commit > moves it to domain.h because its implementation is in domain.c. > > Signed-off-by: Bobby Eshleman <bobby.eshleman@gmail.com> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
diff --git a/xen/arch/x86/nmi.c b/xen/arch/x86/nmi.c index ab94a96c4d..11d5f5a917 100644 --- a/xen/arch/x86/nmi.c +++ b/xen/arch/x86/nmi.c @@ -30,7 +30,6 @@ #include <asm/msr.h> #include <asm/mpspec.h> #include <asm/nmi.h> -#include <asm/debugger.h> #include <asm/div64.h> #include <asm/apic.h> diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index 772e2a5bfc..742fa9e2ca 100644 --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -62,7 +62,6 @@ #include <asm/uaccess.h> #include <asm/i387.h> #include <asm/xstate.h> -#include <asm/debugger.h> #include <asm/msr.h> #include <asm/nmi.h> #include <asm/xenoprof.h> diff --git a/xen/include/asm-x86/debugger.h b/xen/include/asm-x86/debugger.h index ed4d5c829b..8f6222956e 100644 --- a/xen/include/asm-x86/debugger.h +++ b/xen/include/asm-x86/debugger.h @@ -26,8 +26,6 @@ #include <asm/regs.h> #include <asm/processor.h> -void domain_pause_for_debugger(void); - #ifdef CONFIG_CRASH_DEBUG #include <xen/gdbstub.h> diff --git a/xen/include/asm-x86/domain.h b/xen/include/asm-x86/domain.h index 92d54de0b9..de854b5bfa 100644 --- a/xen/include/asm-x86/domain.h +++ b/xen/include/asm-x86/domain.h @@ -672,6 +672,8 @@ void update_guest_memory_policy(struct vcpu *v, void domain_cpu_policy_changed(struct domain *d); +void domain_pause_for_debugger(void); + bool update_runstate_area(struct vcpu *); bool update_secondary_system_time(struct vcpu *, struct vcpu_time_info *);
domain_pause_for_debugger() was previously in debugger.h. This commit moves it to domain.h because its implementation is in domain.c. Signed-off-by: Bobby Eshleman <bobby.eshleman@gmail.com> --- Changes in v3: - domain_pause_for_debugger() is now moved into debugger.h, not a new file debugger.c Changes in v4: - Don't unnecessarily include <asm/domain.h> xen/arch/x86/nmi.c | 1 - xen/arch/x86/traps.c | 1 - xen/include/asm-x86/debugger.h | 2 -- xen/include/asm-x86/domain.h | 2 ++ 4 files changed, 2 insertions(+), 4 deletions(-)