From patchwork Mon Mar 18 11:53:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicola Vetrini X-Patchwork-Id: 13595317 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 928CCC54E78 for ; Mon, 18 Mar 2024 11:54:20 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.694613.1083528 (Exim 4.92) (envelope-from ) id 1rmBZ8-00023l-4n; Mon, 18 Mar 2024 11:54:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 694613.1083528; Mon, 18 Mar 2024 11:54:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rmBZ7-00023G-R3; Mon, 18 Mar 2024 11:54:05 +0000 Received: by outflank-mailman (input) for mailman id 694613; Mon, 18 Mar 2024 11:54:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rmBZ6-0001F2-QP for xen-devel@lists.xenproject.org; Mon, 18 Mar 2024 11:54:04 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 368b82dd-e51e-11ee-a1ee-f123f15fe8a2; Mon, 18 Mar 2024 12:54:02 +0100 (CET) Received: from nico.bugseng.com (unknown [46.228.253.194]) by support.bugseng.com (Postfix) with ESMTPSA id 7C43A4EE0747; Mon, 18 Mar 2024 12:54:01 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 368b82dd-e51e-11ee-a1ee-f123f15fe8a2 From: Nicola Vetrini To: nicola.vetrini@bugseng.com, xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Jan Beulich Subject: [XEN PATCH 05/10] EFI: address violations of MISRA C Rule 20.7 Date: Mon, 18 Mar 2024 12:53:48 +0100 Message-Id: <66095ff2496d9b2be701877a3df762293fc8708b.1710762555.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". Therefore, some macro definitions should gain additional parentheses to ensure that all current and future users will be safe with respect to expansions that can possibly alter the semantics of the passed-in macro parameter. No functional change. Signed-off-by: Nicola Vetrini Acked-by: Jan Beulich --- This file is matched by exclude-list.json, but the fix is rather trivial and actually benefits code that is in scope for compliance. --- xen/include/efi/efierr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/efi/efierr.h b/xen/include/efi/efierr.h index dfd3d3cf4867..2ecde0b31302 100644 --- a/xen/include/efi/efierr.h +++ b/xen/include/efi/efierr.h @@ -22,7 +22,7 @@ Revision History #define EFIWARN(a) (a) -#define EFI_ERROR(a) (((INTN) a) < 0) +#define EFI_ERROR(a) (((INTN)(a)) < 0) #define EFI_SUCCESS 0