Message ID | 67163dc4bc2e44d3f70f9c49295b993663d2fd5a.1691575243.git.nicola.vetrini@bugseng.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | xen: address MISRA C:2012 Rule 8.4 | expand |
> On 9 Aug 2023, at 12:02, Nicola Vetrini <nicola.vetrini@bugseng.com> wrote: > > Add a declaration for the variable 'init_ttbr' to resolve > the violation of Rule 8.4 present in the associated source file 'mm.c'. > > No functional changes. > > Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com> > --- Reviewed-by: Luca Fancellu <luca.fancellu@arm.com> With: Fixes: 4557c2292854 ("xen: arm: rewrite start of day page table and cpu bring up") If maintainers are ok > xen/arch/arm/include/asm/mm.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h > index 5b530f0f40..698e54aff0 100644 > --- a/xen/arch/arm/include/asm/mm.h > +++ b/xen/arch/arm/include/asm/mm.h > @@ -165,6 +165,9 @@ struct page_info > #define _PGC_need_scrub _PGC_allocated > #define PGC_need_scrub PGC_allocated > > +/* Non-boot CPUs use this to find the correct pagetables. */ > +extern uint64_t init_ttbr; > + > extern mfn_t directmap_mfn_start, directmap_mfn_end; > extern vaddr_t directmap_virt_end; > #ifdef CONFIG_ARM_64 > -- > 2.34.1 > >
On Wed, 9 Aug 2023, Luca Fancellu wrote: > > On 9 Aug 2023, at 12:02, Nicola Vetrini <nicola.vetrini@bugseng.com> wrote: > > > > Add a declaration for the variable 'init_ttbr' to resolve > > the violation of Rule 8.4 present in the associated source file 'mm.c'. > > > > No functional changes. > > > > Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com> > > --- > > Reviewed-by: Luca Fancellu <luca.fancellu@arm.com> > > With: > > Fixes: 4557c2292854 ("xen: arm: rewrite start of day page table and cpu bring up") > > If maintainers are ok Yes Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index 5b530f0f40..698e54aff0 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -165,6 +165,9 @@ struct page_info #define _PGC_need_scrub _PGC_allocated #define PGC_need_scrub PGC_allocated +/* Non-boot CPUs use this to find the correct pagetables. */ +extern uint64_t init_ttbr; + extern mfn_t directmap_mfn_start, directmap_mfn_end; extern vaddr_t directmap_virt_end; #ifdef CONFIG_ARM_64
Add a declaration for the variable 'init_ttbr' to resolve the violation of Rule 8.4 present in the associated source file 'mm.c'. No functional changes. Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com> --- xen/arch/arm/include/asm/mm.h | 3 +++ 1 file changed, 3 insertions(+)