diff mbox series

[XEN,3/4] xen/drivers: address violations of MISRA C:2012 Rule 8.2

Message ID 6cd192af722b99323021c6f1561c5cf0178a1aaf.1702394721.git.federico.serafini@bugseng.com (mailing list archive)
State New, archived
Headers show
Series xen: address violations of MISRA C:2012 Rule 8.2 | expand

Commit Message

Federico Serafini Dec. 12, 2023, 3:37 p.m. UTC 
Add missing parameter names. No functional change.

Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
---
 xen/drivers/char/ehci-dbgp.c | 4 ++--
 xen/drivers/video/vga.c      | 2 +-
 xen/include/xen/video.h      | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

Comments

Stefano Stabellini Dec. 12, 2023, 10:51 p.m. UTC | #1 
On Tue, 12 Dec 2023, Federico Serafini wrote:
> Add missing parameter names. No functional change.
> 
> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
diff mbox series

Patch

diff --git a/xen/drivers/char/ehci-dbgp.c b/xen/drivers/char/ehci-dbgp.c
index 72e1beabbb..0f5b41899e 100644
--- a/xen/drivers/char/ehci-dbgp.c
+++ b/xen/drivers/char/ehci-dbgp.c
@@ -341,7 +341,7 @@  struct ehci_dbgp {
     struct ehci_caps __iomem *ehci_caps;
 };
 
-static int ehci_dbgp_external_startup(struct ehci_dbgp *);
+static int ehci_dbgp_external_startup(struct ehci_dbgp *dbgp);
 
 static void ehci_dbgp_status(struct ehci_dbgp *dbgp, const char *str)
 {
@@ -997,7 +997,7 @@  err:
     return -ENODEV;
 }
 
-typedef void (*set_debug_port_t)(struct ehci_dbgp *, unsigned int);
+typedef void (*set_debug_port_t)(struct ehci_dbgp *dbgp, unsigned int port);
 
 static void cf_check default_set_debug_port(
     struct ehci_dbgp *dbgp, unsigned int port)
diff --git a/xen/drivers/video/vga.c b/xen/drivers/video/vga.c
index 18b590cdf0..b4d0183261 100644
--- a/xen/drivers/video/vga.c
+++ b/xen/drivers/video/vga.c
@@ -21,7 +21,7 @@  static unsigned char *video;
 
 static void cf_check vga_text_puts(const char *s, size_t nr);
 static void cf_check vga_noop_puts(const char *s, size_t nr) {}
-void (*video_puts)(const char *, size_t nr) = vga_noop_puts;
+void (*video_puts)(const char *s, size_t nr) = vga_noop_puts;
 
 /*
  * 'vga=<mode-specifier>[,keep]' where <mode-specifier> is one of:
diff --git a/xen/include/xen/video.h b/xen/include/xen/video.h
index 96f8a50132..1ee1aa46b1 100644
--- a/xen/include/xen/video.h
+++ b/xen/include/xen/video.h
@@ -13,7 +13,7 @@ 
 
 #ifdef CONFIG_VIDEO
 void video_init(void);
-extern void (*video_puts)(const char *, size_t nr);
+extern void (*video_puts)(const char *s, size_t nr);
 void video_endboot(void);
 #else
 #define video_init()    ((void)0)