| Message ID | 6f482f3d54989e4ccce1b651db750c2e789a8886.1689779749.git.ehem+xen@m5p.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Reducing visibility and cleanup of .cfg parsing symbols | expand |
diff --git a/tools/include/libxlutil.h b/tools/include/libxlutil.h index 0ce66c2096..de57ca4200 100644 --- a/tools/include/libxlutil.h +++ b/tools/include/libxlutil.h @@ -25,11 +25,6 @@ enum XLU_ConfigValueType { XLU_LIST, }; -enum XLU_Operation { - XLU_OP_ASSIGNMENT = 0, - XLU_OP_ADDITION, -}; - /* Unless otherwise stated, all functions return an errno value. */ typedef struct XLU_Config XLU_Config; typedef struct XLU_ConfigList XLU_ConfigList; diff --git a/tools/libs/util/libxlu_cfg_i.h b/tools/libs/util/libxlu_cfg_i.h index 4217f5b28d..3d1e4ed568 100644 --- a/tools/libs/util/libxlu_cfg_i.h +++ b/tools/libs/util/libxlu_cfg_i.h @@ -21,6 +21,11 @@ #include "libxlu_internal.h" #include "libxlu_cfg_y.h" +enum XLU_Operation { + XLU_OP_ASSIGNMENT = 0, + XLU_OP_ADDITION, +}; + void xlu__cfg_set_free(XLU_ConfigSetting *set); void xlu__cfg_set_store(CfgParseContext*, char *name, enum XLU_Operation op,
This enumerated value is never used outside of the lowest layer of the configuration parser. As such, move to the internal header. Fixes: a30910bfd7 ("libxlu: Handle += in config files") Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com> --- I'm unsure whether this is fixing a30910bfd7. Placing XLU_Operation in libxlutil.h was certainly erroneous, but it is quite unlikely to directly result in actual bugs. --- tools/include/libxlutil.h | 5 ----- tools/libs/util/libxlu_cfg_i.h | 5 +++++ 2 files changed, 5 insertions(+), 5 deletions(-)