From patchwork Sun Jul 9 23:06:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Elliott Mitchell X-Patchwork-Id: 13319220 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9E01C001B0 for ; Wed, 19 Jul 2023 16:57:29 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.566078.884709 (Exim 4.92) (envelope-from ) id 1qMAUL-0003ym-Jq; Wed, 19 Jul 2023 16:57:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 566078.884709; Wed, 19 Jul 2023 16:57:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qMAUL-0003yf-Du; Wed, 19 Jul 2023 16:57:21 +0000 Received: by outflank-mailman (input) for mailman id 566078; Wed, 19 Jul 2023 16:57:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qMAQT-0001Uv-5W for xen-devel@lists.xenproject.org; Wed, 19 Jul 2023 16:53:21 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c2feaa43-2654-11ee-8611-37d641c3527e; Wed, 19 Jul 2023 18:53:19 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 36JGqxYS034041 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 19 Jul 2023 12:53:05 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 36JGqxCQ034040; Wed, 19 Jul 2023 09:52:59 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c2feaa43-2654-11ee-8611-37d641c3527e Message-Id: <6f482f3d54989e4ccce1b651db750c2e789a8886.1689779749.git.ehem+xen@m5p.com> In-Reply-To: References: From: Elliott Mitchell To: xen-devel@lists.xenproject.org Cc: Wei Liu Cc: Anthony PERARD Cc: Juergen Gross Date: Sun, 9 Jul 2023 16:06:30 -0700 Subject: [PATCH 3/7] tools/utils: move XLU_Operation to libxlu_cfg_i.h.h This enumerated value is never used outside of the lowest layer of the configuration parser. As such, move to the internal header. Fixes: a30910bfd7 ("libxlu: Handle += in config files") Signed-off-by: Elliott Mitchell --- I'm unsure whether this is fixing a30910bfd7. Placing XLU_Operation in libxlutil.h was certainly erroneous, but it is quite unlikely to directly result in actual bugs. --- tools/include/libxlutil.h | 5 ----- tools/libs/util/libxlu_cfg_i.h | 5 +++++ 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/include/libxlutil.h b/tools/include/libxlutil.h index 0ce66c2096..de57ca4200 100644 --- a/tools/include/libxlutil.h +++ b/tools/include/libxlutil.h @@ -25,11 +25,6 @@ enum XLU_ConfigValueType { XLU_LIST, }; -enum XLU_Operation { - XLU_OP_ASSIGNMENT = 0, - XLU_OP_ADDITION, -}; - /* Unless otherwise stated, all functions return an errno value. */ typedef struct XLU_Config XLU_Config; typedef struct XLU_ConfigList XLU_ConfigList; diff --git a/tools/libs/util/libxlu_cfg_i.h b/tools/libs/util/libxlu_cfg_i.h index 4217f5b28d..3d1e4ed568 100644 --- a/tools/libs/util/libxlu_cfg_i.h +++ b/tools/libs/util/libxlu_cfg_i.h @@ -21,6 +21,11 @@ #include "libxlu_internal.h" #include "libxlu_cfg_y.h" +enum XLU_Operation { + XLU_OP_ASSIGNMENT = 0, + XLU_OP_ADDITION, +}; + void xlu__cfg_set_free(XLU_ConfigSetting *set); void xlu__cfg_set_store(CfgParseContext*, char *name, enum XLU_Operation op,