From patchwork Mon Jul 31 07:33:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicola Vetrini X-Patchwork-Id: 13333935 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4EE05C04A94 for ; Mon, 31 Jul 2023 07:34:42 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.572768.896807 (Exim 4.92) (envelope-from ) id 1qQNQE-0008MY-1P; Mon, 31 Jul 2023 07:34:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 572768.896807; Mon, 31 Jul 2023 07:34:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQNQD-0008MP-UP; Mon, 31 Jul 2023 07:34:29 +0000 Received: by outflank-mailman (input) for mailman id 572768; Mon, 31 Jul 2023 07:34:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qQNQC-000873-Cq for xen-devel@lists.xenproject.org; Mon, 31 Jul 2023 07:34:28 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id adfdc37f-2f74-11ee-b254-6b7b168915f2; Mon, 31 Jul 2023 09:34:27 +0200 (CEST) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 221384EE0741; Mon, 31 Jul 2023 09:34:26 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: adfdc37f-2f74-11ee-b254-6b7b168915f2 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , George Dunlap , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH v2 2/4] x86/mm: remove variable to avoid shadowing Date: Mon, 31 Jul 2023 09:33:39 +0200 Message-Id: <734fa59e3f1ee384a5481fb9952f79c8751f04cc.1690788513.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 The local variable 'p2mt' shadows a declaration of the same variable in the enclosing scope, but removing the inner declaration does not alter the semantics ('p2mt' is an output for the get_gfn call later on) and this resolves a violation of MISRA C:2012 Rule 5.3. Both variables were last introduced by commit d4f699a0df6cea907c1de5c277500b98c0729685. No functional changes. Signed-off-by: Nicola Vetrini Reviewed-by: Jan Beulich --- Change in v2: - removed the innermost p2mt instead of renaming it. --- xen/arch/x86/mm/p2m.c | 2 -- 1 file changed, 2 deletions(-) -- 2.34.1 diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c index 714358f953..f6df35767a 100644 --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -2439,8 +2439,6 @@ int xenmem_add_to_physmap_one( case XENMAPSPACE_gmfn: { - p2m_type_t p2mt; - gfn = idx; mfn = get_gfn_unshare(d, gfn, &p2mt); /* If the page is still shared, exit early */