From patchwork Thu Aug 3 10:22:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simone Ballarin X-Patchwork-Id: 13339681 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69123C04A94 for ; Thu, 3 Aug 2023 10:23:38 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.576183.902088 (Exim 4.92) (envelope-from ) id 1qRVUO-0006Ir-HW; Thu, 03 Aug 2023 10:23:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 576183.902088; Thu, 03 Aug 2023 10:23:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVUO-0006Ii-DC; Thu, 03 Aug 2023 10:23:28 +0000 Received: by outflank-mailman (input) for mailman id 576183; Thu, 03 Aug 2023 10:23:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qRVUN-0005QX-EG for xen-devel@lists.xenproject.org; Thu, 03 Aug 2023 10:23:27 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c7fccec2-31e7-11ee-8613-37d641c3527e; Thu, 03 Aug 2023 12:23:25 +0200 (CEST) Received: from beta.station (net-188-218-251-179.cust.vodafonedsl.it [188.218.251.179]) by support.bugseng.com (Postfix) with ESMTPSA id 483E64EE0737; Thu, 3 Aug 2023 12:23:25 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c7fccec2-31e7-11ee-8613-37d641c3527e From: Simone Ballarin To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Gianluca Luparini , Tamas K Lengyel , Alexandru Isaila , Petre Pircalabu , Simone Ballarin Subject: [XEN PATCH 06/13] xen/mem_access: address violations of MISRA C:2012 Rule 7.3 Date: Thu, 3 Aug 2023 12:22:21 +0200 Message-Id: <7e4ff67a24206177c5a304055f395cc2983bb994.1691053438.git.simone.ballarin@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 From: Gianluca Luparini The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline states: "The lowercase character 'l' shall not be used in a literal suffix". Use the "L" suffix instead of the "l" suffix, to avoid potential ambiguity. If the "u" suffix is used near "L", use the "U" suffix instead, for consistency. The changes in this patch are mechanical. Signed-off-by: Gianluca Luparini Signed-off-by: Simone Ballarin Reviewed-by: Stefano Stabellini Acked-by: Tamas K Lengyel --- xen/common/mem_access.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/common/mem_access.c b/xen/common/mem_access.c index 010e6f8dbf..385950789c 100644 --- a/xen/common/mem_access.c +++ b/xen/common/mem_access.c @@ -60,7 +60,7 @@ int mem_access_memop(unsigned long cmd, case XENMEM_access_op_set_access: rc = -EINVAL; - if ( (mao.pfn != ~0ull) && + if ( (mao.pfn != ~0ULL) && (mao.nr < start_iter || ((mao.pfn + mao.nr - 1) < mao.pfn) || ((mao.pfn + mao.nr - 1) > domain_get_maximum_gpfn(d))) ) @@ -96,7 +96,7 @@ int mem_access_memop(unsigned long cmd, break; rc = -EINVAL; - if ( (mao.pfn > domain_get_maximum_gpfn(d)) && mao.pfn != ~0ull ) + if ( (mao.pfn > domain_get_maximum_gpfn(d)) && mao.pfn != ~0ULL ) break; rc = p2m_get_mem_access(d, _gfn(mao.pfn), &access, 0);