| Message ID | 7fd0c7bdc14ac2544a568e66387df21eee892523.1703255175.git.oleksii.kurochko@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Enable build of full Xen for RISC-V | expand |
On 22.12.2023 16:12, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com> > --- > Changes in V3: > - drop cpu_is_offline() as it was moved to xen/smp.h. Hmm. > - add SPDX. > - drop unnessary #ifdef. > - fix "No new line" > - update the commit message And another hmm. > --- /dev/null > +++ b/xen/arch/riscv/include/asm/smp.h > @@ -0,0 +1,28 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +#ifndef __ASM_RISCV_SMP_H > +#define __ASM_RISCV_SMP_H > + > +#include <xen/cpumask.h> > +#include <xen/percpu.h> > + > +DECLARE_PER_CPU(cpumask_var_t, cpu_sibling_mask); > +DECLARE_PER_CPU(cpumask_var_t, cpu_core_mask); > + > +#define cpu_is_offline(cpu) unlikely(!cpu_online(cpu)) This clearly wasn't dropped (yet). Jan
On Thu, 2024-01-11 at 17:36 +0100, Jan Beulich wrote: > On 22.12.2023 16:12, Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com> > > --- > > Changes in V3: > > - drop cpu_is_offline() as it was moved to xen/smp.h. > > Hmm. > > > - add SPDX. > > - drop unnessary #ifdef. > > - fix "No new line" > > - update the commit message > > And another hmm. It was removed word "asm/" before smp.h, but yes it is not correct to write commit "message" should be "title". I'll be more precise next time. > > > --- /dev/null > > +++ b/xen/arch/riscv/include/asm/smp.h > > @@ -0,0 +1,28 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > +#ifndef __ASM_RISCV_SMP_H > > +#define __ASM_RISCV_SMP_H > > + > > +#include <xen/cpumask.h> > > +#include <xen/percpu.h> > > + > > +DECLARE_PER_CPU(cpumask_var_t, cpu_sibling_mask); > > +DECLARE_PER_CPU(cpumask_var_t, cpu_core_mask); > > + > > +#define cpu_is_offline(cpu) unlikely(!cpu_online(cpu)) > > This clearly wasn't dropped (yet). It looks like it was rebasing issue. I'll handle that in the next patch version. Thanks. ~ Oleksii
diff --git a/xen/arch/riscv/include/asm/smp.h b/xen/arch/riscv/include/asm/smp.h new file mode 100644 index 0000000000..336db5906e --- /dev/null +++ b/xen/arch/riscv/include/asm/smp.h @@ -0,0 +1,28 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __ASM_RISCV_SMP_H +#define __ASM_RISCV_SMP_H + +#include <xen/cpumask.h> +#include <xen/percpu.h> + +DECLARE_PER_CPU(cpumask_var_t, cpu_sibling_mask); +DECLARE_PER_CPU(cpumask_var_t, cpu_core_mask); + +#define cpu_is_offline(cpu) unlikely(!cpu_online(cpu)) + +/* + * Do we, for platform reasons, need to actually keep CPUs online when we + * would otherwise prefer them to be off? + */ +#define park_offline_cpus false + +#endif + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */
Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com> --- Changes in V3: - drop cpu_is_offline() as it was moved to xen/smp.h. - add SPDX. - drop unnessary #ifdef. - fix "No new line" - update the commit message --- Changes in V2: - Nothing changed. Only rebase. --- xen/arch/riscv/include/asm/smp.h | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 xen/arch/riscv/include/asm/smp.h