From patchwork Thu Aug 10 11:09:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Zhang, Xiong Y" X-Patchwork-Id: 9893297 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BC02F60325 for ; Thu, 10 Aug 2017 11:11:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A798E28AE3 for ; Thu, 10 Aug 2017 11:11:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9BFDC28AEB; Thu, 10 Aug 2017 11:11:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,HTML_MESSAGE, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2925928AE9 for ; Thu, 10 Aug 2017 11:11:36 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dflLG-00070P-Bw; Thu, 10 Aug 2017 11:09:30 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dflLF-00070I-5r for xen-devel@lists.xenproject.org; Thu, 10 Aug 2017 11:09:29 +0000 Received: from [85.158.137.68] by server-16.bemta-3.messagelabs.com id 3A/89-01732-8EE3C895; Thu, 10 Aug 2017 11:09:28 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrCJsWRWlGSWpSXmKPExsXS1tYhovvcrif SYNYTVYvvWyYzOTB6HP5whSWAMYo1My8pvyKBNaN7kUjBtoKKe0/msTYwbk3rYuTiEBKYzihx c9ot5i5GTg4JAV6JI8tmsELYwRKXtq5nhyhqYJQ4/fYYK4Szm1Fi+cdbbBDOLkaJyRvms0A46 xgleu4tAOtnEzCQ+H2ujwXEFhHQkzh84iuYzQxk/zoCUSMsYCOx88VmZogaR4mtjxcwwdQ/3X YOrJ5FQFViT88JMJsX6Kb2RzcZQWxGATGJ76fWMEHMFJe49WQ+E8TdAhJL9pyH+kdU4uXjf2B nSwjMZZY43bEdqkha4ti666wQCyQlJn36AmWLS6y5PB/O7tz3kw2iXlHi7/pWRohleRKPelrY IA4SlDg58wnYcUICKhLtvadYJjDKzEJy0ywkLbOQtEDEdSQW7P7EBmFrSyxb+JoZxj5z4DETs vgCRvZVjBrFqUVlqUW6hoZ6SUWZ6RkluYmZObqGBsZ6uanFxYnpqTmJScV6yfm5mxiBaYIBCH Ywrv7tdIhRkoNJSZS3+FN3pBBfUn5KZUZicUZ8UWlOavEhRg0ODoHNa1dfYJRiycvPS1WS4GU BpiMhwaLU9NSKtMwcYCKDKZXg4FES4d1mC5TmLS5IzC3OTIdInWK059iwev0XJo47fRuA5KHf J74zcRwDkUJgU6XEeS+DtAmAtGWU5sENhSXeS4yyUsK8jEAnC/EUpBblZpagyr9iFOdgVBLmV QCZwpOZVwK3+xXQWUxAZ0X4doKcVZKIkJJqYPQ1NWHJ+yLUHew46Qjzy01y+4WavA9s5Fgza+ Gde2fX3fRNlWu5JHTwaAfLnEsH/e+sPrb4hXCv5qd/ymdWL0gMa8v9c0rU6kZuy53ltw353XY X9Wjuu7+kmvXWHue5C+d/Efq/4Pv/jO8vZqmdtzaO5y76UVNxjWe6/JXk419bC6JvZh/Jm3pS iaU4I9FQi7moOBEAb/KKG7cDAAA= X-Env-Sender: xiong.y.zhang@intel.com X-Msg-Ref: server-3.tower-31.messagelabs.com!1502363365!109419174!1 X-Originating-IP: [134.134.136.20] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogMTM0LjEzNC4xMzYuMjAgPT4gMzU1MzU4\n X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 35828 invoked from network); 10 Aug 2017 11:09:27 -0000 Received: from mga02.intel.com (HELO mga02.intel.com) (134.134.136.20) by server-3.tower-31.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 10 Aug 2017 11:09:27 -0000 Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Aug 2017 04:09:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,352,1498546800"; d="scan'208,217";a="138607874" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 10 Aug 2017 04:09:24 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 10 Aug 2017 04:09:24 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 10 Aug 2017 04:09:23 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.114]) by shsmsx102.ccr.corp.intel.com ([169.254.2.183]) with mapi id 14.03.0319.002; Thu, 10 Aug 2017 19:09:20 +0800 From: "Zhang, Xiong Y" To: xen-devel Thread-Topic: [Bug] 4.12 kernel dom0 always reboot on xen 4.9 efi Thread-Index: AdMRuBhXKKQM4kvITM65OEG8pxvnWw== Date: Thu, 10 Aug 2017 11:09:20 +0000 Message-ID: <8082FF9BCB2B054996454E47167FF4EC1C59CA0C@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmM1YjhiMDEtZmNkNy00YzFmLWEzZGMtZTBmZDAzNDkyMzVmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ikt5OHZWYkNzOUNmYkM5c1o4alFFOVROY0grUnZyR1RxR3ZZZElqaXFXOE09In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Cc: "Zhang, Xiong Y" Subject: [Xen-devel] [Bug] 4.12 kernel dom0 always reboot on xen 4.9 efi X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP On my SKL/KBL machine, upstream 4.12 kernel dom0 couldn't boot up using xen.efi which is xen 4.9 (1) Upstream 4.11 kernel doesn't have such issue. (2) Upstream 4.12 kernel on my native uefi machine could boot up. After some debug, I have some finding: firmware/efi.c: Reinit efi global variable efi is a global variable, some of efi members is initialized to INVALID_TABLE_ADDR when efi is defined. But efi is zero when setup_arch() begin running for unknown reason. This patch set it again to avoid kernel panic. This fix 4.12 kernel dom0 couldn't boot up on xen.efi 4.9. thanks diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c index b372aad..27bbcb4 100644 --- a/drivers/firmware/efi/efi.c +++ b/drivers/firmware/efi/efi.c @@ -474,6 +474,9 @@ int __init efi_config_parse_tables(void *config_tables, int count, int sz, void *tablep; int i; + efi.mps = efi.acpi = efi.acpi20 = efi.smbios = efi.smbios3 = efi.sal_systab = + efi.boot_info = efi.hcdp = efi.uga = efi.uv_systab = efi.fw_vendor = + efi.esrt= efi.properties_table = efi.rng_seed = efi.mem_attr_table = EFI_INVALID_TABLE_ADDR; why efi is zero at setup_arch() begin running ? who will clear it ?