From patchwork Fri Mar 17 19:53:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Elliott Mitchell X-Patchwork-Id: 13310858 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18F36EB64DA for ; Wed, 12 Jul 2023 20:04:48 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.562791.879572 (Exim 4.92) (envelope-from ) id 1qJg4U-0005oE-GL; Wed, 12 Jul 2023 20:04:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 562791.879572; Wed, 12 Jul 2023 20:04:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qJg4U-0005o7-DK; Wed, 12 Jul 2023 20:04:22 +0000 Received: by outflank-mailman (input) for mailman id 562791; Wed, 12 Jul 2023 20:04:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qJg4T-0004Xs-Kt for xen-devel@lists.xenproject.org; Wed, 12 Jul 2023 20:04:21 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [74.104.188.4]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 49c476a1-20ef-11ee-b239-6b7b168915f2; Wed, 12 Jul 2023 22:04:21 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 36CK4B1W091933 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 12 Jul 2023 16:04:17 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 36CK4BC3091932; Wed, 12 Jul 2023 13:04:11 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 49c476a1-20ef-11ee-b239-6b7b168915f2 Message-Id: <880212ac370425389688f8b4fef2fd27c4fba446.1689191941.git.ehem+xen@m5p.com> In-Reply-To: References: From: Elliott Mitchell To: xen-devel@lists.xenproject.org Cc: Jan Beulich Cc: Andrew Cooper Cc: =?unknown-8bit?b?IlJvZ2VyIFBhdSBNb25uw6kiIDxyb2dlci5wYXVAY2l0cml4LmNv?= =?unknown-8bit?b?bT4=?= Cc: Wei Liu Date: Fri, 17 Mar 2023 12:53:32 -0700 Subject: [PATCH v3 3/3] x86/APIC: adjustments to error_interrupt() loop ARRAY_SIZE() makes future maintainance easier and thus less likely for bugs to occur. Signed-off-by: Elliott Mitchell Acked-by: Jan Beulich --- v2: Breaking this miniscule tidbit off. --- xen/arch/x86/apic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/apic.c b/xen/arch/x86/apic.c index 5b830b2312..18ceb35e34 100644 --- a/xen/arch/x86/apic.c +++ b/xen/arch/x86/apic.c @@ -1412,7 +1412,7 @@ static void cf_check error_interrupt(struct cpu_user_regs *regs) }; const char *entries[ARRAY_SIZE(esr_fields)]; unsigned int v, v1; - int i; + unsigned int i; /* First tickle the hardware, only then report what went on. -- REW */ v = apic_read(APIC_ESR); @@ -1420,7 +1420,7 @@ static void cf_check error_interrupt(struct cpu_user_regs *regs) v1 = apic_read(APIC_ESR); ack_APIC_irq(); - for ( i = 7; i >= 0; --i ) + for ( i = 0; i < ARRAY_SIZE(entries); ++i ) entries[i] = v1 & (1 << i) ? esr_fields[i] : ""; printk(XENLOG_DEBUG "APIC error on CPU%u: %02x(%02x)" "%s%s%s%s%s%s%s%s" "\n",