| Message ID | 8891bdfb2378187cfcaa8ed6f49817404db15924.1690307465.git.ehem+xen@m5p.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RESEND] tools/xl_parse: remove message for tsc mode string | expand |
On Thu, Jul 13, 2023 at 04:53:57PM -0700, Elliott Mitchell wrote: > Normal behavior is to be silent. Generating a message for the preferred > input can be mistaken for an error. As such remove this message to match > other conditions. > > Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com> Acked-by: Anthony PERARD <anthony.perard@citrix.com> Thanks,
diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index f036e56fc2..7b1369f098 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -1658,7 +1658,6 @@ void parse_config_data(const char *config_source, } b_info->tsc_mode = l; } else if (!xlu_cfg_get_string(config, "tsc_mode", &buf, 0)) { - fprintf(stderr, "got a tsc mode string: \"%s\"\n", buf); if (libxl_tsc_mode_from_string(buf, &b_info->tsc_mode)) { fprintf(stderr, "ERROR: invalid value \"%s\" for \"tsc_mode\"\n", buf);
Normal behavior is to be silent. Generating a message for the preferred input can be mistaken for an error. As such remove this message to match other conditions. Signed-off-by: Elliott Mitchell <ehem+xen@m5p.com> --- This looks like a bit of printf()-debugging which never got removed. The message serves to discourage use of the named tsc_mode values. I suspect this is the ooposite of the desired result and therefore should be purged. --- tools/xl/xl_parse.c | 1 - 1 file changed, 1 deletion(-)