From patchwork Tue Mar 11 10:24:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mykyta Poturai X-Patchwork-Id: 14011466 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57F51C282EC for ; Tue, 11 Mar 2025 10:25:31 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.907711.1314929 (Exim 4.92) (envelope-from ) id 1trwnO-0004hX-02; Tue, 11 Mar 2025 10:25:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 907711.1314929; Tue, 11 Mar 2025 10:25:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1trwnN-0004h1-Lh; Tue, 11 Mar 2025 10:25:09 +0000 Received: by outflank-mailman (input) for mailman id 907711; Tue, 11 Mar 2025 10:25:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1trwnM-0004Ad-1i for xen-devel@lists.xenproject.org; Tue, 11 Mar 2025 10:25:08 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20605.outbound.protection.outlook.com [2a01:111:f403:2613::605]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1a5a1c27-fe63-11ef-9ab9-95dc52dad729; Tue, 11 Mar 2025 11:25:07 +0100 (CET) Received: from PAVPR03MB10102.eurprd03.prod.outlook.com (2603:10a6:102:30d::12) by DU4PR03MB10646.eurprd03.prod.outlook.com (2603:10a6:10:58c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.27; Tue, 11 Mar 2025 10:24:57 +0000 Received: from PAVPR03MB10102.eurprd03.prod.outlook.com ([fe80::35ac:8893:c31c:b971]) by PAVPR03MB10102.eurprd03.prod.outlook.com ([fe80::35ac:8893:c31c:b971%3]) with mapi id 15.20.8511.026; Tue, 11 Mar 2025 10:24:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1a5a1c27-fe63-11ef-9ab9-95dc52dad729 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OeZCKa7NTPaalODffIpVPZxyubtbDkfmnybRmNGuy+ri0kcxKqOS5xNZQIEGy8/FqyeE3d2iV22W8we8y/G3b3NX1vK9xhEVpHy07lOF7cBkdoHBdySt1GCf98cpB/4F9e8/Ws2a+mlQx+L7INz7i/Wo92UPPJdOUuaWv3WJhpXh35Bb/f98GghY1R0xkxPp7Y+Rc7VUzlGle5qzWo3MLVhSOvck8xrA1Vc+S7b81fS6p4czEXrqUrNA4OA9gPBoccfbNMbzf4oSFtMs64a7ViFOrJQLsnPS6ZwcMgseyDE37yfPnX6BwcM0m6r3bFfIXoPFV6WNL3Bb+VW5e1LXHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jHsx4IPGUNnEssavxJhbxu4YzgwEQR4y4pjAfnqiIiU=; b=CAWtxwFyVWm+L8ZGXt/z7/lxl0mooQMfHIsKZW7UH8yTkXwzw1tS+kvpbLWTOfb61FQBxEDaR7sKgvD3paQNf2I2gxPtDPu1en6juokZKxsaSdYFPcU258Uabr4FRGpLAlhUVQ1d466yzAs2SOXO4NSH1Gmn0g3jwnvL8oBjgw1YRVShFUpUgC6IFn41iIjjW6ILMnw5EG+IzmK3f0ThpcywgQC67ePUVGoRjXwAzctydK8+z/MiYy+xJNyDImkKr/O8hUKJROX4hEmX3RQmCss9sZQi+0FaTI9AWMiIhehvfdz4VadLde9BMw8IZyjESwjjg0Z5sPQPxf64nnLDBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jHsx4IPGUNnEssavxJhbxu4YzgwEQR4y4pjAfnqiIiU=; b=GKrRwYRvHyM9HAeJHswhToy89qvcugDEgk+gKu8E0yKnIQ1aV/ITTjtrRaJgYpOlbTzyfp4ZFxVhVi3Ab1TMBXlTpImcwA5Kr9iYSUNz/E+gt1iJ/Zo1Bp1Oe3tCN7rwxVPgKiVnk1qCMHk5oxkalUsl8OXsbkAELCbh/W1Mw82clfAIXmyu6D1IkT7Z5TECynCqKpLoYGrgoFx4Nctdc5oGNS5+adEjC6Vth7N9XJtaZpQh0mdwDRpUmAgI1HS9yEh3uFHkFum42LPZgrCW7VqYxCzElGCDNDk+E8/iD4aChQF9yfRrkrrmTDnKcuzl6o+5jRASJwmIURsmi6YgTg== From: Mykyta Poturai To: "xen-devel@lists.xenproject.org" CC: Volodymyr Babchuk , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , Volodymyr Babchuk , Mykyta Poturai Subject: [PATCH v2 5/7] xen/arm: rcar4: add delay after programming ATU Thread-Topic: [PATCH v2 5/7] xen/arm: rcar4: add delay after programming ATU Thread-Index: AQHbkm/V+s7gEh8jVE2kSVeMpYb04g== Date: Tue, 11 Mar 2025 10:24:56 +0000 Message-ID: <9cd78a64dde2e0a039919a08025abaa89d63966c.1741596512.git.mykyta_poturai@epam.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=epam.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PAVPR03MB10102:EE_|DU4PR03MB10646:EE_ x-ms-office365-filtering-correlation-id: 446d29ff-4a12-44ae-44a4-08dd6086f902 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|376014|1800799024|366016|38070700018; x-microsoft-antispam-message-info: =?iso-8859-1?q?ULJyjMejd8A8v8/hbedXMoqoa7?= =?iso-8859-1?q?VZHsjkbOVOXYDu+V0CQ7qb/pkfqIJLwvh3Prljx+pPfZ+Z+uFanBcn5M22j/?= =?iso-8859-1?q?fDBrTKztuM38aNC/woPSEHzYcK+QTogH/lQStxxg8ubEUYev9zme5tMMCL0f?= =?iso-8859-1?q?SGBIQ+bMINayoOlot1CCnS2bGw8IvVUfUKxG5SDKc01TPEZRDxXoZS2TKMJX?= =?iso-8859-1?q?yyjy1EDRNGC3gLzH9iuICdfnr6gDpeE1KqK8LfU+BK7k7X1pslQCmsaVTrTf?= =?iso-8859-1?q?6jhj05UOfRZMd0UDQDEph2QEQ7oQ+mrV5UKxNUpMRMHTwV+yT3ceqQzldNEF?= =?iso-8859-1?q?6O27odGjkNAmiLvoI2uhPSizMDjYwk6aEPGwFz/37r8Wav2x/SDx0U6onmYR?= =?iso-8859-1?q?capGWDbLtz3G51s8TZ3Vy6CXh8EbFmyedr3dx1vfJAUQrYE2MkBql+JmEVA6?= =?iso-8859-1?q?IOJ0G9xqHB8VaJKzW4b0YRD3NuUGSxivcshCTG6Qr+a35okh1QKaJzpk1VID?= =?iso-8859-1?q?ZELQwQ9V9Lk/pXNRJg+FD3/avnSpQM+CIdcRLrfNd3LA3ohTTpj2sZgkZjdd?= =?iso-8859-1?q?yUlafbhZuINC9PIpQYuVmdSfksXvnG+DkWjSuc1C0ia6n30fFuRY5bGi4Xuk?= =?iso-8859-1?q?YbjnSD5v8JQtyFYlk8+8EVrXxfDH0a8+DPuqXQNBZsYHg0/vCs8wHzHAHYwM?= =?iso-8859-1?q?mh6l5ZyI7uDPfsOvBoHbGBrIfOCA9XndfjGQG2WJh7NhN/uJJ1DvLDWXWfRq?= =?iso-8859-1?q?R7gmS3q0wZuc+7C4qxiVWFtRtSoSZRrR71I9jdENLibjBjD9d5lWbmdrRCfr?= =?iso-8859-1?q?dXNP4UeHXmDsySpwyx9TZ/u2/kiWGz6v7DzhnSYjJWyOHhynRRUVDKCiKCcd?= =?iso-8859-1?q?a9993DM5sLnaJAtWb0MNEdkHiowmbcHx+frU2QeOAQL8bbpmkxYLMGbabqyx?= =?iso-8859-1?q?Jwkykcz5jz7LE6UBzXzq8+Re8N1mv+6WAZEguWtrGJScnyFm3OlAHuBLk/2r?= =?iso-8859-1?q?5Y7fDrIasJwat0vGU/LhSr85Z4G4rDaEyb4voGkWYw9m7nqbumJg+5fSL9mQ?= =?iso-8859-1?q?rURT8jjf+Lgnf2CG2GMgPWbcuFbZUG6ZvDsHrUEQqM1tv0zEJUqkmtDyvlNe?= =?iso-8859-1?q?9/AjKjP/ndGnRBPeros040hshqXMj90AiovR57pdz2Vw2WZPsyl8ulTAQbbg?= =?iso-8859-1?q?CbjL0xQKYFYTsNfBBK72Vj1mQITI/jBGc0SQrnwFnL9G46+5kkc4BrUAVi7a?= =?iso-8859-1?q?7cf69h+LWZ2ra/jdSIJY/kVsQASG2W8wAS1z3mrq49jMJ3CU8uExk/NIkrua?= =?iso-8859-1?q?7yWfk0IkwO8kg5XJJDap00L8j2vZW+Lc0IjOJwSmL/BO7pz6bxn9ip8J57dp?= =?iso-8859-1?q?TLx65+X+W+SA8uajNGcsedRYJToghc/+rwSvyzlDXuARELDmdoQjr20j6WXN?= =?iso-8859-1?q?9vyQtZnbnJjYfOkgCelteIeGyxI7j2LulMsCXO3BDW2/ePA8j4PpfYyyQekp?= =?iso-8859-1?q?o35LJV?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAVPR03MB10102.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016)(38070700018);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?q?VbwCsf97UrpjouCUy+X62GB?= =?iso-8859-1?q?SISjeaNyMe+WBRUaD3BKawG+CWVCmzs/ZaHrARnGHHwyqpVkLD0TKyVB59Ad?= =?iso-8859-1?q?l0IdoZY+W6ms8kDVqg7rmvneljnUyjJ0n8EvJdO9kUinXqN7O95AcAsIg2kk?= =?iso-8859-1?q?TXtnDeCv+uIcb4McdEApHj70Yuk8AsT6uZhqm7fYJD74qS3dcwjyyDKDaKdM?= =?iso-8859-1?q?yeMJtpVU2zuwM1MoWk5XQOovWkmAmsRXEaWuH3LIkxtJnsB4IwM/IPMaQY0i?= =?iso-8859-1?q?baEkMhVGW48U45SzAvJsqZHQPcvKjjvWIhJStiZS0toHvG9D+74v7Xl9ORQx?= =?iso-8859-1?q?SZLgyCOzVKrtKvIsgpe3XtHkc8OrYeueSeJO6SSq+rL26XUWQRN3CQSGq8XE?= =?iso-8859-1?q?4gQQYt/Zng76J4uYbgOVexIqRWdGHyTdRT7mbt3EHxO350Ck7jbRJ8cm/WMe?= =?iso-8859-1?q?/6i/L1IdarbiSiYhZhglatLj30fRK4Q2//00aaLyNNUFSL8NWKHO1nM/mCq4?= =?iso-8859-1?q?ey3VrT0obf7C0aLp2NmDkdzL5uIq99Wdk+r1GpjkbbocHT2fFbIURc/eAWRo?= =?iso-8859-1?q?R5NRHrFWPCCdCZrD6Dg/EJdAFPpYnD/96hlt3cBtvhupgvMc6J9MwnFylhce?= =?iso-8859-1?q?U84DwY1g4f/SuUVlK8ITPIsz3Th4ZIFk3Kcoq9QADABTCcKBQKodsbhlrMTs?= =?iso-8859-1?q?ZIQYAFyXPJCyoESGAhhVtHMenYBcVFNSu5TIqY6b8w/1/gtkb9B4bjXPXugr?= =?iso-8859-1?q?fibVh6TAqarfYcIJQFjF6uxrBmGyc7dWn4iGct4NEZ3QZpeEihmiK+Q1yaHg?= =?iso-8859-1?q?9kwlVJ+giYga4zGz+97heFX9p1kDjLOnMOM8R64Teg1sC6qE4pttLezYI6rO?= =?iso-8859-1?q?Evm78UJEr6ALmR6qQX3DgEGWexqZwR+VSPZp0cFRMjNiwCWQuf8INRkkYHAD?= =?iso-8859-1?q?FfPfSWbu1HGBrqB1q9XZmudVa5yb4EuhtMT+guRrL+DvAtWiWf6fR48e67uS?= =?iso-8859-1?q?hCqHpgAkZuKwmw3YMiGEGwcg8tlcJYLiXpSjzufj7buP2WfVooipsXAx/N6Z?= =?iso-8859-1?q?2oKlqpkPyBoV6c5+MiVbGtHXHYi6F5aqv81iwOIxVKcc/Rw3bPOotkEBERMf?= =?iso-8859-1?q?woQIHjxyo0GFljtWVHonSmZYG1OdR85eDzTDiJPHrqrRRn7wOgaMJdaQOXCH?= =?iso-8859-1?q?CQ7HW+JSYSn8AmEXAa/VFJfRRKg/VL280sNkMJlePl1fWbKJtTO7qFS+8THf?= =?iso-8859-1?q?w00WB5MHbCBZlFV5hX5T8uuBynWAkBC+Kk5cYkUg6/jF2vbvm1w06ln2MPPf?= =?iso-8859-1?q?bYKiZqlgBJi/u3o9/Y1ns1tUokDBIOCSU/3PrN89WsDkLyIPFJgRQP32Osie?= =?iso-8859-1?q?hXL5XGnByzBqu0nLzgk3uLJrepUnA9bP8LjL09Fd7O8aNqNxR/aBXrdtttmZ?= =?iso-8859-1?q?QUliWAYzz9XIZ9w8/JRJY2+Grn7HFo8HZYhzMRSxQhO+bEito98xiyu6sJDk?= =?iso-8859-1?q?to5QOXnX/CIr1WPEHCfIg7d7DvYLcKYu1tYSoXvsoLTmdlUti7eGUlaNhN7o?= =?iso-8859-1?q?nN36ExNUn84gIR9s2vDidapfkYpkw+qnJrUdvQ6UOfROTuPqaGR+xKGnH9ZL?= =?iso-8859-1?q?6w7Nla6vqFak+YutNuW81uCcg4aud+7ubfRVvBw=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PAVPR03MB10102.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 446d29ff-4a12-44ae-44a4-08dd6086f902 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2025 10:24:56.6931 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fi/M4T3LWXxuhX6tBs/pc4e9GpPwJkWtXZmWUFbJ78+VMcTWwimcoT2egnnqeFZnpNHHoVOzrQufX22xYpnsQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU4PR03MB10646 From: Volodymyr Babchuk For some reason, we need a delay before accessing ATU region after we programmed it. Otherwise, we'll get erroneous TLP. There is a code below, which should do this in proper way, by polling CTRL2 register, but according to documentation, hardware does not change this ATU_ENABLE bit at all. Signed-off-by: Volodymyr Babchuk Signed-off-by: Mykyta Poturai --- v1->v2: * rebased --- xen/arch/arm/pci/pci-designware.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/xen/arch/arm/pci/pci-designware.c b/xen/arch/arm/pci/pci-designware.c index 6ab03cf9b0..def2c12d63 100644 --- a/xen/arch/arm/pci/pci-designware.c +++ b/xen/arch/arm/pci/pci-designware.c @@ -194,6 +194,11 @@ static void dw_pcie_prog_outbound_atu_unroll(struct pci_host_bridge *pci, dw_pcie_writel_ob_unroll(pci, index, PCIE_ATU_UNR_REGION_CTRL2, PCIE_ATU_ENABLE); + /* + * HACK: We need to delay there, because the next code does not + * work as expected on S4 + */ + mdelay(1); /* * Make sure ATU enable takes effect before any subsequent config * and I/O accesses.