| Message ID | 9d33b2c2aeb59ca67136ed1b65c06e6ef4fd1ed8.1716814609.git.nicola.vetrini@bugseng.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | various ECLAIR and MISRA improvements | expand |
On 27.05.2024 16:53, Nicola Vetrini wrote: > Rule 8.4 states: "A compatible declaration shall be visible when > an object or function with external linkage is defined". > > The function do_general_protection is either used is asm code > or only within this unit, so there is no risk of this getting > out of sync with its definition, but the function must remain > extern. > > Therefore, this function is deviated using a comment-based deviation. > No functional change. > > Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com> Acked-by: Jan Beulich <jbeulich@suse.com> Albeit here, too, I'm not entirely happy with the wording, but I'll let it go as is. While "there is no risk of this getting out of sync with its definition" is true for the C side, there's always the risk of assembly going out of sync with C, simply because the two cannot be properly connected by any means. Jan
diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index 468a03608102..9906e874d593 100644 --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -1257,6 +1257,7 @@ void asmlinkage do_int3(struct cpu_user_regs *regs) pv_inject_hw_exception(X86_EXC_BP, X86_EVENT_NO_EC); } +/* SAF-1-safe */ void do_general_protection(struct cpu_user_regs *regs) { #ifdef CONFIG_PV
Rule 8.4 states: "A compatible declaration shall be visible when an object or function with external linkage is defined". The function do_general_protection is either used is asm code or only within this unit, so there is no risk of this getting out of sync with its definition, but the function must remain extern. Therefore, this function is deviated using a comment-based deviation. No functional change. Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com> --- xen/arch/x86/traps.c | 1 + 1 file changed, 1 insertion(+)