From patchwork Fri Mar 29 09:11:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicola Vetrini X-Patchwork-Id: 13610412 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F76FCD128E for ; Fri, 29 Mar 2024 09:12:03 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.699282.1092024 (Exim 4.92) (envelope-from ) id 1rq8H6-0001kE-22; Fri, 29 Mar 2024 09:11:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 699282.1092024; Fri, 29 Mar 2024 09:11:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rq8H5-0001jE-Lp; Fri, 29 Mar 2024 09:11:47 +0000 Received: by outflank-mailman (input) for mailman id 699282; Fri, 29 Mar 2024 09:11:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rq8H5-0000x2-0u for xen-devel@lists.xenproject.org; Fri, 29 Mar 2024 09:11:47 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5d9a25db-edac-11ee-afe3-a90da7624cb6; Fri, 29 Mar 2024 10:11:45 +0100 (CET) Received: from nico.bugseng.com (unknown [176.206.12.122]) by support.bugseng.com (Postfix) with ESMTPSA id 1433F4EE0749; Fri, 29 Mar 2024 10:11:45 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d9a25db-edac-11ee-afe3-a90da7624cb6 From: Nicola Vetrini To: nicola.vetrini@bugseng.com, xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, bertrand.marquis@arm.com, julien@xen.org, Andrew Cooper , George Dunlap , Jan Beulich Subject: [XEN PATCH v3 6/7] xen/mm: address violations of MISRA C Rule 20.7 Date: Fri, 29 Mar 2024 10:11:34 +0100 Message-Id: <9fade8c540f19876fe7928ab91398bd5e94594b4.1711700095.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 MISRA C Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". Therefore, some macro definitions should gain additional parentheses to ensure that all current and future users will be safe with respect to expansions that can possibly alter the semantics of the passed-in macro parameter. No functional change. Signed-off-by: Nicola Vetrini Acked-by: Jan Beulich --- xen/include/xen/mm.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index 3e84960a365f..7561297a7553 100644 --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -415,15 +415,15 @@ page_list_splice(struct page_list_head *list, struct page_list_head *head) } #define page_list_for_each(pos, head) \ - for ( pos = (head)->next; pos; pos = page_list_next(pos, head) ) + for ( (pos) = (head)->next; (pos); (pos) = page_list_next(pos, head) ) #define page_list_for_each_safe(pos, tmp, head) \ - for ( pos = (head)->next; \ - pos ? (tmp = page_list_next(pos, head), 1) : 0; \ - pos = tmp ) + for ( (pos) = (head)->next; \ + (pos) ? ((tmp) = page_list_next(pos, head), 1) : 0; \ + (pos) = (tmp) ) #define page_list_for_each_safe_reverse(pos, tmp, head) \ - for ( pos = (head)->tail; \ - pos ? (tmp = page_list_prev(pos, head), 1) : 0; \ - pos = tmp ) + for ( (pos) = (head)->tail; \ + (pos) ? ((tmp) = page_list_prev(pos, head), 1) : 0; \ + (pos) = (tmp) ) #else # define page_list_head list_head # define PAGE_LIST_HEAD_INIT LIST_HEAD_INIT