From patchwork Mon Mar 17 05:07:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Choi, Anderson" X-Patchwork-Id: 14018639 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5902C282EC for ; Mon, 17 Mar 2025 05:08:32 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.916158.1321299 (Exim 4.92) (envelope-from ) id 1tu2ho-0001ce-D4; Mon, 17 Mar 2025 05:08:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 916158.1321299; Mon, 17 Mar 2025 05:08:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tu2ho-0001cM-7g; Mon, 17 Mar 2025 05:08:04 +0000 Received: by outflank-mailman (input) for mailman id 916158; Mon, 17 Mar 2025 05:08:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tu2hm-0001c8-V3 for xen-devel@lists.xenproject.org; Mon, 17 Mar 2025 05:08:03 +0000 Received: from ewa-mbsout-02.mbs.boeing.net (ewa-mbsout-02.mbs.boeing.net [130.76.20.195]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ca16a7d0-02ed-11f0-9aba-95dc52dad729; Mon, 17 Mar 2025 06:07:59 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by ewa-mbsout-02.mbs.boeing.net (8.15.2/8.15.2/DOWNSTREAM_MBSOUT) with SMTP id 52H57tlj016652; Sun, 16 Mar 2025 22:07:55 -0700 Received: from XCH16-04-04.nos.boeing.com (xch16-04-04.nos.boeing.com [137.137.111.19]) by ewa-mbsout-02.mbs.boeing.net (8.15.2/8.15.2/8.15.2/UPSTREAM_MBSOUT) with ESMTPS id 52H57iJD016553 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 16 Mar 2025 22:07:44 -0700 Received: from XCH16-06-01.nos.boeing.com (137.137.111.28) by XCH16-04-04.nos.boeing.com (137.137.111.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Sun, 16 Mar 2025 22:07:43 -0700 Received: from XCH19-EDGE-Q02.nos.boeing.com (130.76.23.14) by XCH16-06-01.nos.boeing.com (137.137.111.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44 via Frontend Transport; Sun, 16 Mar 2025 22:07:43 -0700 Received: from USG02-CY1-obe.outbound.protection.office365.us (23.103.199.181) by boeing.com (130.76.23.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Sun, 16 Mar 2025 22:07:40 -0700 Received: from BN0P110MB2148.NAMP110.PROD.OUTLOOK.COM (2001:489a:200:19b::17) by PH1P110MB1396.NAMP110.PROD.OUTLOOK.COM (2001:489a:200:189::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.31; Mon, 17 Mar 2025 05:07:38 +0000 Received: from BN0P110MB2148.NAMP110.PROD.OUTLOOK.COM ([fe80::394b:7a34:da07:485d]) by BN0P110MB2148.NAMP110.PROD.OUTLOOK.COM ([fe80::394b:7a34:da07:485d%6]) with mapi id 15.20.8511.031; Mon, 17 Mar 2025 05:07:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca16a7d0-02ed-11f0-9aba-95dc52dad729 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=boeing.com; s=boeing-s1912; t=1742188075; bh=Z7IUTuOwfQpuS/VQLgUi8jPOyLtavJ0bguvSIR4AbeE=; h=From:To:CC:Subject:Date:From; b=PIfcSvnMeybjZ47UcpypMGnU18ov/av8qHfcX4bklN5D7YmDbPB4Z/HcMk/pV95Y/ hcYlSibIY4nCnnrzrV44y+MmQoHOqx3ChjM9wvmBlHfcz+6spwnV87dKWvEM2UJ4+W kTTeUkbqt++nfmOJtB9seCL0lAOw/xl0aZE+uy1iIckv+lvngHuSfo8+5ku0Kt4dDp GNDS1qX1+EE6dEHmrdvF5rFchC/mQ9lxAFRaEoOReweRkjh6WVed0F9sARXYz1rLgf YE1g+/KLZGFqAsNNgI1xTCYgJMw2AEsaD34g5uxOrQ1SMSLbGN3T4bT6wV1xRLS4li oBL7sg0E+tWYg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector5401; d=microsoft.com; cv=none; b=ZmwUxdG7NvKkID1MTHcM+0GsB1VS5fzAnsW2J92A35PTzb6mdPb30VgIGuIs896FT2knOhA8tN1eZmR2F6hbXS2zwf5IIa/05JoJlRCoRi4jdHPe9TrzVQwtBsmWSkFCsBvMc1P+j+6UDdcyUT4DbxlCH+bQrd5hyQykqNQDs5pE8CNs4v2lvJnIp1rfYbJJ82MQ2oWKU+SL5XeUfbLFmYyi5uXvKnCCAM8f8Zqzhz4py/AVod/iiw43E2Yk95tHF7zIh3QgDs0WJuWjH+79sfrNtbWfw5wcogQ9+T7oN0n2bpyZkJsPIqmj9Tplyb8IL5NVE5Cm5VBaRwNR8CVE5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector5401; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z7IUTuOwfQpuS/VQLgUi8jPOyLtavJ0bguvSIR4AbeE=; b=wmfgRiUsqeUy6WOJJA/Sw2fWC4RPvit8iuOr55chMv+mHzPJG8gqRoAR+CBNawaOmu7Xojzwka7paPd5RXa4LDHhLqEbQj2yruQwbhQxf7EAFej6VtNVqf9IeNYK2U0cWNwDfHpGE24y7WeoHn+s2esPlRxEWIebEZFgsymntM669CkwbhFA5Bk3YtcOtKJJBggKsnetX06L90nnTeJCYXR2xTyiMtKj2W0ULzqjWK0zL+W5zpAMuCcIIyK7qVxiWtD1JqsRefgWYzGc6Tg6ML7VgqbAujIX94ClqaA7VC1/KdcW2GGKQ4FuWeCnH6D4ZhxXAd7DV5FS5X5T+J6V/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=boeing.com; dmarc=pass action=none header.from=boeing.com; dkim=pass header.d=boeing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=boeing.onmicrosoft.com; s=selector1-boeing-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z7IUTuOwfQpuS/VQLgUi8jPOyLtavJ0bguvSIR4AbeE=; b=BbRJ+47xslnPE9WRB6zH51rh6PnWOXT46Vly5EZ4ZLyxYZ9dz+6tA/D9+r93JcPt0CPY9nLzGP0RRJhazhEAyjj3NllJTF4Df7CAaWklA5z8zzi5DGbPq4UMLKyAfd+i1lCNcMJhm2gc+ISXLSuQkwX25njC+Kx6avD5xmadkIs= From: "Choi, Anderson" To: "xen-devel@lists.xenproject.org" CC: "nathan.studer@dornerworks.com" , "stewart@stew.dk" , "Weber (US), Matthew L" , "Whitehead (US), Joshua C" Subject: Xen panic when shutting down ARINC653 cpupool Thread-Topic: Xen panic when shutting down ARINC653 cpupool Thread-Index: AduW+TkPYPhh1TXsRdStDrK0/zWwnA== Date: Mon, 17 Mar 2025 05:07:38 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=boeing.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN0P110MB2148:EE_|PH1P110MB1396:EE_ x-ms-office365-filtering-correlation-id: 8418bc6e-272e-442d-5a7a-08dd6511a370 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0;ARA:13230040|1800799024|366016|38070700018; x-microsoft-antispam-message-info: P5LYiOBT1eZ6ubIVbIKTmoaZFMRasOfikcKZfFtkH1leLb+FGzwQ/ewb7W4pr1+AvOrwM6/wqjnhH2yOrWvYHQCTM2mpK9vZ7tvyouEKozhZzySJ54Eec4zLIXHTRE6Jj1elsrZ1aVXbES5hQQkWCcxBt3HWtnJwZ5VJnNkWQzRSOlo8wBsCPc7h2aN8WD2oZFpPG/F9439tWc0Wme2c9Y9arO87mrIuXRvKGHGQ84ddKPS2vWBV3rDRdh9Hg4JGFzJh6qQOeOIyxOrEi+liU0g9jd/g3PJ/8hXBwjm1dVsQas4/HkofCPC6h3WcL/jhO81erJOGd8vvRM+rVAqGsaXYTb4sCZJU/4Wq4vvTq+P8WYQzyzI+BLGTP+fViTxgzCLaYDZZRX3onTp7yke4XDTxdgcCbnGKRPybQRcetn6jtM2zztNgHGSoOBjDmVoQeHbUzkUtE3r8i/PdB/O7TVSd30s2lNmDdTCivevbm/7lgdWkXBIV6eu6BEWG5C/JDz6m6sAj3AjHcN1eyQJGNw8ox8NmahURf6bpLcJeVciP0dqsSpBh5101kIejbpF1e/A5v+lUtm8p0TPSuUHvzBYE/HAv0IaP4bnMtK6wGFKR9TCYKKOAwNXLdCCaOMzQZ68n14VCmNot49k/UsV1Y1mrHr5LePHLNjn5+LrZ5mU1w8uhItia8KY3K/Zb8gXc00IfeoFcONQC37wabysRGsxmEaonY8jbpAtjzhBQoIDvlxaLOqzdPjJx379H5rdG7ntUPZVpTzLmKuVMsS7Z4HEjoO2uuRAwPLNvWBLncgo1eJBifn+F9OdBFEkvNPWQ8/lqpP/NeOrR6Twft5tIYP4i/dowEUX/WsWPnR7swDN3BKJ4ez8pSVr4kcSElDwzJP6EnM2BnA7V5z89Ys0TF7dna09s+5/ErCOLRMAu/Q5o8OazUTpzYnNtiTk0S4tAj9t8j8DRceNOCK0FjQTYSZEVeK4enJmhCbmIpUlLpo65gF6p8JNCHOI//l/5oBZo3853MZvOUsMYctnImD3E3iaAMBI4tAPJAFPUi7g6ZGC8uZ4LlwCMLtnqfioP2KU2qLalz9AWXkk4xcJOo9WJvMCRcLSZ6O2Fb3CE+xJDPaxJTaoWc2IJvKzyH/aofs2b/B5UfK0jR1mEis2khrjGjhu1/Gbc/j+fnoFrTZ6YkHJPFQFZIL6Fmzh988l5ziWksyKMkyy2CcpjYskdzgHPpLuXwBJzjFiQsEBkN9saix4z3bv45actUJmhLvwZFmql0bKnVDTVFTN+vYR9i18rVgRQhxEq1J8WY7E8O28MVG3n/6hTP47upLPqLQeJXd/oMySHeqMQnXCE4vOn4NYemp8RZT0H4VrAZmrHCd9EHpb7ph5oyIzUxLuFX1nRQdEIs5TCZg4rAD37vR/Bv1M5qyXIhevCcowZGh2Gv77rtyrExD5hGsoNOp7NxMAw59Bc x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN0P110MB2148.NAMP110.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(38070700018);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: 7uy84ms81+vB2CgE3NJ0xj6iTy0OSY0xVRB66shfADt6SPC7mO3WasUwojQ3jqOe1L9mO69KReh3kH8j6Kl19YfjtJ5AtZxeEE/vxke/QecjglnzuCTUATtNn6k824IrlXy7qlpoGmievQ99f0ig5rYozOpBJDzCcW6kSoC0OIIeqrTntUbCejQQD7UUk/Zkgm4VVvlrA30qzT337El0CiaShgZil2jkCVKvvMkFfFrr4us3+lfUq5R4CVvn83lGW6FDaJI036Aby6vMWiw6JiBCrz7fbCLBFzvwIdMcX8FfWN7s2TeBPUQdrXme7FOGuk2nl7PH9k3HI3c8KF4A++giNkvtAreR8TAcUwkXkAKoK5RupW+uper/VmxJ8fEDsuJx2qjB10tl19ZuEBvh2HeCya6QHhII1sx3cguj3AgQJ5Bn4y3zRyyfY/CEBxoO2TxrPsd/6zvTqZLYz9lylI442Y6uFOFQUanLyZqZ8j25y+gyX3ntaMLtd2Pxl4Xqfdq4HMuVpKEkyumbTVpD1IsOlxH94aA+1tZnIwHh0F1D6//eNA4axW7I+l3zugdJYXlQ5B8HefSE7otYsvxihIfsAzsd0pTR8VOL/XHyeS9+1xBPAE176f0gHLTnUIVgy/ID9lcObWoIHcTROfJ74/U5d1mb33PxByltpQgJCecx/KHGupGwS0+HluFUWF83oywjLcWLx4yvOx20hc6f0iOr2nUHapI+x8+ee9TdQsvhZ9H7veGnGDzYIJHf1TFhVx772O++lbEVNU2NN+u8FT3J0QeZBvu99/NvGFPVSczHEW5y6ADPmLVQQBN+HBviLiqQOzbn/7IU+db64ZUEuZX+SYckexS+Dc21FMPHW0V3XsIaOFx1CTVF0q5jNu6WO5qXu3Ee0BljNlECgboLQDbeplcXud1lBJOiODSfHCfcmEqIvtBWqrVCqvt+fGmQsMxGPohpeIE09QXanr/wZEsKAxWejxKUdBusBrSXzR3rzKDVzXuQsT/VhsYvKZ+nGTkCyoM0ns8W7DQ9UsUFMbdy1GdupTHZnub+xJC84yjeNuEwxXQkMVNgC8dB/CQeaXu4aLnemg3Vpuj8J04MxI3R1B2zKivgLC6ssHVY49ko6bZBnYdNWIbRG7qjMWuYZXHZqvXmwMcAPCSFD7Yz8eQGPVYQq3i1KMVauooTuKGdloyK39c011TEDe9uZwbDYBnYghbp9Rt4rzD4UqFyUft9nFs0MIXp2SUgSx/NVi/Vc2dO9LqCLh9UGceWRZVzKbEPakXAwu8pe0/hDeE3ZAsXC/kHC54QKdf7xR/2WtvLYPJwVoUvaIU1LfAJPq+q5Rr1GZ6Jlh1Hpywu2A47MGGguo4pPv+C0uYQat4AFSxpjIdgoRcVkxH74GCRpDFjDHpH+pUDBCj2Z7LVQnilG5vQdY90ohiTIr2anw/iYqR0MkmnaQOzEvozFtjx0hXri7OHHiVMf0Zq9ORYsaW2/b08rvovFRyxZ2cwEDLLWomWt2sIQl5Tb23qGcP57ENR MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN0P110MB2148.NAMP110.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 8418bc6e-272e-442d-5a7a-08dd6511a370 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Mar 2025 05:07:38.7282 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: bcf48bba-4d6f-4dee-a0d2-7df59cc36629 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH1P110MB1396 X-OriginatorOrg: boeing.com X-TM-AS-GCONF: 00 I'd like to report xen panic when shutting down an ARINC653 domain with the following setup. Note that this is only observed when CONFIG_DEBUG is enabled. [Test environment] Yocto release : 5.05 Xen release : 4.19 (hash = 026c9fa29716b0ff0f8b7c687908e71ba29cf239) Target machine : QEMU ARM64 Number of physical CPUs : 4 [Xen config] CONFIG_DEBUG = y [CPU pool configuration files] cpupool_arinc0.cfg - name= "Pool-arinc0" - sched="arinc653" - cpus=["2"] [Domain configuration file] dom1.cfg - vcpus = 1 - pool = "Pool-arinc0" $ xl cpupool-cpu-remove Pool-0 2 $ xl cpupool-create -f cpupool_arinc0.cfg $ xl create dom1.cfg $ a653_sched -P Pool-arinc0 dom1:100 ** Wait for DOM1 to complete boot.** $ xl shutdown dom1 [xen log] root@boeing-linux-ref:~# xl shutdown dom1 Shutting down domain 1 root@boeing-linux-ref:~# (XEN) Assertion '!in_irq() && (local_irq_is_enabled() || num_online_cpus() <= 1)' failed at common/xmalloc_tlsf.c:714 (XEN) ----[ Xen-4.19.1-pre arm64 debug=y Tainted: I ]---- (XEN) CPU: 2 (XEN) PC: 00000a000022d2b0 xfree+0x130/0x1a4 (XEN) LR: 00000a000022d2a4 (XEN) SP: 00008000fff77b50 (XEN) CPSR: 00000000200002c9 MODE:64-bit EL2h (Hypervisor, handler) ... (XEN) Xen call trace: (XEN) [<00000a000022d2b0>] xfree+0x130/0x1a4 (PC) (XEN) [<00000a000022d2a4>] xfree+0x124/0x1a4 (LR) (XEN) [<00000a00002321f0>] arinc653.c#a653sched_free_udata+0x50/0xc4 (XEN) [<00000a0000241bc0>] core.c#sched_move_domain_cleanup+0x5c/0x80 (XEN) [<00000a0000245328>] sched_move_domain+0x69c/0x70c (XEN) [<00000a000022f840>] cpupool.c#cpupool_move_domain_locked+0x38/0x70 (XEN) [<00000a0000230f20>] cpupool_move_domain+0x34/0x54 (XEN) [<00000a0000206c40>] domain_kill+0xc0/0x15c (XEN) [<00000a000022e0d4>] do_domctl+0x904/0x12ec (XEN) [<00000a0000277a1c>] traps.c#do_trap_hypercall+0x1f4/0x288 (XEN) [<00000a0000279018>] do_trap_guest_sync+0x448/0x63c (XEN) [<00000a0000262c80>] entry.o#guest_sync_slowpath+0xa8/0xd8 (XEN) (XEN) (XEN) **************************************** (XEN) Panic on CPU 2: (XEN) Assertion '!in_irq() && (local_irq_is_enabled() || num_online_cpus() <= 1)' failed at common/xmalloc_tlsf.c:714 (XEN) **************************************** In commit 19049f8d (sched: fix locking in a653sched_free_vdata()), locking was introduced to prevent a race against the list manipulation but leads to assertion failure when the ARINC 653 domain is shutdown. I think this can be fixed by calling xfree() after spin_unlock_irqrestore() as shown below. xen/common/sched/arinc653.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Regards, Anderson diff --git a/xen/common/sched/arinc653.c b/xen/common/sched/arinc653.c index 7bf288264c..1615f1bc46 100644 --- a/xen/common/sched/arinc653.c +++ b/xen/common/sched/arinc653.c @@ -463,10 +463,11 @@ a653sched_free_udata(const struct scheduler *ops, void *priv) if ( !is_idle_unit(av->unit) ) list_del(&av->list); - xfree(av); update_schedule_units(ops); spin_unlock_irqrestore(&sched_priv->lock, flags); + + xfree(av); } Can I hear your opinion on this?