From patchwork Tue Mar 29 16:07:32 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: George Dunlap X-Patchwork-Id: 8688711 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 9EBE8C0553 for ; Tue, 29 Mar 2016 16:10:29 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C4BEF202EB for ; Tue, 29 Mar 2016 16:10:28 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1D772034C for ; Tue, 29 Mar 2016 16:10:27 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akwB8-0002Yf-IA; Tue, 29 Mar 2016 16:07:38 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akwB7-0002YK-U4 for xen-devel@lists.xen.org; Tue, 29 Mar 2016 16:07:38 +0000 Received: from [85.158.137.68] by server-16.bemta-3.messagelabs.com id 06/CD-02994-848AAF65; Tue, 29 Mar 2016 16:07:36 +0000 X-Env-Sender: dunlapg@gmail.com X-Msg-Ref: server-16.tower-31.messagelabs.com!1459267655!24409781!1 X-Originating-IP: [209.85.161.182] X-SpamReason: No, hits=0.8 required=7.0 tests=BODY_RANDOM_LONG, RCVD_BY_IP X-StarScan-Received: X-StarScan-Version: 8.11; banners=-,-,- X-VirusChecked: Checked Received: (qmail 49857 invoked from network); 29 Mar 2016 16:07:36 -0000 Received: from mail-yw0-f182.google.com (HELO mail-yw0-f182.google.com) (209.85.161.182) by server-16.tower-31.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 29 Mar 2016 16:07:36 -0000 Received: by mail-yw0-f182.google.com with SMTP id h65so23952955ywe.0 for ; Tue, 29 Mar 2016 09:07:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=TM3Poq6rgZh62/vDryGikSndtpQT6cBOL0ET7lJ6NiA=; b=LiE4jC7XVZlrjAerwl5gmTJZuA76d3LgemBMMbMIfCXMTjnX2r/hwj6oDKLOb4cdwN nvMmy7zGQR/BZM4kZ5GUaVlkkcS4poU6OPid9fcThZNL7tNAob89n7oVzmx/5chbohTv alb8zQuw1Tw6RVHJIgpiaJfU+pd9rTBxYk5oaUQECfOSFj8ZM9LhnLrEvh2ikpB4nnar tJUZD1LKqXZJbytLqpQUhg0gpWVLsOwEYRKCE3XPLPKopGWKut6h909xWKpGhFYnxqwL firfi80UMAFV1u47PPodqHixyiWCT94sIV0ESLecHBZKw1gcDJIQXTDs8jz/TFBTxa/n fQbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc; bh=TM3Poq6rgZh62/vDryGikSndtpQT6cBOL0ET7lJ6NiA=; b=OKxA6PhptdqJQQPj5l82URCsow+CXhmCQgeHBZx2o3MKCRWx7QfWGKl9g6tT4I4ADy oQ/OZmeguc44SznvzLmg4e++544V6E9LUGd7NGhhytEsGmEK7BwDqoWy90a/F5vtniIJ tIPw1j4TXa4aTV8jAEEC/69nT2LI84F7w5SqKEYOJi/2DlSxjioH+xBAYAtTUNU9U/Sa tCxvuPw68SoduKZj3m4rL2cgmx0VfXMuxs3XPfJfMhl6J16sVNL/s209JcBbglg3s5Wj zpMLUvJh6phKXOC02EUVolonSau2J8K1aVIB5e268YyeeyItj2jMNvqgek0XVvKFTKSZ oZIg== X-Gm-Message-State: AD7BkJKcAGSp6O7LGXKPqhGd+cdhd9urtEEQGc8A/VFVJR0pBYPZM3RUmQcjSzp3qFmsm9DfgZUjbUyPkWQtig== MIME-Version: 1.0 X-Received: by 10.129.112.150 with SMTP id l144mr1648990ywc.251.1459267652662; Tue, 29 Mar 2016 09:07:32 -0700 (PDT) Received: by 10.129.145.70 with HTTP; Tue, 29 Mar 2016 09:07:32 -0700 (PDT) In-Reply-To: References: Date: Tue, 29 Mar 2016 17:07:32 +0100 X-Google-Sender-Auth: pm3MU_H8pmhWgo5BEZvYY3bCIjs Message-ID: From: George Dunlap To: Holger Schramm Cc: Stefano Stabellini , "xen-devel@lists.xen.org" Subject: Re: [Xen-devel] Xen 4.6.1 raisin build error etherboot undeclared X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Sat, Mar 26, 2016 at 12:46 PM, Holger Schramm wrote: > Hi there, > > i receive a build error at rombios.c and etherboot not declared. I have > no idea how to fix this. > > One thing i stumbled is this commit: > > http://xenbits.xen.org/gitweb/?p=raisin.git;a=commitdiff;h=5fe3855a6cf69c4aaed89c47b7e7937b9c66d07e It looks like that commit contains a bug -- the patch adds "--enable-rombios", but the text of the patch seems to indicate that "--disable-rombios" is what was wanted. Can you try the attached patch? -George commit 8f40a9a9a61414ef6146da3524420858115600b1 Author: George Dunlap Commit: George Dunlap raisin: Actually disable rombios Commit 5fe3855 meant to disable rombios, but didn't. This causes the following build failure: gcc -O2 -fomit-frame-pointer -m32 -march=i686 -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable -Wno-unused-local-typedefs -D__XEN_TOOLS__ -MMD -MF .rombios.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -mno-tls-direct-seg-refs -DNDEBUG -Werror -fno-stack-protector -fno-exceptions -fno-builtin -msoft-float -I/usr/local/src/xenboil/raisin/xen-dir-remote/tools/firmware/hvmloader/../../../tools/include -U__XEN_TOOLS__ -D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__ -DENABLE_OVMF -DENABLE_ROMBIOS -DENABLE_SEABIOS -c -o rombios.o rombios.c rombios.c: In function ‘rombios_load_roms’: rombios.c:103:39: error: ‘etherboot’ undeclared (first use in this function) etherboot); Disable rombios instead. Reported-by: Holger Schramm Signed-off-by: George Dunlap --- CC: Stefano Stabellini diff --git a/components/xen b/components/xen index 894d119..ea290aa 100644 --- a/components/xen +++ b/components/xen @@ -45,7 +45,7 @@ function xen_build() { export ETHERBOOT_NICS="" ./configure --prefix=$PREFIX --with-system-qemu=$PREFIX/lib/xen/bin/qemu-system-i386 \ --disable-stubdom --disable-qemu-traditional \ - --enable-rombios $seabios_opt $ovmf_opt + --disable-rombios $seabios_opt $ovmf_opt $RAISIN_MAKE $RAISIN_MAKE install DESTDIR="$INST_DIR" unset ETHERBOOT_NICS