From patchwork Thu Dec 22 22:11:47 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 9486919 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7126162AAA for ; Thu, 22 Dec 2016 22:15:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 654EE27F99 for ; Thu, 22 Dec 2016 22:15:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 583082842B; Thu, 22 Dec 2016 22:15:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RCVD_IN_SORBS_SPAM,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C89E927F99 for ; Thu, 22 Dec 2016 22:15:43 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKBb4-00079o-Ir; Thu, 22 Dec 2016 22:12:22 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKBb3-00079i-2U for xen-devel@lists.xenproject.org; Thu, 22 Dec 2016 22:12:21 +0000 Received: from [193.109.254.147] by server-5.bemta-6.messagelabs.com id B8/E8-11476-4CF4C585; Thu, 22 Dec 2016 22:12:20 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBIsWRWlGSWpSXmKPExsVyMfSWi+5h/5g Igwntmhbft0xmcmD0OPzhCksAYxRrZl5SfkUCa8abbq+C10oV5/4vYmlgvCjbxcjFISQwlVFi /5RjjCAOi0A7q8S885PYQBwJgcWsEl/e3ANyOICcHIl90/IhzEKJs03mXYycHLwCghInZz5hA bGFBWQkNp4+xAhiCwl4SnRtPscKYnMK2Ense7aECSL+jkViWZ8WiM0mYCLx/9NfNhCbRUBV4t 7cc+wgtoSAocT1DQ9YIeYHSGx43Qw1P0Diycb7YDUiAmoSixd+YQE5k1lgKpNE++b9jCC3MQu oS6yfJzSBUWgWkvNmIWQWMDKtYtQoTi0qSy3SNbLQSyrKTM8oyU3MzNE1NDDTy00tLk5MT81J TCrWS87P3cQIDFkGINjBeH5t4CFGSQ4mJVHeCy4xEUJ8SfkplRmJxRnxRaU5qcWHGGU4OJQke LX8gHKCRanpqRVpmTnA6IFJS3DwKInwRoOkeYsLEnOLM9MhUqcYLTmOzVr8lIlj2jMQuatzzV MmIZa8/LxUKXHezSANAiANGaV5cONgEX6JUVZKmJcR6EAhnoLUotzMElT5V4ziHIxKwryaIFN 4MvNK4La+AjqICegg2+ZokINKEhFSUg2McVpKh98uXlhXInTWViz1VwST6PSdZqu3MlaU8J7f bH3Q+fGxguC9MTuCzfec77RsLTzMbXxb/9Yn3aes/zjmC/6+vfHSkpVXpjImlsQwxlR3qmnWx V31qFJySag7UOnHstAnweCzLiejTG0BV/Zv1bNHb792XJnO+cFjFmPuBk4Hy7QVkhuUWIozEg 21mIuKEwGrMl+m6wIAAA== X-Env-Sender: alistair23@gmail.com X-Msg-Ref: server-9.tower-27.messagelabs.com!1482444738!78911934!1 X-Originating-IP: [209.85.218.68] X-SpamReason: No, hits=0.3 required=7.0 tests=RCVD_BY_IP X-StarScan-Received: X-StarScan-Version: 9.1.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 14904 invoked from network); 22 Dec 2016 22:12:19 -0000 Received: from mail-oi0-f68.google.com (HELO mail-oi0-f68.google.com) (209.85.218.68) by server-9.tower-27.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 22 Dec 2016 22:12:19 -0000 Received: by mail-oi0-f68.google.com with SMTP id 3so5686441oih.1 for ; Thu, 22 Dec 2016 14:12:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=M+WTIrM9jMXnh42In7WCK2q6QxZPwKpcozWHecOdezQ=; b=tfT56HzMpf0mJCNmmxccKBFC982h73TLgvIWzcAeeEDkFo1BNpTazwXzn18uSdNJnP CBM0cyygvdmhn1Bj3HVolNRP7Z98Moc1GVDQVKj1a4eiFvq+bAWLO23rsdOc80Km7VTP 52AOwvl4nWMAzp94GiDMAz0qctvCJ093FLg3jSMeRzFOvZDISWXV1+HbxxGMOzor26XZ z7TZW6Qneixfz5UT8Sgjayr2WU3AZmqh5aHJOJv8V+aAnBIAD8q5LYho58wrtYdk+XEC frkP1BA10OYnhiEdXGz0EFTpr6Ku9HriLbanaLR0B+AIS1IkjWJDcZ8x4FnfNcbxlRvn LzDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=M+WTIrM9jMXnh42In7WCK2q6QxZPwKpcozWHecOdezQ=; b=iu34K/p7mBHr1lqRDesapSpD6ZBwc8+qn8yIWaTK2YczMcX/isgn7iszHHSAdtRZnv uqil92LytWS941xuDBbr6mbvBZvGDWJyft2P5AapujNws986sTNIyL2ah96xK4sDLxw3 cra/MKx9qm4i56WX0CDFGe9nSlmztHMAgIv3zW78Q3fHSLuJKcf0Y2GmnTwOQ8YjLCWo Do7X6o8lIiBz/zBULUd+qxKYFT0fjB3bMQH0dS4HZLlJMx7ZNArdE5UFnMz2RgFLJKhS bN7hzUC/2ZhAKvEQ6VfnqNzJ7qv4/x5PcEyGMcVJZBPqBM9xdhdUmJP90AMMGgca/7qs zwzQ== X-Gm-Message-State: AIkVDXLesUhqlre5D6QxlQHMBYUb+QDUNupTcGVcZ4nVzCxgdcWqu/z2S34oXTCy1obXp+licg90hveQSGYvzg== X-Received: by 10.202.218.7 with SMTP id r7mr5726068oig.166.1482444738346; Thu, 22 Dec 2016 14:12:18 -0800 (PST) MIME-Version: 1.0 Received: by 10.182.96.6 with HTTP; Thu, 22 Dec 2016 14:11:47 -0800 (PST) In-Reply-To: <7711cdde-7d24-d29e-54b1-312d301dc2eb@cardoe.com> References: <1482263220-3233-1-git-send-email-alistair.francis@xilinx.com> <1482263220-3233-2-git-send-email-alistair.francis@xilinx.com> <585B9FCB020000780012B8F1@prv-mh.provo.novell.com> <22620.10232.892818.52504@mariner.uk.xensource.com> <7711cdde-7d24-d29e-54b1-312d301dc2eb@cardoe.com> From: Alistair Francis Date: Thu, 22 Dec 2016 14:11:47 -0800 X-Google-Sender-Auth: fOBPXraqhtKzMAQWkuKgoVe_1v8 Message-ID: To: Doug Goldstein Cc: Wei Liu , Andrew Cooper , Ian Jackson , Alistair Francis , imhy.yang@gmail.com, Jan Beulich , rshriram@cs.ubc.ca, xen-devel@lists.xenproject.org Subject: Re: [Xen-devel] [PATCH v2 1/5] Remove hardcoded strict -Werror checking X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Dec 22, 2016 at 2:00 PM, Doug Goldstein wrote: > On 12/22/16 3:47 PM, Andrew Cooper wrote: >> On 22/12/16 21:41, Alistair Francis wrote: >>> On Thu, Dec 22, 2016 at 1:15 PM, Alistair Francis >>> wrote: >>>> On Thu, Dec 22, 2016 at 1:12 PM, Alistair Francis >>>> wrote: >>>>> On Thu, Dec 22, 2016 at 11:22 AM, Ian Jackson >>>>> wrote: >>>>>> Alistair Francis writes ("Re: [Xen-devel] [PATCH v2 1/5] Remove >>>>>> hardcoded strict -Werror checking"): >>>>>>> On Thu, Dec 22, 2016 at 12:41 AM, Jan Beulich >>>>>>> wrote: >>>>>>>> On 20.12.16 at 20:46, wrote: >>>>>>>>> Signed-off-by: Alistair Francis >>>>>>>> Without some rationale given I don't think such changes are >>>>>>>> acceptable at all. And then, as already pointed out others, the >>>>>>>> use of -Werror is there not just for fun. If anything I think an >>>>>>>> override to that default could be acceptable. >>>>>>> Unfortunately the APPEND_CFLAGS=-Wno-error doesn't fix all the issues >>>>>>> as I still see warnings/errors when building: tools/kconfig/conf.c. >>>>>> That sounds like a bug to me. Do you know why it's not effective >>>>>> there ? >>>>> It actually might be an issue in the way buildroot is handling the >>>>> arguments. >>>>> >>>>> I'll look into it and see what I find after the holidays. >>> I dug into this a little more. Adding the APPEND_CFLAGS="-Wno-error" >>> fixes almost everything. The only problem I see is in the log below, >>> where tools/kconfig/conf.c fails to build as the -Wno-error doesn't >>> propagate down. >>> >>> If I manage to find a fix today I'll send it, otherwise this can wait >>> until next year. >> >> Something like this? >> >> diff --git a/xen/Makefile b/xen/Makefile >> index dc6862e04d..2d7a567c9c 100644 >> --- a/xen/Makefile >> +++ b/xen/Makefile >> @@ -253,14 +253,14 @@ kconfig := silentoldconfig oldconfig config >> menuconfig defconfig \ >> randconfig >> .PHONY: $(kconfig) >> $(kconfig): >> - $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig >> ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)" $@ >> + $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig >> ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)" >> HOST_EXTRACFLAGS="$(APPEND_CFLAGS)" $@ >> >> include/config/%.conf: include/config/auto.conf.cmd $(KCONFIG_CONFIG) >> - $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig >> ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)" >> silentoldconfig >> + $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig >> ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)" >> HOST_EXTRACFLAGS="$(APPEND_CFLAGS)" silentoldconfig >> >> # Allow people to just run `make` as before and not force them to >> configure >> $(KCONFIG_CONFIG): >> - $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig >> ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)" >> defconfig >> + $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig >> ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)" >> HOST_EXTRACFLAGS="$(APPEND_CFLAGS)" defconfig >> >> # Break the dependency chain for the first run >> include/config/auto.conf.cmd: ; >> > > That should do the trick. > > Reviewed-by: Doug Goldstein I got this to work as well: # Shared Makefile for the various kconfig executables: But yours looks like it should work as well. Do you want to send a patch? Thanks, Alistair > > -- > Doug Goldstein > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel > Reviewed-by: Alistair Francis Tested-by: Alistair Francis diff --git a/xen/tools/kconfig/Makefile b/xen/tools/kconfig/Makefile index aceaaed..32e2359 100644 --- a/xen/tools/kconfig/Makefile +++ b/xen/tools/kconfig/Makefile @@ -155,7 +155,7 @@ check-lxdialog := $(srctree)/$(src)/lxdialog/check-lxdialog.sh # Use recursively expanded variables so we do not call gcc unless # we really need to do so. (Do not call gcc as part of make mrproper) HOST_EXTRACFLAGS += $(shell $(CONFIG_SHELL) $(check-lxdialog) -ccflags) \ - -DLOCALE + -DLOCALE $(APPEND_CFLAGS) # ===========================================================================