From patchwork Mon Feb 15 16:51:08 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Stabellini X-Patchwork-Id: 8316801 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D831D9F399 for ; Mon, 15 Feb 2016 16:54:18 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 11282202FE for ; Mon, 15 Feb 2016 16:54:18 +0000 (UTC) Received: from lists.xen.org (lists.xenproject.org [50.57.142.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 204D6202AE for ; Mon, 15 Feb 2016 16:54:17 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aVMNB-0006Lp-1G; Mon, 15 Feb 2016 16:51:41 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aVMN9-0006LE-QU for xen-devel@lists.xensource.com; Mon, 15 Feb 2016 16:51:39 +0000 Received: from [85.158.137.68] by server-15.bemta-3.messagelabs.com id 92/D0-12946-A1202C65; Mon, 15 Feb 2016 16:51:38 +0000 X-Env-Sender: prvs=84616f07a=Stefano.Stabellini@citrix.com X-Msg-Ref: server-12.tower-31.messagelabs.com!1455555097!22488082!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 63743 invoked from network); 15 Feb 2016 16:51:38 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-12.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 15 Feb 2016 16:51:38 -0000 X-IronPort-AV: E=Sophos;i="5.22,451,1449532800"; d="scan'208";a="331758851" Date: Mon, 15 Feb 2016 16:51:08 +0000 From: Stefano Stabellini X-X-Sender: sstabellini@kaball.uk.xensource.com To: Arnd Bergmann In-Reply-To: <1455278707-2008263-1-git-send-email-arnd@arndb.de> Message-ID: References: <1455278707-2008263-1-git-send-email-arnd@arndb.de> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 X-DLP: MIA1 Cc: Andrew Jones , xen-devel@lists.xensource.com, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tomi Valkeinen , David Vrabel , boris.ostrovsky@oracle.com, Jean-Christophe Plagniol-Villard , linux-arm-kernel@lists.infradead.org Subject: Re: [Xen-devel] [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP CC'ing a few others. On Fri, 12 Feb 2016, Arnd Bergmann wrote: > The Xen framebuffer driver selects the xen keyboard driver, so the latter > will be built-in if XEN_FBDEV_FRONTEND=y. However, when CONFIG_INPUT > is a loadable module, this configuration cannot work. On mainline kernels, > the symbol will be enabled but not used, while in combination with > a patch I have to detect such useless configurations, we get the > expected link failure: > > drivers/input/built-in.o: In function `xenkbd_remove': > xen-kbdfront.c:(.text+0x2f0): undefined reference to `input_unregister_device' > xen-kbdfront.c:(.text+0x30e): undefined reference to `input_unregister_device' > > This changes the dependencies of XEN_FBDEV_FRONTEND so it cannot be > built-in if CONFIG_INPUT=m && CONFIG_INPUT_MISC=y, as that would result > in the broken select. > > As usual, we would be much better off without the 'select', but removing > it now would likely break existing user configurations that depend on > it, so this adds another hack on top to get it working. > > Signed-off-by: Arnd Bergmann > Fixes: 36c1132e34bd ("xen kconfig: fix select INPUT_XEN_KBDDEV_FRONTEND") > --- > drivers/video/fbdev/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > index 8ea45a5cd806..fd3d6fd290a9 100644 > --- a/drivers/video/fbdev/Kconfig > +++ b/drivers/video/fbdev/Kconfig > @@ -2241,6 +2241,7 @@ config FB_VIRTUAL > config XEN_FBDEV_FRONTEND > tristate "Xen virtual frame buffer support" > depends on FB && XEN > + depends on INPUT || !INPUT_MISC > select FB_SYS_FILLRECT > select FB_SYS_COPYAREA > select FB_SYS_IMAGEBLIT This looks very hackish. Couldn't we just do the following? diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index 8ea45a5..3c15f6d 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -2246,7 +2246,7 @@ config XEN_FBDEV_FRONTEND select FB_SYS_IMAGEBLIT select FB_SYS_FOPS select FB_DEFERRED_IO - select INPUT_XEN_KBDDEV_FRONTEND if INPUT_MISC + select INPUT_XEN_KBDDEV_FRONTEND if (INPUT && INPUT_MISC) select XEN_XENBUS_FRONTEND default y help