From patchwork Tue Feb 16 12:14:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Stabellini X-Patchwork-Id: 8324681 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 290F3C02AA for ; Tue, 16 Feb 2016 12:17:42 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 57FD220260 for ; Tue, 16 Feb 2016 12:17:41 +0000 (UTC) Received: from lists.xen.org (lists.xenproject.org [50.57.142.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70F492025B for ; Tue, 16 Feb 2016 12:17:40 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aVeWl-0007Qb-SP; Tue, 16 Feb 2016 12:14:47 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aVeWk-0007QT-LK for xen-devel@lists.xensource.com; Tue, 16 Feb 2016 12:14:46 +0000 Received: from [85.158.137.68] by server-3.bemta-3.messagelabs.com id 97/F2-02499-5B213C65; Tue, 16 Feb 2016 12:14:45 +0000 X-Env-Sender: prvs=8472ebdcc=Stefano.Stabellini@citrix.com X-Msg-Ref: server-11.tower-31.messagelabs.com!1455624883!22197686!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 55366 invoked from network); 16 Feb 2016 12:14:44 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-11.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 16 Feb 2016 12:14:44 -0000 X-IronPort-AV: E=Sophos;i="5.22,455,1449532800"; d="scan'208";a="338414568" Date: Tue, 16 Feb 2016 12:14:14 +0000 From: Stefano Stabellini X-X-Sender: sstabellini@kaball.uk.xensource.com To: Arnd Bergmann In-Reply-To: <2801550.oZPkqjv8nW@wuerfel> Message-ID: References: <1455278707-2008263-1-git-send-email-arnd@arndb.de> <2801550.oZPkqjv8nW@wuerfel> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 X-DLP: MIA1 Cc: linux-fbdev@vger.kernel.org, xen-devel@lists.xensource.com, Stefano Stabellini , Andrew Jones , linux-kernel@vger.kernel.org, Tomi Valkeinen , David Vrabel , boris.ostrovsky@oracle.com, Jean-Christophe Plagniol-Villard , linux-arm-kernel@lists.infradead.org Subject: Re: [Xen-devel] [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, 16 Feb 2016, Arnd Bergmann wrote: > On Monday 15 February 2016 16:51:08 Stefano Stabellini wrote: > > > > > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > > > index 8ea45a5cd806..fd3d6fd290a9 100644 > > > --- a/drivers/video/fbdev/Kconfig > > > +++ b/drivers/video/fbdev/Kconfig > > > @@ -2241,6 +2241,7 @@ config FB_VIRTUAL > > > config XEN_FBDEV_FRONTEND > > > tristate "Xen virtual frame buffer support" > > > depends on FB && XEN > > > + depends on INPUT || !INPUT_MISC > > > select FB_SYS_FILLRECT > > > select FB_SYS_COPYAREA > > > select FB_SYS_IMAGEBLIT > > > > This looks very hackish. Couldn't we just do the following? > > > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > > index 8ea45a5..3c15f6d 100644 > > --- a/drivers/video/fbdev/Kconfig > > +++ b/drivers/video/fbdev/Kconfig > > @@ -2246,7 +2246,7 @@ config XEN_FBDEV_FRONTEND > > select FB_SYS_IMAGEBLIT > > select FB_SYS_FOPS > > select FB_DEFERRED_IO > > - select INPUT_XEN_KBDDEV_FRONTEND if INPUT_MISC > > + select INPUT_XEN_KBDDEV_FRONTEND if (INPUT && INPUT_MISC) > > select XEN_XENBUS_FRONTEND > > default y > > help > > > > No, that doesn't solve the problem: > > If XEN_FBDEV_FRONTEND=y, INPUT=m and INPUT_MISC=y, we would still > get INPUT_XEN_KBDDEV_FRONTEND=y, which cannot work because of INPUT=m. > > INPUT_MISC already depends on INPUT, so your change has no effect > at all. Please correct me if I am wrong, but the difference is that with this change if INPUT=m, then the build system would ask the user whether she wants to select INPUT_XEN_KBDDEV_FRONTEND as m or y, instead of unconditionally set INPUT_XEN_KBDDEV_FRONTEND=y. However it is true that if the users chooses INPUT_XEN_KBDDEV_FRONTEND=y, then the problem persists. Maybe we also need: Do you have a kernel config with INPUT=m that I can use to test with? diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig index 1f2337a..303df24 100644 --- a/drivers/input/misc/Kconfig +++ b/drivers/input/misc/Kconfig @@ -721,7 +721,7 @@ config INPUT_CMA3000_I2C config INPUT_XEN_KBDDEV_FRONTEND tristate "Xen virtual keyboard and mouse support" - depends on XEN + depends on XEN && INPUT default y select XEN_XENBUS_FRONTEND help