From patchwork Sat Dec 10 01:31:45 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Stabellini X-Patchwork-Id: 9469159 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 88FEB607EE for ; Sat, 10 Dec 2016 01:34:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 77B2D28408 for ; Sat, 10 Dec 2016 01:34:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 68AD5284A3; Sat, 10 Dec 2016 01:34:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 021AB28408 for ; Sat, 10 Dec 2016 01:34:04 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFWW0-0002Df-Rx; Sat, 10 Dec 2016 01:31:52 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cFWVz-0002DP-5I for xen-devel@lists.xenproject.org; Sat, 10 Dec 2016 01:31:51 +0000 Received: from [85.158.143.35] by server-7.bemta-6.messagelabs.com id 87/64-29519-60B5B485; Sat, 10 Dec 2016 01:31:50 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFIsWRWlGSWpSXmKPExsVybKJshy5btHe Ewa65TBbft0xmcmD0OPzhCksAYxRrZl5SfkUCa8bO4x9YC76yVnROnsjSwLiGpYuRi0NIYCqj RNexRlYIZzaTxJQdj5m7GDk5WAS0JHZt/8YOYrMJGEr8fbKJrYuRg0MCyF7ymQMkLCKgJHFv1 WQmEJtZwEBiy7MfYOXCAsYSq/+eYgOxeQW8JfrmdYHFRQV0JQ79+wMVF5Q4OfMJC0SvlsTy6d vAbAmBDIl5PXNYIWwviUU3LkHZahJXz21insDIPwtJ+ywk7QsYmVYxahSnFpWlFukaWuolFWW mZ5TkJmbm6BoamOnlphYXJ6an5iQmFesl5+duYgSGGwMQ7GD8sSzgEKMkB5OSKG8xk1eEEF9S fkplRmJxRnxRaU5q8SFGGQ4OJQneS5HeEUKCRanpqRVpmTnAwIdJS3DwKInwJoCkeYsLEnOLM 9MhUqcYdTkOvF/xlEmIJS8/L1VKnLcOpEgApCijNA9uBCwKLzHKSgnzMgIdJcRTkFqUm1mCKv +KUZyDUUmYdwnIFJ7MvBK4Ta+AjmACOmLeDXeQI0oSEVJSDYxFAZVdm883Cb/7eP3OjlWMSs9 mKps5F7+yDl8TdCk7ae/UF4uNJp3+wL5AsXDG9wsWsdNyHgfLTnr0+E/boxsdb1ap51n6snxc 4dt56rlO/aWrugel5FrkOT6GPtK5LCd7tXOpRF7JmitrnWTO+i3rdfNOlBbZ8roxv1F6jqrAl 9sX2YoNGM8psRRnJBpqMRcVJwIATJZDL70CAAA= X-Env-Sender: sstabellini@kernel.org X-Msg-Ref: server-15.tower-21.messagelabs.com!1481333508!47439237!1 X-Originating-IP: [198.145.29.136] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.1.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 23433 invoked from network); 10 Dec 2016 01:31:49 -0000 Received: from mail.kernel.org (HELO mail.kernel.org) (198.145.29.136) by server-15.tower-21.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 10 Dec 2016 01:31:49 -0000 Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 97790203E6; Sat, 10 Dec 2016 01:31:47 +0000 (UTC) Received: from [10.1.10.56] (96-82-76-110-static.hfc.comcastbusiness.net [96.82.76.110]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AADA4203E5; Sat, 10 Dec 2016 01:31:46 +0000 (UTC) Date: Fri, 9 Dec 2016 17:31:45 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-X260 To: xen-devel@lists.xenproject.org Message-ID: User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 X-Virus-Scanned: ClamAV using ClamSMTP Cc: julien.grall@arm.com, sstabellini@kernel.org Subject: [Xen-devel] [PATCH] remove dead code from arm/decode.c X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP The rt variable can only be 0 or 7, no need to check if it's 15. Coverity-ID: 1381835 Signed-off-by: Stefano Stabellini diff --git a/xen/arch/arm/decode.c b/xen/arch/arm/decode.c index c6f49a5..decd9dd 100644 --- a/xen/arch/arm/decode.c +++ b/xen/arch/arm/decode.c @@ -58,11 +58,6 @@ static int decode_thumb2(register_t pc, struct hsr_dabt *dabt, uint16_t hw1) /* Undefined opcodes */ goto bad_thumb2; - /* Store/Load single data item */ - if ( rt == 15 ) - /* XXX: Rt == 15 is only invalid for store instruction */ - goto bad_thumb2; - if ( !load && sign ) /* Store instruction doesn't support sign extension */ goto bad_thumb2;