| Message ID | b1585373e39a7cbe023f485aa5a04b093e25ec80.1673362493.git.oleksii.kurochko@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Basic early_printk and smoke test implementation | expand |
Arm maintainers, On 10.01.2023 16:17, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/arch/riscv/include/asm/init.h > @@ -0,0 +1,12 @@ > +#ifndef _XEN_ASM_INIT_H > +#define _XEN_ASM_INIT_H > + > +#endif /* _XEN_ASM_INIT_H */ instead of having RISC-V introduce an empty stub matching what x86 has, what would it take to empty Arm's as well, allowing both present ones to go away and no new one to be introduced? The only thing you have in there is struct init_info, which doesn't feel like it's properly placed in this header (x86 has such stuff in setup.h) ... Jan
Hello Jan, Sorry for breaking into the conversation. On Tue, 2023-01-10 at 18:02 +0100, Jan Beulich wrote: > Arm maintainers, > > On 10.01.2023 16:17, Oleksii Kurochko wrote: > > --- /dev/null > > +++ b/xen/arch/riscv/include/asm/init.h > > @@ -0,0 +1,12 @@ > > +#ifndef _XEN_ASM_INIT_H > > +#define _XEN_ASM_INIT_H > > + > > +#endif /* _XEN_ASM_INIT_H */ > > instead of having RISC-V introduce an empty stub matching what x86 > has, Have you had a chance to look at the answer (Re: [PATCH v1 0/8] Basic early_printk and smoke test implementation) of Andrew: https://lore.kernel.org/xen-devel/299d913c-8095-ad90-ea3b-d46ef74d4fdc@citrix.com/#t I agree with his point regarding the usage of __has_include() to not produce empty headers stubs for RISCV and for future architectures too. > If maintainers are OK I can start to use __has_include() in the > correspondent <xen/*.h> files.what would it take to empty Arm's as > well, allowing both present ones to > go away and no new one to be introduced? The only thing you have in > there > is struct init_info, which doesn't feel like it's properly placed in > this > header (x86 has such stuff in setup.h) ... > > Jan ~Oleksii
On 10/01/2023 17:02, Jan Beulich wrote: > Arm maintainers, Hi Jan, > On 10.01.2023 16:17, Oleksii Kurochko wrote: >> --- /dev/null >> +++ b/xen/arch/riscv/include/asm/init.h >> @@ -0,0 +1,12 @@ >> +#ifndef _XEN_ASM_INIT_H >> +#define _XEN_ASM_INIT_H >> + >> +#endif /* _XEN_ASM_INIT_H */ > > instead of having RISC-V introduce an empty stub matching what x86 has, > what would it take to empty Arm's as well, allowing both present ones to > go away and no new one to be introduced? The only thing you have in there > is struct init_info, which doesn't feel like it's properly placed in this > header (x86 has such stuff in setup.h) ... Yes. setup.h should be a good place even though the header is getting quite crowded. I am happy to send a patch for it. Cheers,
On 10.01.2023 20:16, Oleksii wrote: > Sorry for breaking into the conversation. That's perfectly fine; no need to be sorry. > On Tue, 2023-01-10 at 18:02 +0100, Jan Beulich wrote: >> Arm maintainers, >> >> On 10.01.2023 16:17, Oleksii Kurochko wrote: >>> --- /dev/null >>> +++ b/xen/arch/riscv/include/asm/init.h >>> @@ -0,0 +1,12 @@ >>> +#ifndef _XEN_ASM_INIT_H >>> +#define _XEN_ASM_INIT_H >>> + >>> +#endif /* _XEN_ASM_INIT_H */ >> >> instead of having RISC-V introduce an empty stub matching what x86 >> has, > Have you had a chance to look at the answer (Re: [PATCH v1 0/8] Basic > early_printk and smoke test implementation) of Andrew: > https://lore.kernel.org/xen-devel/299d913c-8095-ad90-ea3b-d46ef74d4fdc@citrix.com/#t > > I agree with his point regarding the usage of __has_include() to not > produce empty headers stubs for RISCV and for future architectures too. Sure, but as he said, that requires settling on a new toolchain baseline, which is something that we've failed to come to any results for, for a considerable number of years. Plus if we could get rid of this (then optional) arch header altogether, it would imo be even better. Jan
diff --git a/xen/arch/riscv/include/asm/init.h b/xen/arch/riscv/include/asm/init.h new file mode 100644 index 0000000000..237ec25e4e --- /dev/null +++ b/xen/arch/riscv/include/asm/init.h @@ -0,0 +1,12 @@ +#ifndef _XEN_ASM_INIT_H +#define _XEN_ASM_INIT_H + +#endif /* _XEN_ASM_INIT_H */ +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */
The following patches require <xen/init.h> which includes <asm/init.h> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com> --- Changes in V3: - Nothing changed --- Changes in V2: - Add explanation comment to the comment message --- xen/arch/riscv/include/asm/init.h | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 xen/arch/riscv/include/asm/init.h