diff mbox series

[XEN,3/5] xen/acpi: Use NULL as a null pointer constant

Message ID bb10a86a08eb36e9f9c6bda899cdc850afada403.1702553835.git.nicola.vetrini@bugseng.com (mailing list archive)
State New, archived
Headers show
Series address remaining violations of MISRA C:2012 Rule 11.9 | expand

Commit Message

Nicola Vetrini Dec. 14, 2023, 11:44 a.m. UTC 
Resolves a violation of MISRA C Rule 11.9.
No functional change.

Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
---
 xen/include/acpi/acmacros.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefano Stabellini Dec. 14, 2023, 9:31 p.m. UTC | #1 
On Thu, 14 Dec 2023, Nicola Vetrini wrote:
> Resolves a violation of MISRA C Rule 11.9.
> No functional change.
> 
> Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Jan Beulich Dec. 18, 2023, 5:05 p.m. UTC | #2 
On 14.12.2023 12:44, Nicola Vetrini wrote:
> --- a/xen/include/acpi/acmacros.h
> +++ b/xen/include/acpi/acmacros.h
> @@ -111,7 +111,7 @@
>  
>  #define ACPI_TO_POINTER(i)              ACPI_ADD_PTR (void,(void *) NULL,(acpi_native_uint) i)
>  #define ACPI_TO_INTEGER(p)              ACPI_PTR_DIFF (p,(void *) NULL)
> -#define ACPI_OFFSET(d,f)                (acpi_size) ACPI_PTR_DIFF (&(((d *)0)->f),(void *) NULL)
> +#define ACPI_OFFSET(d,f)                (acpi_size) ACPI_PTR_DIFF (&(((d *)NULL)->f),(void *) NULL)
>  #define ACPI_PHYSADDR_TO_PTR(i)         ACPI_TO_POINTER(i)
>  #define ACPI_PTR_TO_PHYSADDR(i)         ACPI_TO_INTEGER(i)
>  

This again is an ACPI CA header, which I'm hesitant to see being changed.

Jan
Nicola Vetrini Dec. 18, 2023, 5:29 p.m. UTC | #3 
On 2023-12-18 18:05, Jan Beulich wrote:
> On 14.12.2023 12:44, Nicola Vetrini wrote:
>> --- a/xen/include/acpi/acmacros.h
>> +++ b/xen/include/acpi/acmacros.h
>> @@ -111,7 +111,7 @@
>> 
>>  #define ACPI_TO_POINTER(i)              ACPI_ADD_PTR (void,(void *) 
>> NULL,(acpi_native_uint) i)
>>  #define ACPI_TO_INTEGER(p)              ACPI_PTR_DIFF (p,(void *) 
>> NULL)
>> -#define ACPI_OFFSET(d,f)                (acpi_size) ACPI_PTR_DIFF 
>> (&(((d *)0)->f),(void *) NULL)
>> +#define ACPI_OFFSET(d,f)                (acpi_size) ACPI_PTR_DIFF 
>> (&(((d *)NULL)->f),(void *) NULL)
>>  #define ACPI_PHYSADDR_TO_PTR(i)         ACPI_TO_POINTER(i)
>>  #define ACPI_PTR_TO_PHYSADDR(i)         ACPI_TO_INTEGER(i)
>> 
> 
> This again is an ACPI CA header, which I'm hesitant to see being 
> changed.
> 
> Jan

Yes, I sent this before the discussion on R11.8. I'm ok with adding all 
these files derived from ACPI CA to exclude-list.json, so in that case 
the patch can be ignored.
diff mbox series

Patch

diff --git a/xen/include/acpi/acmacros.h b/xen/include/acpi/acmacros.h
index 86c503c20f3b..e7ca18e3dc66 100644
--- a/xen/include/acpi/acmacros.h
+++ b/xen/include/acpi/acmacros.h
@@ -111,7 +111,7 @@ 
 
 #define ACPI_TO_POINTER(i)              ACPI_ADD_PTR (void,(void *) NULL,(acpi_native_uint) i)
 #define ACPI_TO_INTEGER(p)              ACPI_PTR_DIFF (p,(void *) NULL)
-#define ACPI_OFFSET(d,f)                (acpi_size) ACPI_PTR_DIFF (&(((d *)0)->f),(void *) NULL)
+#define ACPI_OFFSET(d,f)                (acpi_size) ACPI_PTR_DIFF (&(((d *)NULL)->f),(void *) NULL)
 #define ACPI_PHYSADDR_TO_PTR(i)         ACPI_TO_POINTER(i)
 #define ACPI_PTR_TO_PHYSADDR(i)         ACPI_TO_INTEGER(i)