From patchwork Tue Oct 25 12:25:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ayan Kumar Halder X-Patchwork-Id: 13019121 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B5ADC04A95 for ; Tue, 25 Oct 2022 12:26:33 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.429841.681106 (Exim 4.92) (envelope-from ) id 1onJ0Y-0003SY-EW; Tue, 25 Oct 2022 12:26:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 429841.681106; Tue, 25 Oct 2022 12:26:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1onJ0Y-0003SR-Bn; Tue, 25 Oct 2022 12:26:14 +0000 Received: by outflank-mailman (input) for mailman id 429841; Tue, 25 Oct 2022 12:26:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1onJ0W-0003SL-MF for xen-devel@lists.xenproject.org; Tue, 25 Oct 2022 12:26:12 +0000 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2061.outbound.protection.outlook.com [40.107.212.61]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 33c6c753-5460-11ed-8fd0-01056ac49cbb; Tue, 25 Oct 2022 14:26:09 +0200 (CEST) Received: from SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) by CH0PR12MB5300.namprd12.prod.outlook.com (2603:10b6:610:d7::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.35; Tue, 25 Oct 2022 12:26:04 +0000 Received: from SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::901f:4652:83f:c3c2]) by SN6PR12MB2621.namprd12.prod.outlook.com ([fe80::901f:4652:83f:c3c2%7]) with mapi id 15.20.5746.028; Tue, 25 Oct 2022 12:26:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 33c6c753-5460-11ed-8fd0-01056ac49cbb ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AHzj1V/JiVtD41t8ghVGgCO9aS3XXwlWQh6AYJkBJRS5fm4NOW9yVqWMd362UINtcmqPlrHzbtMiOfQY5oGts6+G2fiiO3R5RHpZbY0QfTuk8o+ulR7bVIarunKqyHUseyy0uzLb0J7+wMXLxJ3DCc9/syzA855Ni2NIPso3p3bCOQUXBMIrS2No12pP3xM0xJlfBFT6yJOYX9awj1Uazhn5eKdUjHp5HRlhoqmKOoZTl5TfU2pWNnaFPSN/oZIXdOUitU8+qgVchpIMYHs71asXqcBrpGPt6uwmHIIYHLJcd2vL5nCZSa251gS4j62K69U5z7jfjeW86Awm7/Y3Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=42aTLoPmUHQxgqfWtrsiFWxqbzPntR9zF8FGdEgh8tQ=; b=ZkKHW4FTTbJY8+8Z5ByF/eWiOCCsj4xQvSaCnngQ13jrv75gM/YKyNGUQP0H65MDgpYN9WLa3rJhpWtnI2zv+1Lr6xaA9M749eq2U+uJBqP/PqjEDvBHij2FMMn7YKYHuOJEtdToVZaMWf2MhxmWeObqZyL2EgOSGoP9qAuIVrg+oMGMMRzF5fTqP5t0/qW5yEFFHdl1VdJg8G7srGQ5VvRrOYzlk7mZxgpANVOsi6ZhNaIBsI9fADNcq6BpUFLVbshGAQvGHyYfZkNPRDpW6adZ/ZPwpSiPJkXdEewqwaxwqIpRGnP/wPn08O7ANrV3pbAD5OnC6UTUFGh6I4iSJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=42aTLoPmUHQxgqfWtrsiFWxqbzPntR9zF8FGdEgh8tQ=; b=JDI1JMTkjZ9TRBz8zJ3YesmmXRBotAw9YKEA9t/A83J6IvWuPZRIA43nHIYSZhz5/PqOQfsNxrqa9uQ9in+f9o/CjcHkkynQMprBG6S8oS6gixEDprOIFjrw+aYk71c3H1DlVzxOhkF3aff4DuiiA+918iHEeRWbYmlmvilH+vk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Message-ID: Date: Tue, 25 Oct 2022 13:25:52 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 To: Andre Przywara , "stefanos@xilinx.com" , Julien Grall , bertrand Marquis , "Volodymyr_Babchuk@epam.com" Cc: "xen-devel@lists.xenproject.org" From: Ayan Kumar Halder Subject: GICv3: Aarch32: Need guidance on the atomic access of "union host_lpi" or if ITS is supported on R52 X-ClientProxiedBy: LO2P265CA0007.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::19) To SN6PR12MB2621.namprd12.prod.outlook.com (2603:10b6:805:73::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2621:EE_|CH0PR12MB5300:EE_ X-MS-Office365-Filtering-Correlation-Id: 454836bc-ca3f-4d9c-50a9-08dab68415b6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kosZ5u/NRrwwpAXow4yaIgu+jrg6PsdqB7wXsYDJmkPVE8Y+TmZW1b+CxVcfBU981kXGUW7zqR6iKCK8R3BhSVVsUOIj+9d3RV8O/XalK+1dRVmyPoBVn1z6mPZ3VMLbBgZyh+jUV2mBbqapGH7nFDG3RSuWS69jsMuQ/1ylQ1bFSEfy/ISRC0s9shgfe82nddMx5hF8J6p2q6VRqV+Ky2fWPzAd5q/RasO3i5wPY981ou7v5UmCq1UYhdGIBKOmZbgIDgg2irrtREtIJlYIAReiCAsR0/bGa7w9GyJ++9/ZJZBV23nQuXQDPATicxL+IzgnVcJZtUiWjzuCWR1OyMwHY4Sa8DlvWnV4LlKMhi3NCAMqB6ocnOOkw6ehmgJJ5Wame6Jl+uKSaEmpUd1yp8K3WANkXMc9SVljXp+Wizx22s6TCMLPS3R7q82mRRhz7z0BMgOILB+ory1M2l+S1sJxl4MoD4BBdGNRoHYF/exi4yh7thDk1mDYibYR51a/3XtbiJ6kdvrBY21KsGalGHwSzMzo4Fs6heAp7elAM86VhyaWyzgoX83cekuwnisfBpvHt8fz2lHPW0NlM1TMxPluVLHTYa+/qkGdrcRujt7VWvwqlKw26F6OPStHyxpDkG90JIScV9buMwHKMZRL8IIhChoh8yBuDEHPTqj83TnXvbK2jlNXalqnROI71BmMzjXoTml3U/WFVoKgIJ1J6Uqs8zfc55fTT+X/2Dq36KvK1f32u0l8LiGytecBhThXKoSPD2ViwVS5ULri964bdbXQdqxOSEqVQqvJa7XPYbw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2621.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(136003)(376002)(366004)(346002)(451199015)(66946007)(110136005)(4326008)(6506007)(26005)(66476007)(41300700001)(36756003)(5660300002)(6512007)(8936002)(8676002)(6666004)(66556008)(316002)(83380400001)(186003)(31696002)(2906002)(38100700002)(2616005)(31686004)(6486002)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?N2bM+8ROtUKEIgwI6574WBnTgX0f?= =?utf-8?q?od5ft4YnhRpG91dyOLn3HWUpxB+uzcSN+MoOOqQsahHPUf/CzZ2pD/aHbzUqdms5w?= =?utf-8?q?a3yRSZqZQFwlszC/MeQ3PWXhiyQ/js5cH4m98DSxc8Agf6w0+i1fb57p3VrQz0SJZ?= =?utf-8?q?KCvkLo+KZ0wUyuJNPtdcjDztqqyikaFby9CRbMFNRyqdTdsTMivPBywV7Pg0+4UaN?= =?utf-8?q?lyE7s2HtAOeRMw90pHGF1FkV1rAWkOzWfUYNHYQWt8uzFIGwQtHCTEob8o/iiY0S6?= =?utf-8?q?aUqbfwsDV9Mz69+YKbgxi/2kHiBUKA8hP9WHvQZMnFMlXBxBugTo6/JVgkcKAjGdI?= =?utf-8?q?BUovT1W46sMpSkPwUAKwyuUuWKVxxvDwyDl4DZsnPOJ/0yxt43yvJ8XxvC9KSVJo/?= =?utf-8?q?2+yx9y/T6pq7XKTrWLZ6OEho1xcEe0AlhqozdxOU16ZL361ryZq6FNc2UIiXtH3Jz?= =?utf-8?q?mLcuS9VN+DggHol6g5SRZusgr0lX1SfNAMePJFz1+BeYXCf+dNq29zRkDf3smN0AR?= =?utf-8?q?Fr0XGli4VzIiDhgExuuCTqNDxMOZmX1oD2v1RPcFxN+Xn8BUe5dwaha+JXbAa9I09?= =?utf-8?q?zQdXfJ8gBYd3ekMFFrGE8NsjSm8siHvqBEFSNgRss3X64fjQICU9eCGBT2ljiQqEZ?= =?utf-8?q?7iVHoHCuroJqEqFJ0vEuZ0Dlc8lGJkx1HvyPdP28un8qZddCuHiC8MXiA8H6Pb327?= =?utf-8?q?fKs76bGWR5oZpnlymxr4x34UTJuJRI17PGbMdhzWFS6MRgByC6S7BBhFjHzsDorIP?= =?utf-8?q?pw7ljKyqy8to087ZEMXzQyhunc1VaUqiqTt4eSgaMi+UlpL5m4YlcuI4PCKaPw4vx?= =?utf-8?q?D8kTE2Vjjd2vgrjIDdxD7UXBj5N9m4sUDyveLztJ8eJi3m7nGCZHoZZJfw/7w8lyV?= =?utf-8?q?J/NlfOgCuqGvUtJW7JOp6q1WYF941O2F4Hc1jWQ3f9CKkv/IGewiiCkuUH8wSDk9D?= =?utf-8?q?8TOaKQ7B08zqLVa7gtBlTF9f/6DZMWaW1v5DTHrB9jzfFMlv1hoC9VkMyst4C/99k?= =?utf-8?q?OZCvOkqaeMoQadhhVpl3SndAjc9u/GdkBVJyYWKkieATlNQo7xf9nZ8aOVtZBqmWK?= =?utf-8?q?qTed6KW2t7A6QCLMMcaVQljd36q7dq/MzAYETmSOoSVKufL2CMOjyVDbz927boIFS?= =?utf-8?q?FwEl05C8e3f40R7Tf7U4Vw8CTAsvjTEMMgD1BsEQuyGio9A1e/By5gwxapkO4vq1E?= =?utf-8?q?DNoAA6W5MqtcY9RMPw3KXM83Iwi+zxSJLKqgNAzsiz8s7l7v7dq6Xocsx0WK09W+T?= =?utf-8?q?G91Ag/cQ75PpyWjYkuKocxeM9zBcRvJeI0iUSk2ypIhFhHqMQzWXBFWrNYQfpADD9?= =?utf-8?q?ILHIdyeTNUGGwj/U5/JP22lX4iel+oOjZpUAMn0V7t/rzUH8YLTZYgwRzgrGVDyye?= =?utf-8?q?mJkhn65T11bOGdex3hvSMKo+XVJPI3ohUHhgnqksCsZaq9x1NEk+SD4E9LvMVaj9L?= =?utf-8?q?arQtnbBRp3nYNkW2YMBDIkrvmocJYLL419lKyKdaBzoIFRZCKgaLA5dc2rAkxu7JR?= =?utf-8?q?k5qfQfcHrtFQ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 454836bc-ca3f-4d9c-50a9-08dab68415b6 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2621.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2022 12:26:04.4741 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +8FQosNSKBLmBwQef1j+BRTymyhS/WrXZK6zzUaDdu9X8hqzjp4Kvy/N8SGOF+Sw8pajKRnSDG4iR+mwzqzUFQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5300 Hi Andre/All, This came up while porting Xen on R52. Refer "ARM DDI 0568A.cID110520", B1.3.1 "A Generic Interrupt Controller (GIC) implemented with an Armv8-R PE must not implement LPI support. " Does this mean ITS is not supported on R52 ? I am assuming yes, please correct me if mistaken. If the answer is no, then my next query is follows :- Is it fine to change it as above ? Reading"ARM DDI 0487G.bID07202", E2.2.1, "Requirements for single-copy atomicity". "LDRD and STRD accesses to 64-bit aligned locations are 64-bit single-copy atomic as seen by translation table walks and accesses to translation tables" Does this imply that atomicity will be retained (with the above change) ? Os will this require ldrexd/strexd as R52 supports MPU (not MMU, so translation tables are irrelevant). Kind regards, Ayan diff --git a/xen/arch/arm/gic-v3-lpi.c b/xen/arch/arm/gic-v3-lpi.c index 9ca74bc321..dea60aac0d 100644 --- a/xen/arch/arm/gic-v3-lpi.c +++ b/xen/arch/arm/gic-v3-lpi.c @@ -423,7 +423,7 @@ int gicv3_lpi_init_host_lpis(unsigned int host_lpi_bits)      int rc;      /* We rely on the data structure being atomically accessible. */ -    BUILD_BUG_ON(sizeof(union host_lpi) > sizeof(unsigned long)); +    BUILD_BUG_ON(sizeof(union host_lpi) > sizeof(uint64_t)); "unsigned long" on Aarch32 is 32 bits. So this bug gets triggered.