| Message ID | c4f778440688a1e1f81cc149aca8dd5248895f68.1696232393.git.nicola.vetrini@bugseng.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Fix or deviate various instances of missing declarations | expand |
On Mon, 2 Oct 2023, Nicola Vetrini wrote: > The definition of 'consoled_guest_tx' can be static inline, > thereby fixing a violation of MISRA C:2012 Rule 8.4. > > Fixes: 5ef49f185c2d ("x86/pv-shim: shadow PV console's page for L2 DomU") > Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > --- > xen/include/xen/consoled.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/include/xen/consoled.h b/xen/include/xen/consoled.h > index fd5d220a8aca..e943d8d48f7b 100644 > --- a/xen/include/xen/consoled.h > +++ b/xen/include/xen/consoled.h > @@ -12,7 +12,7 @@ size_t consoled_guest_tx(char c); > > #else > > -size_t consoled_guest_tx(char c) { return 0; } > +static inline size_t consoled_guest_tx(char c) { return 0; } > > #endif /* !CONFIG_PV_SHIM */ > #endif /* __XEN_CONSOLED_H__ */ > -- > 2.34.1 >
diff --git a/xen/include/xen/consoled.h b/xen/include/xen/consoled.h index fd5d220a8aca..e943d8d48f7b 100644 --- a/xen/include/xen/consoled.h +++ b/xen/include/xen/consoled.h @@ -12,7 +12,7 @@ size_t consoled_guest_tx(char c); #else -size_t consoled_guest_tx(char c) { return 0; } +static inline size_t consoled_guest_tx(char c) { return 0; } #endif /* !CONFIG_PV_SHIM */ #endif /* __XEN_CONSOLED_H__ */
The definition of 'consoled_guest_tx' can be static inline, thereby fixing a violation of MISRA C:2012 Rule 8.4. Fixes: 5ef49f185c2d ("x86/pv-shim: shadow PV console's page for L2 DomU") Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com> --- xen/include/xen/consoled.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)