| Message ID | c929f784466e1ba57c19663e88f22c598d961709.1707146506.git.oleksii.kurochko@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Enable build of full Xen for RISC-V | expand |
On 05.02.2024 16:32, Oleksii Kurochko wrote: > No specific header is needed to include in public/hvm/save.h for > PPC and RISC-V for now. > > Code related to PPC was changed based on the comment: > https://lore.kernel.org/xen-devel/c2f3280e-2208-496b-a0b5-fda1a2076b3a@raptorengineering.com/ > > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com> Acked-by: Jan Beulich <jbeulich@suse.com> Albeit I don't see why ... > --- a/xen/include/public/hvm/save.h > +++ b/xen/include/public/hvm/save.h > @@ -89,8 +89,8 @@ DECLARE_HVM_SAVE_TYPE(END, 0, struct hvm_save_end); > #include "../arch-x86/hvm/save.h" > #elif defined(__arm__) || defined(__aarch64__) > #include "../arch-arm/hvm/save.h" > -#elif defined(__powerpc64__) > -#include "../arch-ppc.h" > +#elif defined(__powerpc64__) || defined(__riscv) > +/* no specific header to include */ > #else ... this isn't simply #elif !defined(__powerpc64__) && !defined(__riscv) Jan > #error "unsupported architecture" > #endif
On Mon, 2024-02-12 at 16:05 +0100, Jan Beulich wrote: > On 05.02.2024 16:32, Oleksii Kurochko wrote: > > No specific header is needed to include in public/hvm/save.h for > > PPC and RISC-V for now. > > > > Code related to PPC was changed based on the comment: > > https://lore.kernel.org/xen-devel/c2f3280e-2208-496b-a0b5-fda1a2076b3a@raptorengineering.com/ > > > > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com> > > Acked-by: Jan Beulich <jbeulich@suse.com> > > Albeit I don't see why ... > > > --- a/xen/include/public/hvm/save.h > > +++ b/xen/include/public/hvm/save.h > > @@ -89,8 +89,8 @@ DECLARE_HVM_SAVE_TYPE(END, 0, struct > > hvm_save_end); > > #include "../arch-x86/hvm/save.h" > > #elif defined(__arm__) || defined(__aarch64__) > > #include "../arch-arm/hvm/save.h" > > -#elif defined(__powerpc64__) > > -#include "../arch-ppc.h" > > +#elif defined(__powerpc64__) || defined(__riscv) > > +/* no specific header to include */ > > #else > > ... this isn't simply > > #elif !defined(__powerpc64__) && !defined(__riscv) I can change that to your option in the next patch version if the patch won't be merged now. ~ Oleksii > > > #error "unsupported architecture" > > #endif >
diff --git a/xen/include/public/hvm/save.h b/xen/include/public/hvm/save.h index 5561495b27..72e16ab5bc 100644 --- a/xen/include/public/hvm/save.h +++ b/xen/include/public/hvm/save.h @@ -89,8 +89,8 @@ DECLARE_HVM_SAVE_TYPE(END, 0, struct hvm_save_end); #include "../arch-x86/hvm/save.h" #elif defined(__arm__) || defined(__aarch64__) #include "../arch-arm/hvm/save.h" -#elif defined(__powerpc64__) -#include "../arch-ppc.h" +#elif defined(__powerpc64__) || defined(__riscv) +/* no specific header to include */ #else #error "unsupported architecture" #endif
No specific header is needed to include in public/hvm/save.h for PPC and RISC-V for now. Code related to PPC was changed based on the comment: https://lore.kernel.org/xen-devel/c2f3280e-2208-496b-a0b5-fda1a2076b3a@raptorengineering.com/ Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com> --- Changes in V4: - Updated the commit message --- Changes in V3: - update the commit message. - For PPC and RISC-V nothing to include in public/hvm/save.h, so just comment was added. --- Changes in V2: - remove copyright an the top of hvm/save.h as the header write now is a newly introduced empty header. --- xen/include/public/hvm/save.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)